From: Conor Dooley <conor@kernel.org>
To: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
Cc: Yangyu Chen <cyy@cyyself.name>,
linux-riscv@lists.infradead.org,
Damien Le Moal <dlemoal@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-gpio@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 10/11] riscv: dts: add initial canmv-k230 and k230-evb dts
Date: Fri, 26 Dec 2025 15:30:34 +0000 [thread overview]
Message-ID: <20251226-immunity-morale-67aad0a0fda1@spud> (raw)
In-Reply-To: <aUzjn3XHJTSl3vY9@duge-virtual-machine>
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
On Thu, Dec 25, 2025 at 03:11:27PM +0800, Jiayu Du wrote:
> On Sat, Mar 23, 2024 at 08:12:22PM +0800, Yangyu Chen wrote:
> ...
> > diff --git a/arch/riscv/boot/dts/canaan/k230.dtsi b/arch/riscv/boot/dts/canaan/k230.dtsi
> ...
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + };
>
> The aliases should be set in the board-level dts file,
> so please consider removing the aliases.
>
> ...
> > +
> > + plic: interrupt-controller@f00000000 {
> > + compatible = "canaan,k230-plic" ,"thead,c900-plic";
> Incorrect comma separation. It should be: "canaan,k230-plic", "thead,c900-plic";
If you send a follow-up patch, I'll squash it into my current k230
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/log/?h=k230-basic
> > + reg = <0xf 0x00000000 0x0 0x04000000>;
> > + interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;
> > + interrupt-controller;
> > + #address-cells = <0>;
> > + #interrupt-cells = <2>;
> ...
> > --
> > 2.43.0
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-12-26 15:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 12:09 [PATCH v6 00/11] riscv: add initial support for Canaan Kendryte K230 Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 01/11] dt-bindings: riscv: Add T-HEAD C908 compatible Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 02/11] dt-bindings: add Canaan K230 boards compatible strings Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 03/11] dt-bindings: timer: Add Canaan K230 CLINT Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 04/11] dt-bindings: interrupt-controller: Add Canaan K230 PLIC Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 05/11] riscv: Kconfig.socs: Split ARCH_CANAAN and SOC_CANAAN_K210 Yangyu Chen
2024-03-25 10:52 ` Dan Carpenter
2024-03-25 11:10 ` Conor Dooley
2024-03-23 12:12 ` [PATCH v6 06/11] soc: canaan: Deprecate SOC_CANAAN and use SOC_CANAAN_K210 for K210 Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 07/11] clk: k210: Deprecate SOC_CANAAN and use SOC_CANAAN_K210 Yangyu Chen
2024-04-05 21:47 ` Stephen Boyd
2024-03-23 12:12 ` [PATCH v6 08/11] pinctrl: " Yangyu Chen
2024-04-02 12:31 ` Linus Walleij
2024-04-02 12:56 ` Conor Dooley
2024-04-04 11:58 ` Linus Walleij
2024-04-03 8:38 ` Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 09/11] reset: " Yangyu Chen
2024-03-23 12:12 ` [PATCH v6 10/11] riscv: dts: add initial canmv-k230 and k230-evb dts Yangyu Chen
2024-03-24 16:23 ` Icenowy Zheng
2024-03-25 3:10 ` Yangyu Chen
2024-04-05 15:52 ` Conor Dooley
2024-03-24 16:24 ` Icenowy Zheng
2024-03-25 2:59 ` Yangyu Chen
2024-03-25 2:03 ` Qingfang Deng
2024-03-25 2:57 ` Yangyu Chen
2025-12-25 7:11 ` Jiayu Du
2025-12-26 15:30 ` Conor Dooley [this message]
2024-03-23 12:12 ` [PATCH v6 11/11] riscv: config: enable ARCH_CANAAN in defconfig Yangyu Chen
2024-04-03 18:22 ` [PATCH v6 00/11] riscv: add initial support for Canaan Kendryte K230 Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251226-immunity-morale-67aad0a0fda1@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=guoren@kernel.org \
--cc=jiayu.riscv@isrc.iscas.ac.cn \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox