Re: [PATCH v2 1/6] dt-bindings: iio: frequency: add adf41513

Krzysztof Kozlowski
2025-12-21T13:03:00Z

On 20/12/2025 19:05, 455.rodrigo.alencar@gmail.com wrote:
> Hi Krzystof,
>
> thanks for taking a look into this again. It was my first patch it didn't want
> to draw more attention or discussion to the V1 patch as it was declared not ready
> at its very first review.
>
> On 25/12/20 10:21AM, Krzysztof Kozlowski wrote:
>> On Fri, Dec 19, 2025 at 12:34:48PM +0000, Rodrigo Alencar wrote:
>>> dt-bindings for ADF41513, an ultralow noise PLL frequency synthesizer that
>>> can be used to implement local oscillators (LOs) as high as 26.5 GHz.
>>> Most properties refer to existing PLL driver properties (e.g. ADF4350).
>>
>> What is "existing PLL driver"? I know about motor drivers, but can you
>> drive PLL?
>>
>> And how is ADF4350 related to this binding. I do not see ADF4350
>> compatible here at all. Describe hardware, a real one.
>
> ADF4350 is an older one, and its bindings can be found at:
> Documentation/devicetree/bindings/iio/frequency/adi,adf4350.yaml
> It is a similar part, but yet very different.
>
>>
>> Nothing improved.
>>
>> You ignored comments, did not bother to respond to them and then sent
>> the same.
>
> Sorry for not responding on the V1 thread, but the previous patch had to be reviewed internally
> first. It is not true that nothing is improved, in fact, it has changed a lot, here are some notes:

Process is not like that. You first review internally, then you send.
After you sent and receive comments, you respond to these comments.

> * adi,power-up-frequency is not carrying the -hz postfix because it forces to be a uint32 by
> the dt-bindings check. For that variable it needs to be uint64 as the part supports up to 26.5 GHz > 2^32

And what granularity do you need? Why mhz does not work?

> * The properties related to the reference input signal path: reference-div-factor, reference-doubler-enable
> reference-div2-enable are declared here because they are constraints for the PFD frequency definition,
> which is the frequency that the output signal is updated, important for the loop-filter and VCO design.
> * added support for all different power supply regulators.

Sorry, but I cannot respond that way. We discuss inline, so I have
entire picture, not some parts of message semi-quoted here. I don't
remember what was there and I am not going to keep looking for that.

You need to adjust to mailing list discussion style, not introduce the
others. I have just way too many other patches to deal with, so
implement the feedback or respond properly.

Best regards,
Krzysztof