[PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Akhila YS]

Convert Microchip 23K256 SPI SRAM MTD driver binding to YAML format.

Signed-off-by: Akhila YS <akhilayalmati@gmail.com>
---
 .../bindings/mtd/microchip,mchp23k256.txt          | 18 -------
 .../bindings/mtd/microchip,mchp23k256.yaml         | 58 ++++++++++++++++++++++
 2 files changed, 58 insertions(+), 18 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt
deleted file mode 100644
index 7328eb92a03c..000000000000
--- a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-* MTD SPI driver for Microchip 23K256 (and similar) serial SRAM
-
-Required properties:
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- compatible : Must be one of "microchip,mchp23k256" or "microchip,mchp23lcv1024"
-- reg : Chip-Select number
-- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
-
-Example:
-
-	spi-sram@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "microchip,mchp23k256";
-		reg = <0>;
-		spi-max-frequency = <20000000>;
-	};
diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml
new file mode 100644
index 000000000000..e6cdfa5f0808
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip 23K256 (and similar) SPI SRAM MTD driver
+
+maintainers:
+  - Richard Weinberger <richard@nod.at>
+
+description: |
+  Driver for Microchip 23K256 and compatible (e.g. 23LCV1024) serial SRAM devices
+  accessed via SPI. The device exposes the SRAM as an MTD device and supports
+  optional partitioning via child nodes.
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    enum:
+      - microchip,mchp23k256
+      - microchip,mchp23lcv1024
+
+  reg:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+required:
+  - reg
+  - compatible
+  - "#address-cells"
+  - "#size-cells"
+  - spi-max-frequency
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sram@0 {
+            #address-cells = <1>;
+            #size-cells = <1>;
+            compatible = "microchip,mchp23k256";
+            reg = <0>;
+            spi-max-frequency = <20000000>;
+        };
+    };
+...

---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251229-nxp-526e29da9f29

Best regards,
-- 
Akhila YS <akhilayalmati@gmail.com>

Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Krzysztof Kozlowski]

On Mon, Dec 29, 2025 at 12:49:00PM +0000, Akhila YS wrote:
> +---
> +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip 23K256 (and similar) SPI SRAM MTD driver

driver? Bindings are for hardware.

> +
> +maintainers:
> +  - Richard Weinberger <richard@nod.at>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  Driver for Microchip 23K256 and compatible (e.g. 23LCV1024) serial SRAM devices

Don't describe drivers...

> +  accessed via SPI. The device exposes the SRAM as an MTD device and supports
> +  optional partitioning via child nodes.

nor DTS, but the hardware.

> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +

If this is SRAM, then it should go to sram directory. But maybe it is
MTD, so NOR or NAND? If so you would be missing here refs to NAND
chips.

Although docs are saying it is SRAM, so just place it there.

> +properties:
> +  compatible:
> +    enum:
> +      - microchip,mchp23k256
> +      - microchip,mchp23lcv1024
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1

Pretty incomplete. Old binding and above cells claim there can be child
nodes, so please add them and test. Works? No. Shall work? Yes... so
either old binding was incorrect or new binding is incomplete. I did not
check the driver, though.

> +
> +required:
> +  - reg
> +  - compatible
> +  - "#address-cells"
> +  - "#size-cells"
> +  - spi-max-frequency
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sram@0 {
> +            #address-cells = <1>;
> +            #size-cells = <1>;

They are redundant. Where are children?

> +            compatible = "microchip,mchp23k256";
> +            reg = <0>;
> +            spi-max-frequency = <20000000>;
> +        };
> +    };
> +...
> 
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20251229-nxp-526e29da9f29
> 
> Best regards,
> -- 
> Akhila YS <akhilayalmati@gmail.com>
> 

Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Akhila YS]

On 02-01-2026 13:47, Akhila YS wrote:
>
>
> On 30-12-2025 18:02, Krzysztof Kozlowski wrote:
>> On Mon, Dec 29, 2025 at 12:49:00PM +0000, Akhila YS wrote:
>>> +---
>>> +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Microchip 23K256 (and similar) SPI SRAM MTD driver
>> driver? Bindings are for hardware.
>
>
> Sure, I will fix it.
>
>>> +
>>> +maintainers:
>>> +  - Richard Weinberger <richard@nod.at>
>>> +
>>> +description: |
>> Do not need '|' unless you need to preserve formatting.
> Ok.
>>> +  Driver for Microchip 23K256 and compatible (e.g. 23LCV1024) serial SRAM devices
>> Don't describe drivers...
>>
>>> +  accessed via SPI. The device exposes the SRAM as an MTD device and supports
>>> +  optional partitioning via child nodes.
>> nor DTS, but the hardware.
>
>
> OK, I will change it.
>
>>> +
>>> +allOf:
>>> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>>> +
>> If this is SRAM, then it should go to sram directory. But maybe it is
>> MTD, so NOR or NAND? If so you would be missing here refs to NAND
>> chips.
>>
>> Although docs are saying it is SRAM, so just place it there.
>
> This SRAM is not generic MMIO SRAM, it's an SPI peripheral exposing
> memory via the MTD subsystem. Also i tried Yaml from sram directory it
> doesn't work with it.
>
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - microchip,mchp23k256
>>> +      - microchip,mchp23lcv1024
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 1
>> Pretty incomplete. Old binding and above cells claim there can be child
>> nodes, so please add them and test. Works? No. Shall work? Yes... so
>> either old binding was incorrect or new binding is incomplete. I did not
>> check the driver, though.
>
>
> Size cells and Address cells are not required as there is no child
> node and I tried to define child node , Included SRAM.Yaml as a
> reference file and tested it. It doesn't work.
>
>>> +
>>> +required:
>>> +  - reg
>>> +  - compatible
>>> +  - "#address-cells"
>>> +  - "#size-cells"
>>> +  - spi-max-frequency
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    spi {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        sram@0 {
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>> They are redundant. Where are children?
>
>
> They are redundant, There is no child node  and i will remove it.
>
>>> +            compatible = "microchip,mchp23k256";
>>> +            reg = <0>;
>>> +            spi-max-frequency = <20000000>;
>>> +        };
>>> +    };
>>> +...
>>>
>>> ---
>>> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
>>> change-id: 20251229-nxp-526e29da9f29
>>>
>>> Best regards,
>>> -- 
>>> Akhila YS <akhilayalmati@gmail.com>
>>>
-- 
Best Regards,
Akhila.

Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Krzysztof Kozlowski]

On 02/01/2026 09:17, Akhila YS wrote:
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - microchip,mchp23k256
>>> +      - microchip,mchp23lcv1024
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 1
>> Pretty incomplete. Old binding and above cells claim there can be child
>> nodes, so please add them and test. Works? No. Shall work? Yes... so
>> either old binding was incorrect or new binding is incomplete. I did not
>> check the driver, though.
> 
> 
> Size cells and Address cells are not required as there is no child node

Then what is the point of address/size cells if you do not have children?

Anyway, read carefully old binding and the driver code.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Krzysztof Kozlowski]

On 02/01/2026 11:08, Akhila YS wrote:
> 
> On 02-01-2026 13:47, Akhila YS wrote:
>>
>>
>> On 30-12-2025 18:02, Krzysztof Kozlowski wrote:
>>> On Mon, Dec 29, 2025 at 12:49:00PM +0000, Akhila YS wrote:
>>>> +---
>>>> +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Microchip 23K256 (and similar) SPI SRAM MTD driver
>>> driver? Bindings are for hardware.
>>
>>
>> Sure, I will fix it.


I don't know what's this - empty email.

Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Akhila YS]

On 02-01-2026 15:48, Krzysztof Kozlowski wrote:
> On 02/01/2026 09:17, Akhila YS wrote:
>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - microchip,mchp23k256
>>>> +      - microchip,mchp23lcv1024
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  "#address-cells":
>>>> +    const: 1
>>>> +
>>>> +  "#size-cells":
>>>> +    const: 1
>>> Pretty incomplete. Old binding and above cells claim there can be child
>>> nodes, so please add them and test. Works? No. Shall work? Yes... so
>>> either old binding was incorrect or new binding is incomplete. I did not
>>> check the driver, though.
>>
>> Size cells and Address cells are not required as there is no child node
> Then what is the point of address/size cells if you do not have children?
>
> Anyway, read carefully old binding and the driver code.


Yes, I will remove the above cells in the next revision.

>
> Best regards,
> Krzysztof

-- 
Best Regards,
Akhila.