From: Sudarshan Shetty <tessolveupstream@gmail.com>
To: andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sudarshan Shetty <tessolveupstream@gmail.com>
Subject: [PATCH v10 3/5] backlight: gpio: add support for multiple GPIOs for backlight control
Date: Tue, 30 Dec 2025 18:32:25 +0530 [thread overview]
Message-ID: <20251230130227.3503590-4-tessolveupstream@gmail.com> (raw)
In-Reply-To: <20251230130227.3503590-1-tessolveupstream@gmail.com>
Extend the gpio-backlight driver to handle multiple GPIOs instead of a
single one. This allows panels that require driving several enable pins
to be controlled by the backlight framework.
Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
---
drivers/video/backlight/gpio_backlight.c | 61 +++++++++++++++++-------
1 file changed, 45 insertions(+), 16 deletions(-)
diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 728a546904b0..037e1c111e48 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -17,14 +17,18 @@
struct gpio_backlight {
struct device *dev;
- struct gpio_desc *gpiod;
+ struct gpio_desc **gpiods;
+ unsigned int num_gpios;
};
static int gpio_backlight_update_status(struct backlight_device *bl)
{
struct gpio_backlight *gbl = bl_get_data(bl);
+ unsigned int i;
+ int br = backlight_get_brightness(bl);
- gpiod_set_value_cansleep(gbl->gpiod, backlight_get_brightness(bl));
+ for (i = 0; i < gbl->num_gpios; i++)
+ gpiod_set_value_cansleep(gbl->gpiods[i], br);
return 0;
}
@@ -52,6 +56,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
struct backlight_device *bl;
struct gpio_backlight *gbl;
int ret, init_brightness, def_value;
+ unsigned int i;
gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
if (gbl == NULL)
@@ -62,10 +67,22 @@ static int gpio_backlight_probe(struct platform_device *pdev)
def_value = device_property_read_bool(dev, "default-on");
- gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
- if (IS_ERR(gbl->gpiod))
- return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
- "The gpios parameter is missing or invalid\n");
+ gbl->num_gpios = gpiod_count(dev, NULL);
+ if (gbl->num_gpios == 0)
+ return dev_err_probe(dev, -EINVAL,
+ "The gpios parameter is missing or invalid\n");
+ gbl->gpiods = devm_kcalloc(dev, gbl->num_gpios, sizeof(*gbl->gpiods),
+ GFP_KERNEL);
+ if (!gbl->gpiods)
+ return -ENOMEM;
+
+ for (i = 0; i < gbl->num_gpios; i++) {
+ gbl->gpiods[i] =
+ devm_gpiod_get_index(dev, NULL, i, GPIOD_ASIS);
+ if (IS_ERR(gbl->gpiods[i]))
+ return dev_err_probe(dev, PTR_ERR(gbl->gpiods[i]),
+ "Failed to get GPIO at index %u\n", i);
+ }
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
@@ -78,22 +95,34 @@ static int gpio_backlight_probe(struct platform_device *pdev)
}
/* Set the initial power state */
- if (!of_node || !of_node->phandle)
+ if (!of_node || !of_node->phandle) {
/* Not booted with device tree or no phandle link to the node */
bl->props.power = def_value ? BACKLIGHT_POWER_ON
- : BACKLIGHT_POWER_OFF;
- else if (gpiod_get_value_cansleep(gbl->gpiod) == 0)
- bl->props.power = BACKLIGHT_POWER_OFF;
- else
- bl->props.power = BACKLIGHT_POWER_ON;
+ : BACKLIGHT_POWER_OFF;
+ } else {
+ bool all_high = true;
+
+ for (i = 0; i < gbl->num_gpios; i++) {
+ if (gpiod_get_value_cansleep(gbl->gpiods[i]) != 0) {
+ all_high = false;
+ break;
+ }
+ }
+
+ bl->props.power =
+ all_high ? BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF;
+ }
bl->props.brightness = 1;
init_brightness = backlight_get_brightness(bl);
- ret = gpiod_direction_output(gbl->gpiod, init_brightness);
- if (ret) {
- dev_err(dev, "failed to set initial brightness\n");
- return ret;
+
+ for (i = 0; i < gbl->num_gpios; i++) {
+ ret = gpiod_direction_output(gbl->gpiods[i], init_brightness);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to set gpio %u direction\n",
+ i);
}
platform_set_drvdata(pdev, bl);
--
2.34.1
next prev parent reply other threads:[~2025-12-30 13:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 13:02 [PATCH v10 0/5] Add Qualcomm Technologies, Inc. Talos EVK SMARC support Sudarshan Shetty
2025-12-30 13:02 ` [PATCH v10 1/5] dt-bindings: arm: qcom: talos-evk: Add QCS615 Talos EVK SMARC platform Sudarshan Shetty
2025-12-30 15:03 ` Krzysztof Kozlowski
2026-01-04 13:11 ` tessolveupstream
2026-01-05 7:12 ` Krzysztof Kozlowski
2026-01-07 6:58 ` tessolveupstream
2026-01-07 7:20 ` Krzysztof Kozlowski
2026-01-07 11:17 ` Konrad Dybcio
2026-01-14 6:53 ` tessolveupstream
2025-12-30 13:02 ` [PATCH v10 2/5] dt-bindings: backlight: gpio-backlight: allow multiple GPIOs Sudarshan Shetty
2026-01-05 15:52 ` Bjorn Andersson
2025-12-30 13:02 ` Sudarshan Shetty [this message]
2026-01-05 15:38 ` [PATCH v10 3/5] backlight: gpio: add support for multiple GPIOs for backlight control Bjorn Andersson
2026-01-07 5:57 ` tessolveupstream
2026-01-07 8:12 ` Dmitry Baryshkov
2025-12-30 13:02 ` [PATCH v10 4/5] arm64: dts: qcom: talos: Fix inconsistent USB PHY node naming Sudarshan Shetty
2025-12-30 14:42 ` Dmitry Baryshkov
2026-01-07 8:23 ` yuanjiey
2026-01-08 4:51 ` tessolveupstream
2025-12-30 13:02 ` [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board Sudarshan Shetty
2025-12-30 14:45 ` Dmitry Baryshkov
2025-12-30 14:51 ` Konrad Dybcio
2026-01-04 13:46 ` tessolveupstream
2026-01-05 22:13 ` Dmitry Baryshkov
2026-01-06 7:30 ` tessolveupstream
2026-01-08 7:36 ` tessolveupstream
2026-01-08 8:36 ` Konrad Dybcio
2026-01-08 13:02 ` tessolveupstream
2026-01-08 13:06 ` Konrad Dybcio
2026-01-07 8:37 ` yuanjiey
2026-01-08 9:29 ` tessolveupstream
2026-01-08 13:14 ` Konrad Dybcio
2026-01-09 7:21 ` tessolveupstream
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230130227.3503590-4-tessolveupstream@gmail.com \
--to=tessolveupstream@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox