From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Yu-Chun Lin <eleanor.lin@realtek.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de,
cylee12@realtek.com, jyanchou@realtek.com
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, james.tai@realtek.com,
cy.huang@realtek.com, stanley_chang@realtek.com,
eleanor.lin@realtek.com
Subject: Re: [PATCH 6/9] clk: realtek: Add support for mux clock
Date: Mon, 5 Jan 2026 15:04:15 +0300 [thread overview]
Message-ID: <202512310307.swVDgnPU-lkp@intel.com> (raw)
In-Reply-To: <20251229075313.27254-7-eleanor.lin@realtek.com>
Hi Yu-Chun,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yu-Chun-Lin/dt-bindings-clock-Add-Realtek-RTD1625-Clock-Reset-Controller/20251229-155549
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/20251229075313.27254-7-eleanor.lin%40realtek.com
patch subject: [PATCH 6/9] clk: realtek: Add support for mux clock
config: loongarch-randconfig-r072-20251231 (https://download.01.org/0day-ci/archive/20251231/202512310307.swVDgnPU-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202512310307.swVDgnPU-lkp@intel.com/
smatch warnings:
drivers/clk/realtek/clk-regmap-mux.c:23 clk_regmap_mux_get_parent() warn: signedness bug returning '(-22)'
vim +23 drivers/clk/realtek/clk-regmap-mux.c
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 9 static u8 clk_regmap_mux_get_parent(struct clk_hw *hw)
^^
This function returns negative error codes so it needs to be type int.
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 10 {
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 11 struct clk_regmap_mux *clkm = to_clk_regmap_mux(hw);
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 12 int num_parents = clk_hw_get_num_parents(hw);
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 13 u32 val;
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 14 int ret;
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 15
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 16 ret = regmap_read(clkm->clkr.regmap, clkm->mux_ofs, &val);
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 17 if (ret)
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 18 return ret;
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 19
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 20 val = val >> clkm->shift & clkm->mask;
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 21
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 22 if (val >= num_parents)
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 @23 return -EINVAL;
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 24
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 25 return val;
f53de7a7df69f0 Yu-Chun Lin 2025-12-29 26 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-01-05 12:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 7:53 [PATCH 0/9] clk: realtek: Add RTD1625 Clock Support Yu-Chun Lin
2025-12-29 7:53 ` [PATCH 1/9] dt-bindings: clock: Add Realtek RTD1625 Clock & Reset Controller Yu-Chun Lin
2025-12-30 12:11 ` Krzysztof Kozlowski
2026-01-02 5:46 ` Yu-Chun Lin [林祐君]
2025-12-29 7:53 ` [PATCH 2/9] clk: realtek: Add basic reset support Yu-Chun Lin
2025-12-30 12:20 ` Krzysztof Kozlowski
2026-01-02 5:56 ` Yu-Chun Lin [林祐君]
2025-12-29 7:53 ` [PATCH 3/9] clk: realtek: Introduce a common probe() Yu-Chun Lin
2025-12-30 12:17 ` Krzysztof Kozlowski
2025-12-30 18:03 ` kernel test robot
2025-12-30 18:14 ` kernel test robot
2025-12-29 7:53 ` [PATCH 4/9] clk: realtek: Add support for phase locked loops (PLLs) Yu-Chun Lin
2025-12-30 20:18 ` kernel test robot
2025-12-29 7:53 ` [PATCH 5/9] clk: realtek: Add support for gate clock Yu-Chun Lin
2025-12-29 7:53 ` [PATCH 6/9] clk: realtek: Add support for mux clock Yu-Chun Lin
2026-01-05 12:04 ` Dan Carpenter [this message]
2025-12-29 7:53 ` [PATCH 7/9] clk: realtek: Add support for MMC-tuned PLL clocks Yu-Chun Lin
2025-12-29 7:53 ` [PATCH 8/9] clk: realtek: Add RTD1625-CRT clock controller driver Yu-Chun Lin
2025-12-30 12:15 ` Krzysztof Kozlowski
2025-12-29 7:53 ` [PATCH 9/9] clk: realtek: Add RTD1625-ISO " Yu-Chun Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512310307.swVDgnPU-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cy.huang@realtek.com \
--cc=cylee12@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=james.tai@realtek.com \
--cc=jyanchou@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).