From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1315133F38D for ; Mon, 5 Jan 2026 15:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767627964; cv=none; b=rZyZNdcvOYRUdKSFh4PRvzqavBCRsi7TNOX6gAfED7aM3TYLbHk+7SSoCK/TCER6t4d2hW7x30QmfSZByZ1F13uEGEAhIseojGTRnD9u5ytrRRhf7kWJo1U/KV50H8TrMtXp7Q9q6vJL45RYuX+oEOom2DKnxhc+xJ7b7h9jvuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767627964; c=relaxed/simple; bh=SqOtJ170J+RFFwhvH9wZQqBg0xbrxwhxi7WUufuAgOE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pb/SWHn4XhN+fseRWvKcOFJhGo6U5du6k8EpEHv+8EFqPaOHLUsF3R7fg+6ex7SNSRSQ4lvA+D+Ub4AsVMzgXIKfyR2D88iA+i9TxA6JavLc03xcpEKNOrAXN5XR/OEWGAvC+oUziTKyaikHNwvLx0J49CGjB13i3CAmppg5PQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=siYqSzl4; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="siYqSzl4" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id DFEDFC1E489; Mon, 5 Jan 2026 15:45:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D0C1C60726; Mon, 5 Jan 2026 15:45:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5BF16103C8589; Mon, 5 Jan 2026 16:45:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767627958; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=urFj5GEfGN8FUr9AOM2C6eqiJQ8QOnGyn9HuswUxntE=; b=siYqSzl40Vyi3gRkzXNtwSMwEya76+IHz+53auu6Pjt5ozNbdfPZkTRqqklql44NeDop1b g6skmldwyiDb3s414SWmAGzorvgwWlL7tjuFf8dfYjqUbJziGpnCtn4JmMyrLAZvkY65+/ Wad8Z/Xsgu7aVPaJ9jLbde9LuDKwZvkxi2PWu1RplG+8Pgaoc3a1Fc5YBiAhgmVD0t3DNU o/f3kJQQEUpi5xDULWXoaFWYJv0ohNpe+07F6lCVXE+658vVHMueSf+9yr5DZYPzejXDNd VJ+0XZjsUSqZ02HoL4dTROlwgBBOHtXuQx1EH4M3EWIEEA1EO2Q3FCeqzoHJaQ== Date: Mon, 5 Jan 2026 16:45:48 +0100 From: Kory Maincent To: "Luca Ceresoli" Cc: "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Markus Schneider-Pargmann" , "Bajjuri Praneeth" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , Subject: Re: [PATCH v2 13/20] drm/tilcdc: Remove the useless module list support Message-ID: <20260105164548.0f760c66@kmaincent-XPS-13-7390> In-Reply-To: References: <20251211-feature_tilcdc-v2-0-f48bac3cd33e@bootlin.com> <20251211-feature_tilcdc-v2-13-f48bac3cd33e@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On Wed, 17 Dec 2025 15:25:40 +0100 "Luca Ceresoli" wrote: > On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote: > > The tilcdc driver previously supported a sub-module system where > > external display drivers (panels, encoders) could register themselves > > through tilcdc_module_init() and be automatically initialized through > > a module list. This infrastructure became unused after the component > > framework support and panel driver was removed. > > > > Signed-off-by: Kory Maincent (TI.com) =20 >=20 > [...] >=20 > > @@ -562,24 +533,7 @@ static struct platform_driver tilcdc_platform_driv= er =3D > > { .of_match_table =3D tilcdc_of_match, > > }, > > }; > > - > > -static int __init tilcdc_drm_init(void) > > -{ > > - if (drm_firmware_drivers_only()) > > - return -ENODEV; > > - > > - DBG("init"); > > - return platform_driver_register(&tilcdc_platform_driver); > > -} > > - > > -static void __exit tilcdc_drm_fini(void) > > -{ > > - DBG("fini"); > > - platform_driver_unregister(&tilcdc_platform_driver); > > -} > > - > > -module_init(tilcdc_drm_init); > > -module_exit(tilcdc_drm_fini); > > +module_platform_driver(tilcdc_platform_driver); =20 >=20 > Is this hunk related to the removal of the module list? Looks like it > should be a separate patch. Indeed it is not directly related, but a following cleanup. I will put it in another patch. >=20 > With that hunk removed (or kept if I'm wrong and it should stay): > Reviewed-by: Luca Ceresoli --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com