[PATCH] dt-bindings: display: bridge: ldb: Add check for reg and reg-names

[PATCH] dt-bindings: display: bridge: ldb: Add check for reg and reg-names

[Marek Vasut]

Make "reg" property mandatory for all LDB devices and "reg-names"
mandatory for i.MX8MP and i.MX93 which have two "reg" values. The
i.MX6SX has only one "reg" value so the "reg-names" property there
is optional and not needed.

Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
 .../bindings/display/bridge/fsl,ldb.yaml           | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
index 07388bf2b90df..197ae2f2dd36c 100644
--- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
@@ -59,6 +59,7 @@ required:
   - compatible
   - clocks
   - ports
+  - reg
 
 allOf:
   - if:
@@ -73,6 +74,19 @@ allOf:
         ports:
           properties:
             port@2: false
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              const: fsl,imx6sx-ldb
+    then:
+      required:
+        - compatible
+        - clocks
+        - ports
+        - reg
+        - reg-names
 
 additionalProperties: false
 
-- 
2.51.0

Re: [PATCH] dt-bindings: display: bridge: ldb: Add check for reg and reg-names

[Rob Herring]

On Sun, Jan 04, 2026 at 10:34:21PM +0100, Marek Vasut wrote:
> Make "reg" property mandatory for all LDB devices and "reg-names"
> mandatory for i.MX8MP and i.MX93 which have two "reg" values. The
> i.MX6SX has only one "reg" value so the "reg-names" property there
> is optional and not needed.
> 
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  .../bindings/display/bridge/fsl,ldb.yaml           | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> index 07388bf2b90df..197ae2f2dd36c 100644
> --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -59,6 +59,7 @@ required:
>    - compatible
>    - clocks
>    - ports
> +  - reg
>  
>  allOf:
>    - if:
> @@ -73,6 +74,19 @@ allOf:
>          ports:
>            properties:
>              port@2: false
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              const: fsl,imx6sx-ldb
> +    then:
> +      required:
> +        - compatible
> +        - clocks
> +        - ports
> +        - reg

All of these are already required up above. You only need reg-names 
here.

> +        - reg-names
>  
>  additionalProperties: false
>  
> -- 
> 2.51.0
> 

Re: [PATCH] dt-bindings: display: bridge: ldb: Add check for reg and reg-names

[Marek Vasut]

On 1/5/26 11:19 PM, Rob Herring wrote:

[...]

>> +  - if:
>> +      not:
>> +        properties:
>> +          compatible:
>> +            contains:
>> +              const: fsl,imx6sx-ldb
>> +    then:
>> +      required:
>> +        - compatible
>> +        - clocks
>> +        - ports
>> +        - reg
> 
> All of these are already required up above. You only need reg-names
> here.
Fixed in V2, thank you.