From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F57270540; Tue, 6 Jan 2026 17:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721177; cv=none; b=AUOUjCZ6TRw6W4yS6Yqm/ssxRkBW9hsnUM31tT7uzKwOluAwGTwbaEbBEuGyCKcpFfI0soxICtJuN/c7Zu7sdOwiY93RgRUM2NXx354pT53sRAmGTysqei3p6q2WhThuh54NPc4t0BcR7cxBmjaMR024A6s/L1OiPAY0ixsDS34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721177; c=relaxed/simple; bh=UeQThee7Jg0GXveKVrE4HC5sJTaTObfyhIxsWJAiOhI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RQM/SnQtMfogDmjl/6mIyjaWkBorfM7LjehqCtnP2F/KrneN5Cy7l4MVprn91nY2/Uy1/AxAZYN7dxSFVC5eDs4MxKxhfaStP9b8iD7aAi7JmOq8NJ2FQvA3k2By8Ae6lJPOLjgulOxdEZMiEUy+IRE4n9HK8Mti9VT8BDnyeXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j7gmMuN8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j7gmMuN8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45B30C116C6; Tue, 6 Jan 2026 17:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767721177; bh=UeQThee7Jg0GXveKVrE4HC5sJTaTObfyhIxsWJAiOhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j7gmMuN8anFcz7RQ7re6oQHbHF67Z98w65+9ey825G5ZzVqGaI7oDP2EXqTNWbs47 VrbvaZPZ5Xniw5bTLl9yT5UcCEOKqOLSB3dG8nr2ahFc5MO1W1gV3ac89vKnKZgxzu 5XcJZ2zFkRtjETyvD1teebQY2dLfNznR3rzrh6prhtkoK3xQyuDXaJi5pAHhRnRyrT wtTqIX1VeYSlL3BA9LES3wmBK7EYGfJzIP7Uqxwi1tOWOxPGA5Q28VMOoHuz6Vkm5h 934f23hPxZ5Bs3fTVoCl9i6j3ummJEV7SAQ2ex+aMItu9NuXxr5ogMChwZGNs+qFNW A6GJTV9a5Jhkg== Date: Tue, 6 Jan 2026 11:39:36 -0600 From: Rob Herring To: "Lad, Prabhakar" Cc: Krzysztof Kozlowski , Marc Kleine-Budde , Vincent Mailhol , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Biju Das , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names Message-ID: <20260106173936.GA2345468-robh@kernel.org> References: <20251230115814.53536-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251230115814.53536-2-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260102-quirky-hornet-of-downpour-ddda69@quoll> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jan 06, 2026 at 05:17:17PM +0000, Lad, Prabhakar wrote: > Hi Krzysztof, > > Thank you for the review. > > On Fri, Jan 2, 2026 at 11:16 AM Krzysztof Kozlowski wrote: > > > > On Tue, Dec 30, 2025 at 11:58:11AM +0000, Prabhakar wrote: > > > From: Lad Prabhakar > > > > > > Specify the expected reset-names for the Renesas CAN-FD controller on > > > RZ/G2L and RZ/G3E SoCs. > > > > You should explain here from where you got the actual names. > > > > Otherwise you got following review: > > > > > > > > Signed-off-by: Lad Prabhakar > > > --- > > > v1->v2: > > > - Moved reset-names to top-level properties. > > > --- > > > .../bindings/net/can/renesas,rcar-canfd.yaml | 33 +++++++++++-------- > > > 1 file changed, 19 insertions(+), 14 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > > index e129bdceef84..9bfd4f44e4d4 100644 > > > --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > > @@ -122,6 +122,11 @@ properties: > > > > > > resets: true > > > > > > + reset-names: > > > + items: > > > + - const: rstp_n > > > + - const: rstc_n > > > > rst seems redundant. _n as well. Are these names from datasheet? How are > > they called in this device (not the soc) datasheet exactly? Because it > > feels you use pin or SoC names which is not useful. > > > rstp_n/rstc_n are coming from the SoC HW manual and is already used by > the driver (since commit 76e9353a80e9 "can: rcar_canfd: Add support > for RZ/G2L family"). The reset-names existed previously but were > dropped as of commit 466c8ef7b66b "dt-bindings: can: > renesas,rcar-canfd: Simplify the conditional schema". Let me know if > you want me to rename them but the driver will have to maintain the > backward compatibility or do you want me to drop this patch. The names are fine. The above is useful information that should be in the commit msg. Please help us if we've already reviewed something. Rob