From: Rob Herring <robh@kernel.org>
To: Zhang Yi <zhangyi@everest-semi.com>
Cc: broonie@kernel.org, tiwai@suse.com, devicetree@vger.kernel.org,
conor+dt@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
perex@perex.cz, krzk+dt@kernel.org,
amadeuszx.slawinski@linux.intel.com, krzk@kernel.org
Subject: Re: [PATCH 1/5] ASoC: dt-bindings: ES8389: Add property about power supply
Date: Tue, 6 Jan 2026 12:49:36 -0600 [thread overview]
Message-ID: <20260106184936.GA2517797-robh@kernel.org> (raw)
In-Reply-To: <20260105091548.4196-2-zhangyi@everest-semi.com>
On Mon, Jan 05, 2026 at 05:15:44PM +0800, Zhang Yi wrote:
> Add VDDA supply and VDDD supply
>
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>
> ---
> .../devicetree/bindings/sound/everest,es8389.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/everest,es8389.yaml b/Documentation/devicetree/bindings/sound/everest,es8389.yaml
> index a673df485ab3..75ce0bc48904 100644
> --- a/Documentation/devicetree/bindings/sound/everest,es8389.yaml
> +++ b/Documentation/devicetree/bindings/sound/everest,es8389.yaml
> @@ -30,10 +30,20 @@ properties:
> "#sound-dai-cells":
> const: 0
>
> + vdda-supply:
> + description:
> + Analogue power supply.
> +
> + vddd-supply:
> + description:
> + Interface power supply.
> +
> required:
> - compatible
> - reg
> - "#sound-dai-cells"
> + - vddd-supply
> + - vdda-supply
New required properties is an ABI change. That's fine if you know there
are no users without the supplies, but you need to state that in the
commit message.
Rob
next prev parent reply other threads:[~2026-01-06 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 9:15 [PATCH 0/5] ASoC: ES8389: Add some members and update configuration Zhang Yi
2026-01-05 9:15 ` [PATCH 1/5] ASoC: dt-bindings: ES8389: Add property about power supply Zhang Yi
2026-01-06 18:49 ` Rob Herring [this message]
2026-01-05 9:15 ` [PATCH 2/5] ASoC: codecs: ES8389: Add members related to " Zhang Yi
2026-01-05 9:15 ` [PATCH 3/5] ASoC: codecs: ES8389: Adjust wakeup configuration Zhang Yi
2026-01-05 9:15 ` [PATCH 4/5] ASoC: codecs: ES8389: Add members about the version Zhang Yi
2026-01-05 9:15 ` [PATCH 5/5] ASoC: codecs: ES8389: Update clock configuration Zhang Yi
2026-01-06 19:42 ` [PATCH 0/5] ASoC: ES8389: Add some members and update configuration Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106184936.GA2517797-robh@kernel.org \
--to=robh@kernel.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox