From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sa8775p-lpass-lpi-pinctrl: Add SA8775P LPASS pinctrl
Date: Thu, 8 Jan 2026 09:59:11 +0100 [thread overview]
Message-ID: <20260108-outstanding-transparent-weasel-ca531b@quoll> (raw)
In-Reply-To: <20260107192007.500995-2-mohammad.rafi.shaik@oss.qualcomm.com>
On Thu, Jan 08, 2026 at 12:50:06AM +0530, Mohammad Rafi Shaik wrote:
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
> +
> + lpass_tlmm: pinctrl@3440000 {
> + compatible = "qcom,sa8775p-lpass-lpi-pinctrl";
> + reg = <0x03440000 0x20000>,
> + <0x034D0000 0x10000>;
Lowercase hex. Just look at other files, e.g. sm8450.
With this fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-08 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 19:20 [PATCH v2 0/2] pinctrl: qcom: Add SA8775P lpass-lpi Mohammad Rafi Shaik
2026-01-07 19:20 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sa8775p-lpass-lpi-pinctrl: Add SA8775P LPASS pinctrl Mohammad Rafi Shaik
2026-01-08 8:59 ` Krzysztof Kozlowski [this message]
2026-01-07 19:20 ` [PATCH v2 2/2] pinctrl: qcom: sa8775p-lpass-lpi: " Mohammad Rafi Shaik
2026-01-08 9:04 ` Krzysztof Kozlowski
2026-01-08 9:33 ` Mohammad Rafi Shaik
2026-01-08 9:29 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108-outstanding-transparent-weasel-ca531b@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox