[PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Jon Hunter]

This series includes fixes for the realtek,rt5640 dt-binding to address
a few warnings that are observed when running the CHECK_DTBS=y for some
DTBs that use this codec.

Jon Hunter (3):
  ASoC: dt-bindings: realtek,rt5640: Document mclk
  ASoC: dt-bindings: realtek,rt5640: Update jack-detect
  ASoC: dt-bindings: realtek,rt5640: Document port node

 .../devicetree/bindings/sound/realtek,rt5640.yaml   | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.43.0

[PATCH 1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk

[Jon Hunter]

Commit eba5a0bac211 ("ASoC: dt-bindings: realtek,rt5640: Convert to
dtschema") converted the rt5640 dt-binding to yaml format but in the
process dropped 'clock' and 'clock-names' properties that are used to
specify the codec 'mclk'. This is causing DTB build warnings for boards
that use this codec and define an 'mclk' in device-tree. Update the
rt5640 binding document to add the optional mclk.

Fixes: eba5a0bac211 ("ASoC: dt-bindings: realtek,rt5640: Convert to dtschema")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 .../devicetree/bindings/sound/realtek,rt5640.yaml         | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
index 3f4f59287c1c..6bb6e12bdf8b 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
@@ -44,6 +44,14 @@ properties:
       - realtek,rt5640
       - realtek,rt5639
 
+  clocks:
+    items:
+      - description: phandle and clock specifier for codec MCLK.
+
+  clock-names:
+    items:
+      - const: mclk
+
   reg:
     maxItems: 1
 
-- 
2.43.0

Re: [PATCH 1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk

[Krzysztof Kozlowski]

On Thu, Jan 08, 2026 at 02:31:56PM +0000, Jon Hunter wrote:
> Commit eba5a0bac211 ("ASoC: dt-bindings: realtek,rt5640: Convert to
> dtschema") converted the rt5640 dt-binding to yaml format but in the
> process dropped 'clock' and 'clock-names' properties that are used to
> specify the codec 'mclk'. This is causing DTB build warnings for boards
> that use this codec and define an 'mclk' in device-tree. Update the
> rt5640 binding document to add the optional mclk.
> 
> Fixes: eba5a0bac211 ("ASoC: dt-bindings: realtek,rt5640: Convert to dtschema")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  .../devicetree/bindings/sound/realtek,rt5640.yaml         | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect

[Jon Hunter]

The device-tree property 'realtek,jack-detect-source' currently only
permits values from 0-6. However, commit 2b9c8d2b3c89 ("ASoC: rt5640:
Add the HDA header support") updated the Realtek rt5640 to support
setting the 'realtek,jack-detect-source' to 7 to support the HDA header.

The Tegra234 platforms currently set 'realtek,jack-detect-source' to 7
for the HDA header and this is causing a warning when building
device-tree.

 audio-codec@1c (realtek,rt5640): realtek,jack-detect-source:
  7 is not one of [0, 1, 2, 3, 4, 5, 6]

Given that the driver already supports this settings, update the binding
document for the rt5640 device to add the HDA header as a valid
configuration for the 'realtek,jack-detect-source' property.

Fixes: 2b9c8d2b3c89 ("ASoC: rt5640: Add the HDA header support")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
index 6bb6e12bdf8b..e7d4ec29b0ec 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
@@ -106,6 +106,7 @@ properties:
       - 4 # Use GPIO2 for jack-detect
       - 5 # Use GPIO3 for jack-detect
       - 6 # Use GPIO4 for jack-detect
+      - 7 # Use HDA header for jack-detect
 
   realtek,jack-detect-not-inverted:
     description:
-- 
2.43.0

Re: [PATCH 2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect

[Krzysztof Kozlowski]

On Thu, Jan 08, 2026 at 02:31:57PM +0000, Jon Hunter wrote:
> The device-tree property 'realtek,jack-detect-source' currently only
> permits values from 0-6. However, commit 2b9c8d2b3c89 ("ASoC: rt5640:
> Add the HDA header support") updated the Realtek rt5640 to support
> setting the 'realtek,jack-detect-source' to 7 to support the HDA header.
> 
> The Tegra234 platforms currently set 'realtek,jack-detect-source' to 7
> for the HDA header and this is causing a warning when building
> device-tree.
> 
>  audio-codec@1c (realtek,rt5640): realtek,jack-detect-source:
>   7 is not one of [0, 1, 2, 3, 4, 5, 6]
> 
> Given that the driver already supports this settings, update the binding
> document for the rt5640 device to add the HDA header as a valid
> configuration for the 'realtek,jack-detect-source' property.
> 
> Fixes: 2b9c8d2b3c89 ("ASoC: rt5640: Add the HDA header support")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 3/3] ASoC: dt-bindings: realtek,rt5640: Document port node

[Jon Hunter]

Various boards that use the rt5640 audio codec define a 'port' child
node under the codec node to describe the interface between it and the
SoC that it is connected to. The binding document for the rt5640 codec
does not define the 'port' child node and so this is generating warnings
when running the DTB checks for these boards. Add the 'port' node to the
binding document for the rt5640 codec to fix this.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
index e7d4ec29b0ec..2f6a4a6cc0e6 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
@@ -130,6 +130,10 @@ properties:
       - 2 # Scale current by 1.0
       - 3 # Scale current by 1.5
 
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - reg
-- 
2.43.0

Re: [PATCH 3/3] ASoC: dt-bindings: realtek,rt5640: Document port node

[Krzysztof Kozlowski]

On Thu, Jan 08, 2026 at 02:31:58PM +0000, Jon Hunter wrote:
> Various boards that use the rt5640 audio codec define a 'port' child
> node under the codec node to describe the interface between it and the
> SoC that it is connected to. The binding document for the rt5640 codec
> does not define the 'port' child node and so this is generating warnings
> when running the DTB checks for these boards. Add the 'port' node to the
> binding document for the rt5640 codec to fix this.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Mark Brown]

On Thu, 08 Jan 2026 14:31:55 +0000, Jon Hunter wrote:
> This series includes fixes for the realtek,rt5640 dt-binding to address
> a few warnings that are observed when running the CHECK_DTBS=y for some
> DTBs that use this codec.
> 
> Jon Hunter (3):
>   ASoC: dt-bindings: realtek,rt5640: Document mclk
>   ASoC: dt-bindings: realtek,rt5640: Update jack-detect
>   ASoC: dt-bindings: realtek,rt5640: Document port node
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk
      commit: 66b47b9c069fa548db64bde6a32d3b33aa05f740
[2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect
      commit: 25b858474497b5f7e2198f6fc9381488d9bdb55d
[3/3] ASoC: dt-bindings: realtek,rt5640: Document port node
      commit: b540b4e157c4b24d0501e5e50ffba598d066de42

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Jon Hunter]

Hi Mark, Rob,

On 13/01/2026 17:51, Mark Brown wrote:
> On Thu, 08 Jan 2026 14:31:55 +0000, Jon Hunter wrote:
>> This series includes fixes for the realtek,rt5640 dt-binding to address
>> a few warnings that are observed when running the CHECK_DTBS=y for some
>> DTBs that use this codec.
>>
>> Jon Hunter (3):
>>    ASoC: dt-bindings: realtek,rt5640: Document mclk
>>    ASoC: dt-bindings: realtek,rt5640: Update jack-detect
>>    ASoC: dt-bindings: realtek,rt5640: Document port node
>>
>> [...]
> 
> Applied to
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk
>        commit: 66b47b9c069fa548db64bde6a32d3b33aa05f740
> [2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect
>        commit: 25b858474497b5f7e2198f6fc9381488d9bdb55d
> [3/3] ASoC: dt-bindings: realtek,rt5640: Document port node
>        commit: b540b4e157c4b24d0501e5e50ffba598d066de42

I noticed on today's -next I am getting the following error when running
the dtbs_check ...

  Documentation/devicetree/bindings/sound/realtek,rt5640.yaml: ignoring, error parsing file

It appears that Rob also has merged similar fixes to the above and now
we have two lots of fixes merged and duplicated properties ...

  bc5a847a80d4 ASoC: dt-bindings: realtek,rt5640: Various fixes
  f66e7da2a6b1 ASoC: dt-bindings: realtek,rt5640: Allow 7 for realtek,jack-detect-source
  101b982654ac ASoC: dt-bindings: realtek,rt5640: Add missing properties/node
  b540b4e157c4 ASoC: dt-bindings: realtek,rt5640: Document port node
  25b858474497 ASoC: dt-bindings: realtek,rt5640: Update jack-detect
  66b47b9c069f ASoC: dt-bindings: realtek,rt5640: Document mclk

So we need to drop one set of fixes from one of the trees.

Thanks
Jon

-- 
nvpublic

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Wed, Jan 14, 2026 at 11:27:12AM +0000, Jon Hunter wrote:

> I noticed on today's -next I am getting the following error when running
> the dtbs_check ...
> 
>  Documentation/devicetree/bindings/sound/realtek,rt5640.yaml: ignoring, error parsing file

> It appears that Rob also has merged similar fixes to the above and now
> we have two lots of fixes merged and duplicated properties ...

> So we need to drop one set of fixes from one of the trees.

Can you send a patch that puts everything into a good state please?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

On Wed, Jan 14, 2026 at 12:03:18PM +0000, Mark Brown wrote:
> On Wed, Jan 14, 2026 at 11:27:12AM +0000, Jon Hunter wrote:

> > It appears that Rob also has merged similar fixes to the above and now
> > we have two lots of fixes merged and duplicated properties ...

> > So we need to drop one set of fixes from one of the trees.

> Can you send a patch that puts everything into a good state please?

I think I've got it sorted, you'd added the clock properties in
different places so git merge didn't tell me about it like for the other
ones.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>


On Thu, 08 Jan 2026 14:31:55 +0000, Jon Hunter wrote:
> This series includes fixes for the realtek,rt5640 dt-binding to address
> a few warnings that are observed when running the CHECK_DTBS=y for some
> DTBs that use this codec.
> 
> Jon Hunter (3):
>   ASoC: dt-bindings: realtek,rt5640: Document mclk
>   ASoC: dt-bindings: realtek,rt5640: Update jack-detect
>   ASoC: dt-bindings: realtek,rt5640: Document port node
> 
> [...]

Applied, thanks!

[1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk
      commit: 601a821631c55014b02371740c39748d0af916c1
[2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect
      commit: 2efe28d11cc19b69b19b9bcdb6f498c1bf842fbc
[3/3] ASoC: dt-bindings: realtek,rt5640: Document port node
      commit: b2788f6320722d6059f849f35a77eb082608c627

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Rob Herring]

On Fri, Jan 16, 2026 at 6:59 PM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
>
> On Thu, 08 Jan 2026 14:31:55 +0000, Jon Hunter wrote:
> > This series includes fixes for the realtek,rt5640 dt-binding to address
> > a few warnings that are observed when running the CHECK_DTBS=y for some
> > DTBs that use this codec.
> >
> > Jon Hunter (3):
> >   ASoC: dt-bindings: realtek,rt5640: Document mclk
> >   ASoC: dt-bindings: realtek,rt5640: Update jack-detect
> >   ASoC: dt-bindings: realtek,rt5640: Document port node
> >
> > [...]
>
> Applied, thanks!
>
> [1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk
>       commit: 601a821631c55014b02371740c39748d0af916c1
> [2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect
>       commit: 2efe28d11cc19b69b19b9bcdb6f498c1bf842fbc
> [3/3] ASoC: dt-bindings: realtek,rt5640: Document port node
>       commit: b2788f6320722d6059f849f35a77eb082608c627

Please drop these. linux-next is broken. Plus Mark already said he applied them.

Rob

Re: [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

On Tue, Jan 20, 2026 at 07:35:53PM -0600, Rob Herring wrote:
> On Fri, Jan 16, 2026 at 6:59 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> >
> > On Thu, 08 Jan 2026 14:31:55 +0000, Jon Hunter wrote:
> > > This series includes fixes for the realtek,rt5640 dt-binding to address
> > > a few warnings that are observed when running the CHECK_DTBS=y for some
> > > DTBs that use this codec.
> > >
> > > Jon Hunter (3):
> > >   ASoC: dt-bindings: realtek,rt5640: Document mclk
> > >   ASoC: dt-bindings: realtek,rt5640: Update jack-detect
> > >   ASoC: dt-bindings: realtek,rt5640: Document port node
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk
> >       commit: 601a821631c55014b02371740c39748d0af916c1
> > [2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect
> >       commit: 2efe28d11cc19b69b19b9bcdb6f498c1bf842fbc
> > [3/3] ASoC: dt-bindings: realtek,rt5640: Document port node
> >       commit: b2788f6320722d6059f849f35a77eb082608c627
> 
> Please drop these. linux-next is broken. Plus Mark already said he applied them.

Sorry, I missed that. Unfortunately neither patchwork nor b4 show this
information, and I must've scolled by Mark's reply (or forgotten about
it). Dropped from the Tegra tree now.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]