* [PATCH] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema
@ 2026-01-08 21:44 Rob Herring (Arm)
2026-01-09 9:56 ` Krzysztof Kozlowski
2026-01-12 20:08 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-01-08 21:44 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
Bard Liao
Cc: linux-sound, devicetree, linux-kernel
Convert the Realtek RT5661 codec binding to DT schema format. Add
missing clocks/clock-names for MCLK which is in use already. Also add
the standard "#sound-dai-cells" property.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/sound/realtek,rt5651.yaml | 100 ++++++++++++++++++
.../devicetree/bindings/sound/rt5651.txt | 63 -----------
2 files changed, 100 insertions(+), 63 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5651.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/rt5651.txt
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5651.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5651.yaml
new file mode 100644
index 000000000000..dc4f2eef7cf9
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5651.yaml
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5651.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek RT5651 audio CODEC
+
+maintainers:
+ - Bard Liao <bardliao@realtek.com>
+
+description: >
+ This device supports I2C only.
+
+ Pins on the device (for linking into audio routes) for RT5651:
+
+ * DMIC L1
+ * DMIC R1
+ * IN1P
+ * IN2P
+ * IN2N
+ * IN3P
+ * HPOL
+ * HPOR
+ * LOUTL
+ * LOUTR
+ * PDML
+ * PDMR
+
+allOf:
+ - $ref: /schemas/sound/dai-common.yaml#
+
+properties:
+ compatible:
+ const: realtek,rt5651
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: mclk
+
+ '#sound-dai-cells':
+ const: 0
+
+ realtek,in2-differential:
+ type: boolean
+ description: Indicate MIC2 input are differential, rather than single-ended.
+
+ realtek,dmic-en:
+ type: boolean
+ description: Indicates DMIC is used.
+
+ realtek,jack-detect-source:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Select jack-detect input pin.
+ enum: [1, 2, 3]
+
+ realtek,jack-detect-not-inverted:
+ type: boolean
+ description:
+ Normal jack-detect switches give an inverted (active-low) signal. Set this
+ bool in the rare case you've a jack-detect switch which is not inverted.
+
+ realtek,over-current-threshold-microamp:
+ description: Micbias over-current detection threshold in µA.
+ enum: [600, 1500, 2000]
+
+ realtek,over-current-scale-factor:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: >
+ Micbias over-current detection scale factor:
+
+ 0: scale current by 0.5
+ 1: scale current by 0.75
+ 2: scale current by 1.0
+ 3: scale current by 1.5
+ enum: [0, 1, 2, 3]
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ codec@1a {
+ compatible = "realtek,rt5651";
+ reg = <0x1a>;
+ realtek,dmic-en;
+ realtek,in2-differential;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/sound/rt5651.txt b/Documentation/devicetree/bindings/sound/rt5651.txt
deleted file mode 100644
index 56e736a1cba9..000000000000
--- a/Documentation/devicetree/bindings/sound/rt5651.txt
+++ /dev/null
@@ -1,63 +0,0 @@
-RT5651 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-- compatible : "realtek,rt5651".
-
-- reg : The I2C address of the device.
-
-Optional properties:
-
-- realtek,in2-differential
- Boolean. Indicate MIC2 input are differential, rather than single-ended.
-
-- realtek,dmic-en
- Boolean. true if dmic is used.
-
-- realtek,jack-detect-source
- u32. Valid values:
- 1: Use JD1_1 pin for jack-detect
- 2: Use JD1_2 pin for jack-detect
- 3: Use JD2 pin for jack-detect
-
-- realtek,jack-detect-not-inverted
- bool. Normal jack-detect switches give an inverted (active-low) signal,
- set this bool in the rare case you've a jack-detect switch which is not
- inverted.
-
-- realtek,over-current-threshold-microamp
- u32, micbias over-current detection threshold in µA, valid values are
- 600, 1500 and 2000µA.
-
-- realtek,over-current-scale-factor
- u32, micbias over-current detection scale-factor, valid values are:
- 0: Scale current by 0.5
- 1: Scale current by 0.75
- 2: Scale current by 1.0
- 3: Scale current by 1.5
-
-Pins on the device (for linking into audio routes) for RT5651:
-
- * DMIC L1
- * DMIC R1
- * IN1P
- * IN2P
- * IN2N
- * IN3P
- * HPOL
- * HPOR
- * LOUTL
- * LOUTR
- * PDML
- * PDMR
-
-Example:
-
-rt5651: codec@1a {
- compatible = "realtek,rt5651";
- reg = <0x1a>;
- realtek,dmic-en = "true";
- realtek,in2-diff = "false";
-};
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema
2026-01-08 21:44 [PATCH] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema Rob Herring (Arm)
@ 2026-01-09 9:56 ` Krzysztof Kozlowski
2026-01-12 20:08 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-09 9:56 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
Bard Liao, linux-sound, devicetree, linux-kernel
On Thu, Jan 08, 2026 at 03:44:40PM -0600, Rob Herring (Arm) wrote:
> Convert the Realtek RT5661 codec binding to DT schema format. Add
> missing clocks/clock-names for MCLK which is in use already. Also add
> the standard "#sound-dai-cells" property.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../bindings/sound/realtek,rt5651.yaml | 100 ++++++++++++++++++
> .../devicetree/bindings/sound/rt5651.txt | 63 -----------
> 2 files changed, 100 insertions(+), 63 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5651.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/rt5651.txt
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema
2026-01-08 21:44 [PATCH] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema Rob Herring (Arm)
2026-01-09 9:56 ` Krzysztof Kozlowski
@ 2026-01-12 20:08 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-01-12 20:08 UTC (permalink / raw)
To: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley, Bard Liao,
Rob Herring (Arm)
Cc: linux-sound, devicetree, linux-kernel
On Thu, 08 Jan 2026 15:44:40 -0600, Rob Herring (Arm) wrote:
> Convert the Realtek RT5661 codec binding to DT schema format. Add
> missing clocks/clock-names for MCLK which is in use already. Also add
> the standard "#sound-dai-cells" property.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema
commit: 35bffbe49dfd3395c65d76f14d773a1225f3489f
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-12 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 21:44 [PATCH] ASoC: dt-bindings: Convert realtek,rt5651 to DT schema Rob Herring (Arm)
2026-01-09 9:56 ` Krzysztof Kozlowski
2026-01-12 20:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox