From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB5D236A73; Thu, 8 Jan 2026 23:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767913640; cv=none; b=qgWQjzorCdBZVODOkhkMnL2QejO4qWGH5YKXPLVKinZbAcaLNER4uN9eBwDjlnMZRuDdo4xsxWp2HIJhiK/eDdiI9hLZnzRkIFVvUJ7jguRxuIyo8l9DUsiJxRrv+y8S5EpmDJHb/d7OJ4WXg9YQEawfN9dOV7zUfgQDQLqiksU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767913640; c=relaxed/simple; bh=itGA0sAQwkPSQyy1yeJi6PWO4Tl6/tvseQT9XB4Mn5A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QjDb/LvsOG3XaPGU5MmcN+UXOe+PMQ1LRETYvBvvrHAb16L95KNpUHavkGhF+wF4wCCw/fhlcL3Pb/cB0G3xJNqA+njqT9pqbN4OvEKNWG9ji6+dNGSCxM7f2QZbYqUwueZYb9Plb8dHlPMYMMMvWS2b5hEJwuWWYSRj7oy7008= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=F1kIXU7k; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="F1kIXU7k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767913638; x=1799449638; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=itGA0sAQwkPSQyy1yeJi6PWO4Tl6/tvseQT9XB4Mn5A=; b=F1kIXU7k/KTlKE5QQPOHWGzrziYU27BhTo/gHE7PCRwtrrwdoED+2vyk sXjU0Af5HCae1LvYZX4KcVSVBO46vhpqfqaOFQzpGDD9YQyl+3nQs4zuf NE0d5j6eThS+SO3niXaEUhkADe7vnfoiFPrefKW3PX8m08AVQ9aXmRb3W b/kAijJRAfPOd/sswrcVQ/m1qBftXlFTJdvwcYkz+NIu4IYyyHZS14qIq biAwOpRVRvdETdqdzNkXHqTcWko86msISL6Y9vkAETsshG673WPG0OwbH 9d7WDlj2e8F146vS3ncLimzACJzHEJcew2+QWyxbUyahfUcw/iflbK7Z9 g==; X-CSE-ConnectionGUID: As0bKI9/QYu6HI1WhRMcXA== X-CSE-MsgGUID: DWLp87D2QtWigWDRfuSndA== X-IronPort-AV: E=McAfee;i="6800,10657,11665"; a="73157328" X-IronPort-AV: E=Sophos;i="6.21,211,1763452800"; d="scan'208";a="73157328" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 15:07:17 -0800 X-CSE-ConnectionGUID: PqpvMJrqRf2bmyWem2ZD+Q== X-CSE-MsgGUID: tOCliOBfSSSbGqMoN5xf/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,211,1763452800"; d="scan'208";a="234498168" Received: from igk-lkp-server01.igk.intel.com (HELO 92b2e8bd97aa) ([10.211.93.152]) by fmviesa001.fm.intel.com with ESMTP; 08 Jan 2026 15:07:13 -0800 Received: from kbuild by 92b2e8bd97aa with local (Exim 4.98.2) (envelope-from ) id 1vdz5z-000000001sK-1qLo; Thu, 08 Jan 2026 23:07:11 +0000 Date: Fri, 9 Jan 2026 00:06:25 +0100 From: kernel test robot To: Gregory CLEMENT , Rob Herring , Linus Walleij , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Krzysztof Kozlowski , Conor Dooley Cc: oe-kbuild-all@lists.linux.dev, Thomas Petazzoni , Vladimir Kondratiev , =?iso-8859-1?Q?Beno=EEt?= Monin , =?iso-8859-1?Q?Th=E9o?= Lebrun , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH v3 2/4] of: reserved_mem: Support multiple 'reg' entries for memory-region Message-ID: <202601090005.f0WEJEKH-lkp@intel.com> References: <20260107-mtd-memregion-v3-2-f9fc9107b992@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260107-mtd-memregion-v3-2-f9fc9107b992@bootlin.com> Hi Gregory, kernel test robot noticed the following build warnings: [auto build test WARNING on 8f0b4cce4481fb22653697cced8d0d04027cb1e8] url: https://github.com/intel-lab-lkp/linux/commits/Gregory-CLEMENT/of-reserved_mem-Fix-placement-of-__free-annotation/20260107-211455 base: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 patch link: https://lore.kernel.org/r/20260107-mtd-memregion-v3-2-f9fc9107b992%40bootlin.com patch subject: [PATCH v3 2/4] of: reserved_mem: Support multiple 'reg' entries for memory-region config: arm64-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260109/202601090005.f0WEJEKH-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260109/202601090005.f0WEJEKH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202601090005.f0WEJEKH-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/of/of_reserved_mem.c:317:7: warning: variable 'err' is uninitialized when used here [-Wuninitialized] 317 | if (err == -ENOENT && of_get_flat_dt_prop(child, "size", NULL)) { | ^~~ drivers/of/of_reserved_mem.c:300:10: note: initialize the variable 'err' to silence this warning 300 | int err, ret; | ^ | = 0 1 warning generated. vim +/err +317 drivers/of/of_reserved_mem.c 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 278 54c180e73ffa3e Rob Herring 2024-03-11 279 /* 54c180e73ffa3e Rob Herring 2024-03-11 280 * fdt_scan_reserved_mem() - scan a single FDT node for reserved memory 54c180e73ffa3e Rob Herring 2024-03-11 281 */ 54c180e73ffa3e Rob Herring 2024-03-11 282 int __init fdt_scan_reserved_mem(void) 54c180e73ffa3e Rob Herring 2024-03-11 283 { 54c180e73ffa3e Rob Herring 2024-03-11 284 int node, child; 00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 285 int dynamic_nodes_cnt = 0, count = 0; 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 286 int dynamic_nodes[MAX_RESERVED_REGIONS]; 54c180e73ffa3e Rob Herring 2024-03-11 287 const void *fdt = initial_boot_params; 54c180e73ffa3e Rob Herring 2024-03-11 288 54c180e73ffa3e Rob Herring 2024-03-11 289 node = fdt_path_offset(fdt, "/reserved-memory"); 54c180e73ffa3e Rob Herring 2024-03-11 290 if (node < 0) 54c180e73ffa3e Rob Herring 2024-03-11 291 return -ENODEV; 54c180e73ffa3e Rob Herring 2024-03-11 292 54c180e73ffa3e Rob Herring 2024-03-11 293 if (__reserved_mem_check_root(node) != 0) { 54c180e73ffa3e Rob Herring 2024-03-11 294 pr_err("Reserved memory: unsupported node format, ignoring\n"); 54c180e73ffa3e Rob Herring 2024-03-11 295 return -EINVAL; 54c180e73ffa3e Rob Herring 2024-03-11 296 } 54c180e73ffa3e Rob Herring 2024-03-11 297 54c180e73ffa3e Rob Herring 2024-03-11 298 fdt_for_each_subnode(child, fdt, node) { 54c180e73ffa3e Rob Herring 2024-03-11 299 const char *uname; 8be14ac8dccc70 Gregory CLEMENT 2026-01-07 300 int err, ret; 54c180e73ffa3e Rob Herring 2024-03-11 301 54c180e73ffa3e Rob Herring 2024-03-11 302 if (!of_fdt_device_is_available(fdt, child)) 54c180e73ffa3e Rob Herring 2024-03-11 303 continue; 54c180e73ffa3e Rob Herring 2024-03-11 304 54c180e73ffa3e Rob Herring 2024-03-11 305 uname = fdt_get_name(fdt, child, NULL); 54c180e73ffa3e Rob Herring 2024-03-11 306 8be14ac8dccc70 Gregory CLEMENT 2026-01-07 307 ret = __reserved_mem_reserve_reg(child, uname); 8be14ac8dccc70 Gregory CLEMENT 2026-01-07 308 if (ret > 0) 8be14ac8dccc70 Gregory CLEMENT 2026-01-07 309 count += ret; 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 310 /* 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 311 * Save the nodes for the dynamically-placed regions 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 312 * into an array which will be used for allocation right 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 313 * after all the statically-placed regions are reserved 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 314 * or marked as no-map. This is done to avoid dynamically 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 315 * allocating from one of the statically-placed regions. 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 316 */ 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 @317 if (err == -ENOENT && of_get_flat_dt_prop(child, "size", NULL)) { 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 318 dynamic_nodes[dynamic_nodes_cnt] = child; 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 319 dynamic_nodes_cnt++; 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 320 } 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 321 } 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 322 for (int i = 0; i < dynamic_nodes_cnt; i++) { 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 323 const char *uname; 00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 324 int err; 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 325 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 326 child = dynamic_nodes[i]; 8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 327 uname = fdt_get_name(fdt, child, NULL); 00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 328 err = __reserved_mem_alloc_size(child, uname); 00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 329 if (!err) 00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 330 count++; 54c180e73ffa3e Rob Herring 2024-03-11 331 } 00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 332 total_reserved_mem_cnt = count; 54c180e73ffa3e Rob Herring 2024-03-11 333 return 0; 54c180e73ffa3e Rob Herring 2024-03-11 334 } 54c180e73ffa3e Rob Herring 2024-03-11 335 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki