[PATCH v2 0/2] arm64: dts: meson-s4: add support for Khadas VIM1S

[PATCH v2 0/2] arm64: dts: meson-s4: add support for Khadas VIM1S

[Nick Xie]

This series adds initial support for the Khadas VIM1S single board computer.

The Khadas VIM1S is based on the Amlogic S905Y4 (S4 family) SoC.
It features:
 - 2GB LPDDR4 RAM
 - 16GB eMMC 5.1 storage
 - 32MB SPI flash
 - 100 Base-T Ethernet
 - AP6256 Wireless (802.11 a/b/g/n/ac, BT5.0)
 - HDMI 2.1 video
 - 2x USB 2.0 ports
 - 1x USB-C (power) with USB 2.0 OTG
 - 2x LED's (1x red, 1x white)
 - 3x buttons (power, function, reset)
 - IR receiver
 - 40pin GPIO Header
 - 1x micro SD card slot

The first patch adds the devicetree binding, and the second patch adds
the board device tree.

Changes in v2:
- dts: fixed dtbs_check warning: removed unsupported 'enable-active-low' property
  from regulator-sd-3v3 node
- Link to v1: https://lore.kernel.org/linux-amlogic/20260113090951.35928-1-nick@khadas.com/

Nick Xie (2):
  dt-bindings: arm: amlogic: add Khadas VIM1S binding
  arm64: dts: add initial device-tree for Khadas VIM1S

 .../devicetree/bindings/arm/amlogic.yaml      |   6 +
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../amlogic/meson-s4-s905y4-khadas-vim1s.dts  | 190 ++++++++++++++++++
 3 files changed, 197 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts

-- 
2.34.1

[PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[Nick Xie]

Add devicetree binding for Khadas VIM1S board based on
Amlogic S4 S905Y4 SoC.

Signed-off-by: Nick Xie <nick@khadas.com>
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 08d9963fe9259..55663e0f7f915 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -247,6 +247,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4
 
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:
+              - khadas,vim1s
+          - const: amlogic,s4
+
       - description: Boards with the Amlogic S6 S905X5 SoC
         items:
           - enum:
-- 
2.34.1

[PATCH v2 2/2] arm64: dts: add initial device-tree for Khadas VIM1S

[Nick Xie]

The Khadas VIM1S uses the Amlogic S905Y4 SoC, based on the
Amlogic S4 SoC family, on a board with the same form factor as the
VIM/VIM2/VIM3/VIM4 models. Serial debug console, ethernet, SD card
work with this initial device-tree.

It features:
 - 2GB LPDDR4 RAM
 - 16GB eMMC 5.1 storage
 - 32MB SPI flash
 - 100 Base-T Ethernet
 - AP6256 Wireless (802.11 a/b/g/n/ac, BT5.0)
 - HDMI 2.1 video
 - 2x USB 2.0 ports
 - 1x USB-C (power) with USB 2.0 OTG
 - 2x LED's (1x red, 1x white)
 - 3x buttons (power, function, reset)
 - IR receiver
 - 40pin GPIO Header
 - 1x micro SD card slot

Signed-off-by: Nick Xie <nick@khadas.com>
---
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../amlogic/meson-s4-s905y4-khadas-vim1s.dts  | 190 ++++++++++++++++++
 2 files changed, 191 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 219fb088c704d..15f9c817e5023 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-ugoos-am3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-wetek-core2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-s4-s805x2-aq222.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905y4-khadas-vim1s.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air-gbit.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-sm1-bananapi-m2-pro.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
new file mode 100644
index 0000000000000..a371ddcdb5e99
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
@@ -0,0 +1,190 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2026 Khadas Technology Co., Ltd.
+ */
+
+/dts-v1/;
+
+#include "meson-s4.dtsi"
+
+/ {
+	model = "Khadas VIM1S";
+	compatible = "khadas,vim1s", "amlogic,s4";
+	interrupt-parent = <&gic>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	aliases {
+		mmc0 = &emmc; /* eMMC */
+		mmc1 = &sd; /* SD card */
+		mmc2 = &sdio; /* SDIO */
+		serial0 = &uart_b;
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x0 0x0 0x80000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		/* 52 MiB reserved for ARM Trusted Firmware */
+		secmon_reserved: secmon@5000000 {
+			reg = <0x0 0x05000000 0x0 0x3400000>;
+			no-map;
+		};
+	};
+
+	sdio_32k: sdio-32k {
+		compatible = "pwm-clock";
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */
+	};
+
+	sdio_pwrseq: sdio-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
+		clocks = <&sdio_32k>;
+		clock-names = "ext_clock";
+	};
+
+	main_5v: regulator-main-5v {
+		compatible = "regulator-fixed";
+		regulator-name = "5V";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+
+	sd_3v3: regulator-sd-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "SD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio GPIOD_4 GPIO_ACTIVE_LOW>;
+		regulator-always-on;
+	};
+
+	vddio_sd: regulator-vddio-sd {
+		compatible = "regulator-gpio";
+		regulator-name = "VDDIO_SD";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio GPIOD_9 GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <1800000 1
+				3300000 0>;
+	};
+
+	/* SY8120B1ABC DC/DC Regulator. */
+	vddcpu: regulator-vddcpu {
+		compatible = "pwm-regulator";
+
+		regulator-name = "VDDCPU";
+		regulator-min-microvolt = <689000>;
+		regulator-max-microvolt = <1049000>;
+
+		vin-supply = <&main_5v>;
+
+		pwms = <&pwm_ij 1 1500 0>;
+		pwm-dutycycle-range = <100 0>;
+
+		regulator-boot-on;
+		regulator-always-on;
+		/* Voltage Duty-Cycle */
+		voltage-table = <1049000 0>,
+				<1039000 3>,
+				<1029000 6>,
+				<1019000 9>,
+				<1009000 12>,
+				<999000 14>,
+				<989000 17>,
+				<979000 20>,
+				<969000 23>,
+				<959000 26>,
+				<949000 29>,
+				<939000 31>,
+				<929000 34>,
+				<919000 37>,
+				<909000 40>,
+				<899000 43>,
+				<889000 45>,
+				<879000 48>,
+				<869000 51>,
+				<859000 54>,
+				<849000 56>,
+				<839000 59>,
+				<829000 62>,
+				<819000 65>,
+				<809000 68>,
+				<799000 70>,
+				<789000 73>,
+				<779000 76>,
+				<769000 79>,
+				<759000 81>,
+				<749000 84>,
+				<739000 87>,
+				<729000 89>,
+				<719000 92>,
+				<709000 95>,
+				<699000 98>,
+				<689000 100>;
+	};
+};
+
+&ethmac {
+	status = "okay";
+	phy-handle = <&internal_ephy>;
+	phy-mode = "rmii";
+};
+
+&ir {
+	status = "okay";
+	pinctrl-0 = <&remote_pins>;
+	pinctrl-names = "default";
+};
+
+&pwm_ef {
+	status = "okay";
+	pinctrl-0 = <&pwm_e_pins1>;
+	pinctrl-names = "default";
+};
+
+&pwm_ij {
+	status = "okay";
+};
+
+&sd {
+	status = "okay";
+	pinctrl-0 = <&sdcard_pins>;
+	pinctrl-1 = <&sdcard_clk_gate_pins>;
+	pinctrl-names = "default", "clk-gate";
+	bus-width = <4>;
+	cap-sd-highspeed;
+	sd-uhs-sdr12;
+	sd-uhs-sdr25;
+	sd-uhs-sdr50;
+	sd-uhs-sdr104;
+	max-frequency = <200000000>;
+	disable-wp;
+
+	cd-gpios = <&gpio GPIOC_6 GPIO_ACTIVE_LOW>;
+
+	vmmc-supply = <&sd_3v3>;
+	vqmmc-supply = <&vddio_sd>;
+};
+
+&spicc0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&spicc0_pins_x>;
+	cs-gpios = <&gpio GPIOX_10 GPIO_ACTIVE_LOW>;
+};
+
+&uart_b {
+	status = "okay";
+};
-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[Krzysztof Kozlowski]

On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> Add devicetree binding for Khadas VIM1S board based on
> Amlogic S4 S905Y4 SoC.
> 
> Signed-off-by: Nick Xie <nick@khadas.com>

You still have the same From/SoB mismatch.

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 08d9963fe9259..55663e0f7f915 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -247,6 +247,12 @@ properties:
>                - amlogic,aq222
>            - const: amlogic,s4
>  
> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> +        items:
> +          - enum:

Yopu already have exactly such enum with such description, so your
compatible goes there. Look - it is called "Boards" - plural.

> +              - khadas,vim1s
> +          - const: amlogic,s4

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[Nick Xie]

Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 16:51写道：
>
> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> > Add devicetree binding for Khadas VIM1S board based on
> > Amlogic S4 S905Y4 SoC.
> >
> > Signed-off-by: Nick Xie <nick@khadas.com>
>
> You still have the same From/SoB mismatch.

OK,  I will fix it in next version.

>
> > ---
> >  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > index 08d9963fe9259..55663e0f7f915 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > @@ -247,6 +247,12 @@ properties:
> >                - amlogic,aq222
> >            - const: amlogic,s4
> >
> > +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> > +        items:
> > +          - enum:
>
> Yopu already have exactly such enum with such description, so your
> compatible goes there. Look - it is called "Boards" - plural.

The exist board aq222 is based on SoC S905X2, but the new board vim1s
is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

>
> > +              - khadas,vim1s
> > +          - const: amlogic,s4
>
> Best regards,
> Krzysztof
>

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[neil.armstrong]

On 1/14/26 11:07, Nick Xie wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 16:51写道：
>>
>> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
>>> Add devicetree binding for Khadas VIM1S board based on
>>> Amlogic S4 S905Y4 SoC.
>>>
>>> Signed-off-by: Nick Xie <nick@khadas.com>
>>
>> You still have the same From/SoB mismatch.
> 
> OK,  I will fix it in next version.
> 
>>
>>> ---
>>>   Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> index 08d9963fe9259..55663e0f7f915 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> @@ -247,6 +247,12 @@ properties:
>>>                 - amlogic,aq222
>>>             - const: amlogic,s4
>>>
>>> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
>>> +        items:
>>> +          - enum:
>>
>> Yopu already have exactly such enum with such description, so your
>> compatible goes there. Look - it is called "Boards" - plural.
> 
> The exist board aq222 is based on SoC S905X2, but the new board vim1s
> is baed on S905Y4,
> they are different SoC, so we need to put S905Y4 under S805X2 ?

It depends, if the S805X2 and the S905Y4 are not compatible (different dies)
and not the same die in 2 different but compatible packages, then a secondary
compatible should be added like we did for amlogic,g12b or amlogic,meson-gxl.

Neil

> 
>>
>>> +              - khadas,vim1s
>>> +          - const: amlogic,s4
>>
>> Best regards,
>> Krzysztof
>>

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[Krzysztof Kozlowski]

On 14/01/2026 11:07, Nick Xie wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 16:51写道：
>>
>> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
>>> Add devicetree binding for Khadas VIM1S board based on
>>> Amlogic S4 S905Y4 SoC.
>>>
>>> Signed-off-by: Nick Xie <nick@khadas.com>
>>
>> You still have the same From/SoB mismatch.
> 
> OK,  I will fix it in next version.
> 
>>
>>> ---
>>>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> index 08d9963fe9259..55663e0f7f915 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> @@ -247,6 +247,12 @@ properties:
>>>                - amlogic,aq222
>>>            - const: amlogic,s4

Look here

>>>
>>> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
>>> +        items:
>>> +          - enum:
>>
>> Yopu already have exactly such enum with such description, so your
>> compatible goes there. Look - it is called "Boards" - plural.
> 
> The exist board aq222 is based on SoC S905X2, but the new board vim1s
> is baed on S905Y4,
> they are different SoC, so we need to put S905Y4 under S805X2 ?

What is the point of having two separate lists with enums ending the
same SoC compatible?

> 
>>
>>> +              - khadas,vim1s
>>> +          - const: amlogic,s4

And here.

>>
>> Best regards,
>> Krzysztof
>>


Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[Nick Xie]

Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 18:33写道：
>
> On 14/01/2026 11:07, Nick Xie wrote:
> > Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 16:51写道：
> >>
> >> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
> >>> Add devicetree binding for Khadas VIM1S board based on
> >>> Amlogic S4 S905Y4 SoC.
> >>>
> >>> Signed-off-by: Nick Xie <nick@khadas.com>
> >>
> >> You still have the same From/SoB mismatch.
> >
> > OK,  I will fix it in next version.
> >
> >>
> >>> ---
> >>>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> >>>  1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> >>> index 08d9963fe9259..55663e0f7f915 100644
> >>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> >>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> >>> @@ -247,6 +247,12 @@ properties:
> >>>                - amlogic,aq222
> >>>            - const: amlogic,s4
>
> Look here
>
> >>>
> >>> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
> >>> +        items:
> >>> +          - enum:
> >>
> >> Yopu already have exactly such enum with such description, so your
> >> compatible goes there. Look - it is called "Boards" - plural.
> >
> > The exist board aq222 is based on SoC S905X2, but the new board vim1s
> > is baed on S905Y4,
> > they are different SoC, so we need to put S905Y4 under S805X2 ?
>
> What is the point of having two separate lists with enums ending the
> same SoC compatible?

Actually S805X2 and S905Y4 are different SoC. So maybe like this ?

S805X2:
- description: Boards with the Amlogic Meson S4 S805X2 SoC
  items:
    - enum:
        - amlogic,aq222
    - const: amlogic,s805x2
    - const: amlogic,s4

S905Y4:
- description: Boards with the Amlogic Meson S4 S905Y4 SoC
  items:
    - enum:
        - khadas,vim1s
    - const: amlogic,s905y4
    - const: amlogic,s4

Same as Amlogic A311D & S922X

S922X:
- const: amlogic,s922x
- const: amlogic,g12b

A311D:
- const: amlogic,a311d
- const: amlogic,g12b

>
> >
> >>
> >>> +              - khadas,vim1s
> >>> +          - const: amlogic,s4
>
> And here.
>
> >>
> >> Best regards,
> >> Krzysztof
> >>
>
>
> Best regards,
> Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[neil.armstrong]

On 1/14/26 11:33, Krzysztof Kozlowski wrote:
> On 14/01/2026 11:07, Nick Xie wrote:
>> Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 16:51写道：
>>>
>>> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
>>>> Add devicetree binding for Khadas VIM1S board based on
>>>> Amlogic S4 S905Y4 SoC.
>>>>
>>>> Signed-off-by: Nick Xie <nick@khadas.com>
>>>
>>> You still have the same From/SoB mismatch.
>>
>> OK,  I will fix it in next version.
>>
>>>
>>>> ---
>>>>   Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>>>   1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>>> index 08d9963fe9259..55663e0f7f915 100644
>>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>>> @@ -247,6 +247,12 @@ properties:
>>>>                 - amlogic,aq222
>>>>             - const: amlogic,s4
> 
> Look here
> 
>>>>
>>>> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
>>>> +        items:
>>>> +          - enum:
>>>
>>> Yopu already have exactly such enum with such description, so your
>>> compatible goes there. Look - it is called "Boards" - plural.
>>
>> The exist board aq222 is based on SoC S905X2, but the new board vim1s
>> is baed on S905Y4,
>> they are different SoC, so we need to put S905Y4 under S805X2 ?
> 
> What is the point of having two separate lists with enums ending the
> same SoC compatible?

It's very usual for SoC vendors to reuse the same SoC design (here Amlogic S4)
into multiple different packages, with some different features enabled & so on,
and even new version of the die with some bugfixes.

We did this in the past for goop reasons, and here it also applies.
In fact the currently supported SoC (S805X2) is a stripped down
version of the S4 SoC like it was done for the S805X which was aalso a stripped
down version of the S905X, with a different IO layout and different internal
characteristics even if the die logic was the same.

Neil

> 
>>
>>>
>>>> +              - khadas,vim1s
>>>> +          - const: amlogic,s4
> 
> And here.
> 
>>>
>>> Best regards,
>>> Krzysztof
>>>
> 
> 
> Best regards,
> Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

[neil.armstrong]

On 1/14/26 12:25, Nick Xie wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 18:33写道：
>>
>> On 14/01/2026 11:07, Nick Xie wrote:
>>> Krzysztof Kozlowski <krzk@kernel.org> 于2026年1月14日周三 16:51写道：
>>>>
>>>> On Wed, Jan 14, 2026 at 02:25:48PM +0800, Nick Xie wrote:
>>>>> Add devicetree binding for Khadas VIM1S board based on
>>>>> Amlogic S4 S905Y4 SoC.
>>>>>
>>>>> Signed-off-by: Nick Xie <nick@khadas.com>
>>>>
>>>> You still have the same From/SoB mismatch.
>>>
>>> OK,  I will fix it in next version.
>>>
>>>>
>>>>> ---
>>>>>   Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>>>>   1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>>>> index 08d9963fe9259..55663e0f7f915 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>>>> @@ -247,6 +247,12 @@ properties:
>>>>>                 - amlogic,aq222
>>>>>             - const: amlogic,s4
>>
>> Look here
>>
>>>>>
>>>>> +      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
>>>>> +        items:
>>>>> +          - enum:
>>>>
>>>> Yopu already have exactly such enum with such description, so your
>>>> compatible goes there. Look - it is called "Boards" - plural.
>>>
>>> The exist board aq222 is based on SoC S905X2, but the new board vim1s
>>> is baed on S905Y4,
>>> they are different SoC, so we need to put S905Y4 under S805X2 ?
>>
>> What is the point of having two separate lists with enums ending the
>> same SoC compatible?
> 
> Actually S805X2 and S905Y4 are different SoC. So maybe like this ?
> 
> S805X2:
> - description: Boards with the Amlogic Meson S4 S805X2 SoC
>    items:
>      - enum:
>          - amlogic,aq222
>      - const: amlogic,s805x2
>      - const: amlogic,s4
> 
> S905Y4:
> - description: Boards with the Amlogic Meson S4 S905Y4 SoC
>    items:
>      - enum:
>          - khadas,vim1s
>      - const: amlogic,s905y4
>      - const: amlogic,s4

It's ok for me, but you'll need to update the aq222 DT aswell.

> 
> Same as Amlogic A311D & S922X
> 
> S922X:
> - const: amlogic,s922x
> - const: amlogic,g12b
> 
> A311D:
> - const: amlogic,a311d
> - const: amlogic,g12b
> 
>>
>>>
>>>>
>>>>> +              - khadas,vim1s
>>>>> +          - const: amlogic,s4
>>
>> And here.
>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>
>>
>> Best regards,
>> Krzysztof