From: "Rob Herring (Arm)" <robh@kernel.org>
To: Saravana Kannan <saravanak@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>
Cc: David Heidelberg <david@ixit.cz>,
devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] kbuild: Fix unnecessary rebuilding DT base+overlay targets
Date: Wed, 14 Jan 2026 12:46:39 -0600 [thread overview]
Message-ID: <20260114184640.3043083-1-robh@kernel.org> (raw)
Commit 5d0cac427d42 ("kbuild: Support directory targets for building
DTBs") causes base+overlay targets to be rebuilt every time. The problem
is due to the added check on $(MAKECMDGOALS) which now testing again
doesn't even seem to be needed. Revert that portion of the commit.
Fixes: 5d0cac427d42 ("kbuild: Support directory targets for building DTBs")
Reported-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
scripts/Makefile.dtbs | 3 ---
1 file changed, 3 deletions(-)
diff --git a/scripts/Makefile.dtbs b/scripts/Makefile.dtbs
index f5d51b8c2eeb..b2d85b9a4a7a 100644
--- a/scripts/Makefile.dtbs
+++ b/scripts/Makefile.dtbs
@@ -23,10 +23,7 @@ dtb-y := $(addprefix $(obj)/, $(dtb-y))
multi-dtb-y := $(addprefix $(obj)/, $(multi-dtb-y))
real-dtb-y := $(addprefix $(obj)/, $(real-dtb-y))
-dtb-targets := %.dtb %.dtbo dtbs dtbs_check
-ifneq ($(findstring /dts/,$(MAKECMDGOALS))$(filter $(dtb-targets),$(MAKECMDGOALS)),)
always-y += $(dtb-y)
-endif
targets += $(real-dtb-y)
--
2.51.0
next reply other threads:[~2026-01-14 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 18:46 Rob Herring (Arm) [this message]
2026-01-14 19:16 ` [PATCH] kbuild: Fix unnecessary rebuilding DT base+overlay targets David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114184640.3043083-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox