From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F71F3AEF46 for ; Wed, 14 Jan 2026 22:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768430343; cv=none; b=m7PQWPHJ4mfjASvVpIoLI/o9bkPEdkzJU/sdrT4p7syK3FtPDIb0M2QhJ8XqFkMBKQ+v/QxMTV/efN2bqK3F7VLCWsTjFF24mN4A3kasBk68tSvk6mUHOiaoVrZL/7KufLw3k0GoiEgWDHoOFtK1MlY0dwrjMZYj2WnWwQIT/mU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768430343; c=relaxed/simple; bh=LiPMNGSYuDYKND7hjpCb2VOdDYbgBQygqfIWwd0xZ2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fy6leopbZjkPjoKKtQce8NULmHO8qdYZGZE2xoGG0GEbEbzSLzXQyJ+gBznPvX7AKbq27iB4cDsVR+OPclu71Cxb7X2e2pudaXozUhjdUHybxmA+YrE+CUrx6u3tuJGwEkNYX1vrU62pIA+6PyzaSCkUuDGuxg4HOyUH24PTUAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O33VKL+q; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O33VKL+q" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47ee9463ca3so456405e9.1 for ; Wed, 14 Jan 2026 14:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768430332; x=1769035132; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UpLrsuBP5cyvqPyFlCwBE8b4I6p1F6uTyQHUxukXoTo=; b=O33VKL+qJikSrFjNwPNF+t/liIjkVgBsuZh4JGnVYrcyC5/a71GxNagxBF8Aumdn8t O/BccIvh68/QUEPr3HA/ENakTnyy0iEKh6b0Vx1gGI42q6ppfXY2Bwck0A+bc+qVcCHf pXuQct4M2HOqXre2zZSPN92Jh5aEVTKvepFHzhC81Qe5i6iub3PJwKMdgRbSfZnkkWw0 l7+Xxm17++uHDwvUF1M6TDC3Q6tmnLXK8YV1IwMjBv19PpOPIavLHy8wLsHShmzXx3u2 hbd3O6Z4VkTdHrPBwRCJpQBlGhtmDwLBfJWTKoxfpsgoG7Waqc+05qjMVDCIIjGP8sui /nug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768430332; x=1769035132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UpLrsuBP5cyvqPyFlCwBE8b4I6p1F6uTyQHUxukXoTo=; b=vHJgvmwPtB+VRv5nWOcD/mx9h8VLsqwBoLy2/JMVTWKEk5JOm959XB6tCDK+C0+j0j fajfOqhOlOhaKXBfaOiV0M1X16mlKA9kd+YA7ewq1LXjSKSWi0YvNv+9niiCUuooh3mf iMyntkZyj4iCK2KKbzsVyEARTcWgl9NT/xEgSWZNgFF7KkdKix4JUnIIAhE/1el7uXx9 4kVD43Q6LqaFItc1E+ge1/E6T63t2OP6eh4616uNnp1QZ/spBg0SCVnNr54tAwd65pW4 IJGy+qhx8JpKYPPs80FWLX6NjR5/zgjn2ElY2xWy7PB7m2GqyGwB9AWC59/Jg4MMATJf M5sA== X-Forwarded-Encrypted: i=1; AJvYcCUg8efUuuZ2R85RD+5xF/F1iUMXvXuPAp+chqSs0x/lnPp3hanLu/7H0tKCv5AJs58n53w0P/9bO0nz@vger.kernel.org X-Gm-Message-State: AOJu0YxIzwUBuKL1gGa3TbsdUViFRugFU1svNCNUkOHiobjcxv9dG4FT kBsBxNB2FZQjxFOaSssfLWQuWLE1YCD3jh1fDmqcwFJ4aZhZWbztrnSI X-Gm-Gg: AY/fxX7Q3hNwI8oF1xddCOBVQi3NxIxvpW6nOzCv+c4oS3rBeeh1U76mndfW+gqeZ++ ZiX+7j1x5rpjHgceBfW0WKFW0Opdu3mAT0qiaUugS7AF/kZL5cwJ9B7Tz3xRa05VLlVIjdAW1Bs llqUgA4a88DAzry8wsP8wHnSZa2EpFpGO0tywqbzjtkzA6ujJvkxkscsC0/jR7xg5VHh/pls2kQ YazKKyWzFlyF37BOnL/pKccm02tJuAhG8yjnck/uoruw9C8qsrY4LBNrFCtXLrHnnnXrucHGTLD Ik49tZ9MftavPG2Fj7/3Qb9NUYJPS3+In5DLQk+CuWT2MANwQ9UZPrw0PYQw9Dzei2J8+VPNJg0 uMvZZJh9Je+Aw65rEUCBakgqyO/sK8disjdc4B+Nm65poYLV/ZGT9scf+58JpR7qhg6Iu3RYbiL l5KA== X-Received: by 2002:a05:600c:3510:b0:47a:94fc:d063 with SMTP id 5b1f17b1804b1-47ee32e0ce4mr29774335e9.1.1768430331927; Wed, 14 Jan 2026 14:38:51 -0800 (PST) Received: from skbuf ([2a02:2f04:d703:5400:d5b0:b41:b5b3:8c4d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f42907141sm12480585e9.9.2026.01.14.14.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 14:38:51 -0800 (PST) Date: Thu, 15 Jan 2026 00:38:48 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Hauke Mehrtens , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Minqiang , Xinfa Deng Subject: Re: [PATCH net-next 3/3] net: dsa: mxl-gsw1xx: add support for Intel GSW150 Message-ID: <20260114223848.4s6r4ncuzstq6e4e@skbuf> References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 13, 2026 at 03:25:34AM +0000, Daniel Golle wrote: > Add support for the Intel GSW150 (aka. Lantiq PEB7084) switch IC to > the mxl-gsw1xx driver. This switch comes with 5 Gigabit Ethernet > copper ports (Intel XWAY PHY11G (xRX v1.2 integrated) PHYs) as well as > one GMII/RGMII and one RGMII port. > > Signed-off-by: Daniel Golle > --- > drivers/net/dsa/lantiq/mxl-gsw1xx.c | 63 ++++++++++++++++++++++++++--- > drivers/net/dsa/lantiq/mxl-gsw1xx.h | 2 + > 2 files changed, 60 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/dsa/lantiq/mxl-gsw1xx.c b/drivers/net/dsa/lantiq/mxl-gsw1xx.c > index 4390c2df2e4bd..1c6a5456a5caf 100644 > --- a/drivers/net/dsa/lantiq/mxl-gsw1xx.c > +++ b/drivers/net/dsa/lantiq/mxl-gsw1xx.c > +static void gsw150_phylink_get_caps(struct dsa_switch *ds, int port, > + struct phylink_config *config) > +{ > + config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | > + MAC_10 | MAC_100 | MAC_1000; > + > + switch (port) { > + case 0: /* port 0~4: built-in 1GE PHYs */ > + case 1: > + case 2: > + case 3: > + case 4: I think there's a syntax for this, see mt7530_mac_port_get_caps(): case 0 ... 4: also, you can drop "port X: " from the comments. > + __set_bit(PHY_INTERFACE_MODE_INTERNAL, > + config->supported_interfaces); > + break; > + case 5: /* port 5: GMII or RGMII */ > + __set_bit(PHY_INTERFACE_MODE_GMII, > + config->supported_interfaces); > + fallthrough; > + case 6: /* port 6: RGMII */ > + phy_interface_set_rgmii(config->supported_interfaces); > + break; > + } > + > + gsw1xx_phylink_get_lpi_caps(config); > }