Re: [PATCH v4 5/5] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality

[kernel test robot <lkp@intel.com>]

Hi Aman,

kernel test robot noticed the following build errors:

[auto build test ERROR on i3c/i3c/next]
[also build test ERROR on lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes broonie-regulator/for-next linus/master v6.19-rc5 next-20260114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aman-Kumar-Pandey/dt-bindings-i3c-Add-NXP-P3H2x4x-i3c-hub-support/20260113-195318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git i3c/next
patch link:    https://lore.kernel.org/r/20260113114529.1692213-5-aman.kumarpandey%40nxp.com
patch subject: [PATCH v4 5/5] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20260115/202601150750.NiEqaaGg-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260115/202601150750.NiEqaaGg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601150750.NiEqaaGg-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/i3c/hub/p3h2840_i3c_hub_common.c:12:
   drivers/i3c/hub/p3h2840_i3c_hub_common.c: In function 'p3h2x4x_configure_pullup':
>> drivers/i3c/hub/p3h2840_i3c_hub.h:64:17: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
      64 |                 FIELD_PREP(P3H2x4x_TP0145_PULLUP_CONF_MASK, x)
         |                 ^~~~~~~~~~
   drivers/i3c/hub/p3h2840_i3c_hub_common.c:51:18: note: in expansion of macro 'P3H2x4x_TP0145_PULLUP_CONF'
      51 |         pullup = P3H2x4x_TP0145_PULLUP_CONF(p3h2x4x_pullup_dt_to_reg
         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/FIELD_PREP +64 drivers/i3c/hub/p3h2840_i3c_hub.h

    61	
    62	#define P3H2x4x_TP0145_PULLUP_CONF_MASK				GENMASK(7, 6)
    63	#define P3H2x4x_TP0145_PULLUP_CONF(x)	\
  > 64			FIELD_PREP(P3H2x4x_TP0145_PULLUP_CONF_MASK, x)
    65	#define P3H2x4x_TP2367_PULLUP_CONF_MASK				GENMASK(5, 4)
    66	#define P3H2x4x_TP2367_PULLUP_CONF(x)	\
    67			FIELD_PREP(P3H2x4x_TP2367_PULLUP_CONF_MASK, x)
    68	#define P3H2x4x_PULLUP_CONF_MASK					GENMASK(7, 4)
    69	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki