From: Krzysztof Kozlowski <krzk@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: devicetree@vger.kernel.org, andersson@kernel.org,
mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, matthias.bgg@gmail.com,
tinghan.shen@mediatek.com, olivia.wen@mediatek.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual
Date: Fri, 16 Jan 2026 09:40:43 +0100 [thread overview]
Message-ID: <20260116-soft-rapid-mongrel-8de32e@quoll> (raw)
In-Reply-To: <20260115111645.63295-1-angelogioacchino.delregno@collabora.com>
On Thu, Jan 15, 2026 at 12:16:45PM +0100, AngeloGioacchino Del Regno wrote:
> reg-names:
> - minItems: 2
> + minItems: 1
> maxItems: 3
>
> clocks:
> @@ -185,7 +185,7 @@ allOf:
> then:
> properties:
> reg:
> - maxItems: 3
> + minItems: 3
> reg-names:
> items:
> - const: sram
I think you also need to update the if:then: section with
mediatek,mt8183-scp+mediatek,mt8186-scp+mediatek,mt8188-scp
> @@ -196,11 +196,22 @@ allOf:
> compatible:
> enum:
> - mediatek,mt8188-scp-dual
> + then:
> + properties:
> + reg:
> + maxItems: 1
> + reg-names:
> + items:
> + - const: cfg
> + - if:
> + properties:
> + compatible:
> + enum:
> - mediatek,mt8195-scp-dual
> then:
> properties:
> reg:
> - maxItems: 2
> + minItems: 2
You still need maxItems here, otherwise you change the meaning to 2-3.
> reg-names:
> items:
> - const: cfg
> --
> 2.52.0
>
prev parent reply other threads:[~2026-01-16 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 11:16 [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual AngeloGioacchino Del Regno
2026-01-16 8:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116-soft-rapid-mongrel-8de32e@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=olivia.wen@mediatek.com \
--cc=robh@kernel.org \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox