* [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual
@ 2026-01-15 11:16 AngeloGioacchino Del Regno
2026-01-16 8:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-15 11:16 UTC (permalink / raw)
To: devicetree
Cc: andersson, mathieu.poirier, robh, krzk+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, tinghan.shen, olivia.wen,
linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
kernel
Even though the MT8188 SoC's Dual-Core SCP IP is practically the
same as the one found on MT8195, it doesn't have a dedicated L1
TCM and relies only on SRAM.
Set reg/reg-names minItems to 1 globally and override it in all of
the conditionals for the SoCs that require more, and then split
the mt8195/8188 conditionals to allow specifying only the cfg MMIO
on MT8188.
Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Changes in v2:
- Fix dtc warnings and validate again
CHKDT ./Documentation/devicetree/bindings
LINT ./Documentation/devicetree/bindings
DTEX Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dts
DTC [C] Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb
Done.
.../bindings/remoteproc/mtk,scp.yaml | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index 179c98b33b4d..f0cae3e4bc78 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -28,11 +28,11 @@ properties:
description:
Should contain the address ranges for memory regions SRAM, CFG, and,
on some platforms, L1TCM.
- minItems: 2
+ minItems: 1
maxItems: 3
reg-names:
- minItems: 2
+ minItems: 1
maxItems: 3
clocks:
@@ -185,7 +185,7 @@ allOf:
then:
properties:
reg:
- maxItems: 3
+ minItems: 3
reg-names:
items:
- const: sram
@@ -196,11 +196,22 @@ allOf:
compatible:
enum:
- mediatek,mt8188-scp-dual
+ then:
+ properties:
+ reg:
+ maxItems: 1
+ reg-names:
+ items:
+ - const: cfg
+ - if:
+ properties:
+ compatible:
+ enum:
- mediatek,mt8195-scp-dual
then:
properties:
reg:
- maxItems: 2
+ minItems: 2
reg-names:
items:
- const: cfg
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual
2026-01-15 11:16 [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual AngeloGioacchino Del Regno
@ 2026-01-16 8:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-16 8:40 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: devicetree, andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
matthias.bgg, tinghan.shen, olivia.wen, linux-remoteproc,
linux-kernel, linux-arm-kernel, linux-mediatek, kernel
On Thu, Jan 15, 2026 at 12:16:45PM +0100, AngeloGioacchino Del Regno wrote:
> reg-names:
> - minItems: 2
> + minItems: 1
> maxItems: 3
>
> clocks:
> @@ -185,7 +185,7 @@ allOf:
> then:
> properties:
> reg:
> - maxItems: 3
> + minItems: 3
> reg-names:
> items:
> - const: sram
I think you also need to update the if:then: section with
mediatek,mt8183-scp+mediatek,mt8186-scp+mediatek,mt8188-scp
> @@ -196,11 +196,22 @@ allOf:
> compatible:
> enum:
> - mediatek,mt8188-scp-dual
> + then:
> + properties:
> + reg:
> + maxItems: 1
> + reg-names:
> + items:
> + - const: cfg
> + - if:
> + properties:
> + compatible:
> + enum:
> - mediatek,mt8195-scp-dual
> then:
> properties:
> reg:
> - maxItems: 2
> + minItems: 2
You still need maxItems here, otherwise you change the meaning to 2-3.
> reg-names:
> items:
> - const: cfg
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-16 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 11:16 [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual AngeloGioacchino Del Regno
2026-01-16 8:40 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox