* [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC
@ 2026-01-09 9:43 Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY Tzu-Hao Wei
` (5 more replies)
0 siblings, 6 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09 9:43 UTC (permalink / raw)
To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc,
Tzu-Hao Wei
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
HS200 eMMC controller.
This series includes:
1. Add bindings for Axiado AX3000 eMMC PHY
2. Add Axiado AX3000 eMMC phy driver
3. Update MAINTAINERS for the new driver
4. Update Axiado AX3000 device tree
Changes: (The previous version was mixed with Host driver, so I separate
the PHY driver as a new thread)
- Fix property order in required section to match properties section
- Fixed example to use lowercase hex and proper node naming
- Removed wrapper functions, use readl/writel directly
- Replaced manual polling loops with read_poll_timeout macro
- Used devm_platform_ioremap_resource instead of separate calls
- Removed unnecessary of_match_node check
- Used dev_err_probe for error reporting
- Added proper Kconfig dependencies (ARCH_AXIADO || COMPILE_TEST)
- Fixed various coding style issues
- Link to previous patches: https://lore.kernel.org/all/20251222-axiado-ax3000-add-emmc-host-driver-support-v1-0-5457d0ebcdb4@axiado.com/
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
SriNavmani A (3):
dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
phy: axiado: add Axiado eMMC PHY driver
arm64: dts: axiado: Add eMMC PHY node
Tzu-Hao Wei (1):
MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
.../bindings/phy/axiado,ax3000-emmc-phy.yaml | 38 ++++
MAINTAINERS | 10 +
arch/arm64/boot/dts/axiado/ax3000.dtsi | 7 +
drivers/phy/Kconfig | 1 +
drivers/phy/Makefile | 1 +
drivers/phy/axiado/Kconfig | 11 ++
drivers/phy/axiado/Makefile | 1 +
drivers/phy/axiado/phy-axiado-emmc.c | 220 +++++++++++++++++++++
8 files changed, 289 insertions(+)
---
base-commit: f0b9d8eb98dfee8d00419aa07543bdc2c1a44fb1
change-id: 20260108-axiado-ax3000-add-emmc-phy-driver-support-d61aead8f622
Best regards,
--
Tzu-Hao Wei <twei@axiado.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
@ 2026-01-09 9:43 ` Tzu-Hao Wei
2026-01-11 10:37 ` Krzysztof Kozlowski
2026-01-09 9:43 ` [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver Tzu-Hao Wei
` (4 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09 9:43 UTC (permalink / raw)
To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc,
Tzu-Hao Wei
From: SriNavmani A <srinavmani@axiado.com>
Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
HS200 eMMC host controller.
Signed-off-by: SriNavmani A <srinavmani@axiado.com>
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
.../bindings/phy/axiado,ax3000-emmc-phy.yaml | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..78194b77ec1bd22a87d7aead430db57bca7942b0
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/axiado,ax3000-emmc-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Axiado AX3000 Arasan eMMC PHY
+
+maintainers:
+ - SriNavmani A <srinavmani@axiado.com>
+ - Tzu-Hao Wei <twei@axiado.com>
+ - Prasad Bolisetty <pbolisetty@axiado.com>
+
+properties:
+ compatible:
+ const:
+ - axiado,ax3000-emmc-phy
+
+ reg:
+ maxItems: 1
+
+ "#phy-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ phy@80801c00 {
+ compatible = "axiado,ax3000-emmc-phy";
+ reg = <0x80801c00 0x1000>;
+ #phy-cells = <0>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY Tzu-Hao Wei
@ 2026-01-09 9:43 ` Tzu-Hao Wei
2026-01-15 22:22 ` kernel test robot
2026-01-09 9:43 ` [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 " Tzu-Hao Wei
` (3 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09 9:43 UTC (permalink / raw)
To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc,
Tzu-Hao Wei
From: SriNavmani A <srinavmani@axiado.com>
It provides the required configurations for Axiado eMMC PHY driver for
HS200 mode.
Signed-off-by: SriNavmani A <srinavmani@axiado.com>
Co-developed-by: Prasad Bolisetty <pbolisetty@axiado.com>
Signed-off-by: Prasad Bolisetty <pbolisetty@axiado.com>
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
drivers/phy/Kconfig | 1 +
drivers/phy/Makefile | 1 +
drivers/phy/axiado/Kconfig | 11 ++
drivers/phy/axiado/Makefile | 1 +
drivers/phy/axiado/phy-axiado-emmc.c | 220 +++++++++++++++++++++++++++++++++++
5 files changed, 234 insertions(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 678dd0452f0aa0597773433f04d2a9ba77474d2a..b802274ea45a84bd36d7c0b7fb90e368a5c018b4 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -103,6 +103,7 @@ config PHY_NXP_PTN3222
source "drivers/phy/allwinner/Kconfig"
source "drivers/phy/amlogic/Kconfig"
+source "drivers/phy/axiado/Kconfig"
source "drivers/phy/broadcom/Kconfig"
source "drivers/phy/cadence/Kconfig"
source "drivers/phy/freescale/Kconfig"
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index bfb27fb5a494283d7fd05dd670ebd1b12df8b1a1..f1b9e4a8673bcde3fdc0fdc06a3deddb5785ced1 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -15,6 +15,7 @@ obj-$(CONFIG_PHY_AIROHA_PCIE) += phy-airoha-pcie.o
obj-$(CONFIG_PHY_NXP_PTN3222) += phy-nxp-ptn3222.o
obj-y += allwinner/ \
amlogic/ \
+ axiado/ \
broadcom/ \
cadence/ \
freescale/ \
diff --git a/drivers/phy/axiado/Kconfig b/drivers/phy/axiado/Kconfig
new file mode 100644
index 0000000000000000000000000000000000000000..d159e0345345987c7f48dcd12d3237997735d2b5
--- /dev/null
+++ b/drivers/phy/axiado/Kconfig
@@ -0,0 +1,11 @@
+#
+# PHY drivers for Axiado platforms
+#
+
+config PHY_AX3000_EMMC
+ tristate "Axiado eMMC PHY driver"
+ depends on OF && (ARCH_AXIADO || COMPILE_TEST)
+ select GENERIC_PHY
+ help
+ Enables this to support for the AX3000 EMMC PHY driver.
+ If unsure, say N.
diff --git a/drivers/phy/axiado/Makefile b/drivers/phy/axiado/Makefile
new file mode 100644
index 0000000000000000000000000000000000000000..1e2b1ba016092eaffdbd7acbd9cdc8577d79b35c
--- /dev/null
+++ b/drivers/phy/axiado/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_PHY_AX3000_EMMC) += phy-axiado-emmc.o
diff --git a/drivers/phy/axiado/phy-axiado-emmc.c b/drivers/phy/axiado/phy-axiado-emmc.c
new file mode 100644
index 0000000000000000000000000000000000000000..7b18689fc6690750d7b016ebdcc457ebb81aa3e0
--- /dev/null
+++ b/drivers/phy/axiado/phy-axiado-emmc.c
@@ -0,0 +1,220 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Axiado eMMC PHY driver
+ *
+ * Copyright (C) 2017 Arasan Chip Systems Inc.
+ * Copyright (C) 2022-2025 Axiado Corporation (or its affiliates).
+ *
+ * Based on Arasan Driver (sdhci-pci-arasan.c)
+ * sdhci-pci-arasan.c - Driver for Arasan PCI Controller with integrated phy.
+ */
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/iopoll.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/phy/phy.h>
+#include <linux/platform_device.h>
+
+/* Arasan eMMC 5.1 - PHY configuration registers */
+#define CAP_REG_IN_S1_LSB 0x00
+#define CAP_REG_IN_S1_MSB 0x04
+#define PHY_CTRL_1 0x38
+#define PHY_CTRL_2 0x3C
+#define PHY_CTRL_3 0x40
+#define STATUS 0x50
+
+#define DLL_ENBL BIT(26)
+#define RTRIM_EN BIT(21)
+#define PDB_ENBL BIT(23)
+#define RETB_ENBL BIT(1)
+
+#define REN_STRB BIT(27)
+#define REN_CMD BIT(12)
+#define REN_DAT0 BIT(13)
+#define REN_DAT1 BIT(14)
+#define REN_DAT2 BIT(15)
+#define REN_DAT3 BIT(16)
+#define REN_DAT4 BIT(17)
+#define REN_DAT5 BIT(18)
+#define REN_DAT6 BIT(19)
+#define REN_DAT7 BIT(20)
+#define REN_CMD_EN (REN_CMD | REN_DAT0 | REN_DAT1 | REN_DAT2 | \
+ REN_DAT3 | REN_DAT4 | REN_DAT5 | REN_DAT6 | REN_DAT7)
+
+/* Pull-UP Enable on CMD Line */
+#define PU_CMD BIT(3)
+#define PU_DAT0 BIT(4)
+#define PU_DAT1 BIT(5)
+#define PU_DAT2 BIT(6)
+#define PU_DAT3 BIT(7)
+#define PU_DAT4 BIT(8)
+#define PU_DAT5 BIT(9)
+#define PU_DAT6 BIT(10)
+#define PU_DAT7 BIT(11)
+#define PU_CMD_EN (PU_CMD | PU_DAT0 | PU_DAT1 | PU_DAT2 | PU_DAT3 | \
+ PU_DAT4 | PU_DAT5 | PU_DAT6 | PU_DAT7)
+
+/* Selection value for the optimum delay from 1-32 output tap lines */
+#define OTAP_DLY 0x02
+/* DLL charge pump current trim default [1000] */
+#define DLL_TRM_ICP 0x08
+/* Select the frequency range of DLL Operation */
+#define FRQ_SEL 0x01
+
+#define OTAP_SEL_MASK GENMASK(10, 7)
+#define DLL_TRM_MASK GENMASK(25, 22)
+#define DLL_FRQSEL_MASK GENMASK(27, 25)
+
+#define OTAP_SEL(x) (FIELD_PREP(OTAP_SEL_MASK, x) | OTAPDLY_EN)
+#define DLL_TRM(x) (FIELD_PREP(DLL_TRM_MASK, x) | DLL_ENBL)
+#define DLL_FRQSEL(x) FIELD_PREP(DLL_FRQSEL_MASK, x)
+
+#define OTAPDLY_EN BIT(11)
+
+#define SEL_DLY_RXCLK BIT(18)
+#define SEL_DLY_TXCLK BIT(19)
+
+#define CALDONE_MASK 0x40
+#define DLL_RDY_MASK 0x1
+#define MAX_CLK_BUF0 BIT(20)
+#define MAX_CLK_BUF1 BIT(21)
+#define MAX_CLK_BUF2 BIT(22)
+
+#define CLK_MULTIPLIER 0xC008E
+#define POLL_TIMEOUT_MS 3000
+#define POLL_DELAY_US 100
+
+struct axiado_emmc_phy {
+ void __iomem *reg_base;
+ struct device *dev;
+};
+
+static int axiado_emmc_phy_init(struct phy *phy)
+{
+ struct axiado_emmc_phy *ax_phy = phy_get_drvdata(phy);
+ struct device *dev = ax_phy->dev;
+ u32 val;
+ int ret;
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_1);
+ writel(val | RETB_ENBL | RTRIM_EN, ax_phy->reg_base + PHY_CTRL_1);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_3);
+ writel(val | PDB_ENBL, ax_phy->reg_base + PHY_CTRL_3);
+
+ ret = read_poll_timeout(readl, val, val & CALDONE_MASK, POLL_DELAY_US,
+ POLL_TIMEOUT_MS * 1000, false,
+ ax_phy->reg_base + STATUS);
+ if (ret) {
+ dev_err(dev, "PHY calibration timeout\n");
+ return ret;
+ }
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_1);
+ writel(val | REN_CMD_EN | PU_CMD_EN, ax_phy->reg_base + PHY_CTRL_1);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_2);
+ writel(val | REN_STRB, ax_phy->reg_base + PHY_CTRL_2);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_3);
+ writel(val | MAX_CLK_BUF0 | MAX_CLK_BUF1 | MAX_CLK_BUF2,
+ ax_phy->reg_base + PHY_CTRL_3);
+
+ writel(CLK_MULTIPLIER, ax_phy->reg_base + CAP_REG_IN_S1_MSB);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_3);
+ writel(val | SEL_DLY_RXCLK | SEL_DLY_TXCLK,
+ ax_phy->reg_base + PHY_CTRL_3);
+
+ return 0;
+}
+
+static int axiado_emmc_phy_power_on(struct phy *phy)
+{
+ struct axiado_emmc_phy *ax_phy = phy_get_drvdata(phy);
+ struct device *dev = ax_phy->dev;
+ u32 val;
+ int ret;
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_1);
+ writel(val | RETB_ENBL, ax_phy->reg_base + PHY_CTRL_1);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_3);
+ writel(val | PDB_ENBL, ax_phy->reg_base + PHY_CTRL_3);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_2);
+ writel(val | OTAP_SEL(OTAP_DLY), ax_phy->reg_base + PHY_CTRL_2);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_1);
+ writel(val | DLL_TRM(DLL_TRM_ICP), ax_phy->reg_base + PHY_CTRL_1);
+
+ val = readl(ax_phy->reg_base + PHY_CTRL_3);
+ writel(val | DLL_FRQSEL(FRQ_SEL), ax_phy->reg_base + PHY_CTRL_3);
+
+ ret = read_poll_timeout(readl, val, val & DLL_RDY_MASK, POLL_DELAY_US,
+ POLL_TIMEOUT_MS * 1000, false,
+ ax_phy->reg_base + STATUS);
+ if (ret) {
+ dev_err(dev, "DLL ready timeout\n");
+ return ret;
+ }
+
+ return 0;
+}
+
+static const struct phy_ops axiado_emmc_phy_ops = {
+ .init = axiado_emmc_phy_init,
+ .power_on = axiado_emmc_phy_power_on,
+ .owner = THIS_MODULE,
+};
+
+static const struct of_device_id axiado_emmc_phy_of_match[] = {
+ { .compatible = "axiado,ax3000-emmc-phy" },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, axiado_emmc_phy_of_match);
+
+static int axiado_emmc_phy_probe(struct platform_device *pdev)
+{
+ struct axiado_emmc_phy *ax_phy;
+ struct phy_provider *phy_provider;
+ struct device *dev = &pdev->dev;
+ struct phy *generic_phy;
+
+ if (!dev->of_node)
+ return -ENODEV;
+
+ ax_phy = devm_kzalloc(dev, sizeof(*ax_phy), GFP_KERNEL);
+ if (!ax_phy)
+ return -ENOMEM;
+
+ ax_phy->reg_base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(ax_phy->reg_base))
+ return PTR_ERR(ax_phy->reg_base);
+
+ ax_phy->dev = dev;
+
+ generic_phy = devm_phy_create(dev, dev->of_node, &axiado_emmc_phy_ops);
+ if (IS_ERR(generic_phy))
+ return dev_err_probe(dev, PTR_ERR(generic_phy),
+ "failed to create PHY\n");
+
+ phy_set_drvdata(generic_phy, ax_phy);
+ phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+
+ return PTR_ERR_OR_ZERO(phy_provider);
+}
+
+static struct platform_driver axiado_emmc_phy_driver = {
+ .probe = axiado_emmc_phy_probe,
+ .driver = {
+ .name = "axiado-emmc-phy",
+ .of_match_table = axiado_emmc_phy_of_match,
+ },
+};
+module_platform_driver(axiado_emmc_phy_driver);
+
+MODULE_DESCRIPTION("AX3000 eMMC PHY Driver");
+MODULE_AUTHOR("Axiado Corporation");
+MODULE_LICENSE("GPL");
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver Tzu-Hao Wei
@ 2026-01-09 9:43 ` Tzu-Hao Wei
2026-01-11 10:40 ` Krzysztof Kozlowski
2026-01-12 6:02 ` Prasad Bolisetty
2026-01-09 9:43 ` [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node Tzu-Hao Wei
` (2 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09 9:43 UTC (permalink / raw)
To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc,
Tzu-Hao Wei
Add SriNavmani, Prasad and me as maintainers for Axiado AX3000 eMMC PHY
driver
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
MAINTAINERS | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a0dd762f5648b7e4e6fc62560662e43720422e01..6d1af11eb289ffb7c0d8634ac7d8f903aed1799c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4250,6 +4250,16 @@ W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml
F: drivers/hwmon/axi-fan-control.c
+AXIADO EMMC PHY DRIVER
+M: SriNavmani A <srinavmani@axiado.com>
+M: Tzu-Hao Wei <twei@axiado.com>
+M: Prasad Bolisetty <pbolisetty@axiado.com>
+L: linux-phy@lists.infradead.org (moderated for non-subscribers)
+S: Maintained
+F: Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
+F: drivers/phy/axiado/Kconfig
+F: drivers/phy/axiado/phy-axiado-emmc.c
+
AXI SPI ENGINE
M: Michael Hennerich <michael.hennerich@analog.com>
M: Nuno Sá <nuno.sa@analog.com>
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
` (2 preceding siblings ...)
2026-01-09 9:43 ` [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 " Tzu-Hao Wei
@ 2026-01-09 9:43 ` Tzu-Hao Wei
2026-01-12 8:32 ` [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Krzysztof Kozlowski
2026-01-12 15:17 ` Rob Herring
5 siblings, 0 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-09 9:43 UTC (permalink / raw)
To: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc,
Tzu-Hao Wei
From: SriNavmani A <srinavmani@axiado.com>
Add the eMMC PHY device tree node to the AX3000 SoC DTSI.
AX3000 has one eMMC PHY interface.
Signed-off-by: SriNavmani A <srinavmani@axiado.com>
Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
---
arch/arm64/boot/dts/axiado/ax3000.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/axiado/ax3000.dtsi b/arch/arm64/boot/dts/axiado/ax3000.dtsi
index 792f52e0c7dd42cbc54b0eb47e25b0fbf1a706b8..4694a9fd94c53a4bd6d752ba8001fbeba74594db 100644
--- a/arch/arm64/boot/dts/axiado/ax3000.dtsi
+++ b/arch/arm64/boot/dts/axiado/ax3000.dtsi
@@ -507,6 +507,13 @@ uart3: serial@80520800 {
clocks = <&refclk &refclk>;
status = "disabled";
};
+
+ emmc_phy: phy@80801c00 {
+ compatible = "axiado,ax3000-emmc-phy";
+ reg = <0x00 0x80801c00 0x00 0x1000>;
+ #phy-cells = <0>;
+ status = "disabled";
+ };
};
timer {
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
2026-01-09 9:43 ` [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY Tzu-Hao Wei
@ 2026-01-11 10:37 ` Krzysztof Kozlowski
2026-01-12 8:34 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-11 10:37 UTC (permalink / raw)
To: Tzu-Hao Wei
Cc: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, openbmc
On Fri, Jan 09, 2026 at 05:43:29PM +0800, Tzu-Hao Wei wrote:
> From: SriNavmani A <srinavmani@axiado.com>
>
> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
> HS200 eMMC host controller.
>
> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
You did not bother to test your code...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
2026-01-09 9:43 ` [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 " Tzu-Hao Wei
@ 2026-01-11 10:40 ` Krzysztof Kozlowski
2026-01-13 3:38 ` Tzu-Hao Wei
2026-01-12 6:02 ` Prasad Bolisetty
1 sibling, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-11 10:40 UTC (permalink / raw)
To: Tzu-Hao Wei
Cc: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, openbmc
On Fri, Jan 09, 2026 at 05:43:31PM +0800, Tzu-Hao Wei wrote:
> Add SriNavmani, Prasad and me as maintainers for Axiado AX3000 eMMC PHY
> driver
>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
> MAINTAINERS | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a0dd762f5648b7e4e6fc62560662e43720422e01..6d1af11eb289ffb7c0d8634ac7d8f903aed1799c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4250,6 +4250,16 @@ W: https://ez.analog.com/linux-software-drivers
> F: Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml
> F: drivers/hwmon/axi-fan-control.c
>
> +AXIADO EMMC PHY DRIVER
> +M: SriNavmani A <srinavmani@axiado.com>
No activity:
https://lore.kernel.org/all/?q=f%3Asrinavmani%40axiado.com
> +M: Tzu-Hao Wei <twei@axiado.com>
> +M: Prasad Bolisetty <pbolisetty@axiado.com>
No reviews:
https://lore.kernel.org/all/?q=f%3Apbolisetty%40axiado.com
Are these maintainers going to actually maintain code? At least Prasad
should provide proper review now.
> +L: linux-phy@lists.infradead.org (moderated for non-subscribers)
> +S: Maintained
> +F: Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
> +F: drivers/phy/axiado/Kconfig
> +F: drivers/phy/axiado/phy-axiado-emmc.c
If you are a maintainer of Kconfig you imply you maintain everything, so
simply entire directory...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
2026-01-09 9:43 ` [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 " Tzu-Hao Wei
2026-01-11 10:40 ` Krzysztof Kozlowski
@ 2026-01-12 6:02 ` Prasad Bolisetty
1 sibling, 0 replies; 16+ messages in thread
From: Prasad Bolisetty @ 2026-01-12 6:02 UTC (permalink / raw)
To: Tzu-Hao Wei, SriNavmani A, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc
On 1/9/2026 1:43 AM, Tzu-Hao Wei wrote:
> Add SriNavmani, Prasad and me as maintainers for Axiado AX3000 eMMC PHY
> driver
>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
> MAINTAINERS | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a0dd762f5648b7e4e6fc62560662e43720422e01..6d1af11eb289ffb7c0d8634ac7d8f903aed1799c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4250,6 +4250,16 @@ W: https://ez.analog.com/linux-software-drivers
> F: Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml
> F: drivers/hwmon/axi-fan-control.c
>
> +AXIADO EMMC PHY DRIVER
> +M: SriNavmani A <srinavmani@axiado.com>
> +M: Tzu-Hao Wei <twei@axiado.com>
> +M: Prasad Bolisetty <pbolisetty@axiado.com>
Acked-by: Prasad Bolisetty <pbolisetty@axiado.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
` (3 preceding siblings ...)
2026-01-09 9:43 ` [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node Tzu-Hao Wei
@ 2026-01-12 8:32 ` Krzysztof Kozlowski
2026-01-13 6:16 ` Tzu-Hao Wei
2026-01-12 15:17 ` Rob Herring
5 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-12 8:32 UTC (permalink / raw)
To: Tzu-Hao Wei, SriNavmani A, Prasad Bolisetty, Vinod Koul,
Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc
On 09/01/2026 10:43, Tzu-Hao Wei wrote:
> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
> HS200 eMMC controller.
>
> This series includes:
> 1. Add bindings for Axiado AX3000 eMMC PHY
> 2. Add Axiado AX3000 eMMC phy driver
> 3. Update MAINTAINERS for the new driver
> 4. Update Axiado AX3000 device tree
>
> Changes: (The previous version was mixed with Host driver, so I separate
> the PHY driver as a new thread)
> - Fix property order in required section to match properties section
> - Fixed example to use lowercase hex and proper node naming
> - Removed wrapper functions, use readl/writel directly
> - Replaced manual polling loops with read_poll_timeout macro
> - Used devm_platform_ioremap_resource instead of separate calls
> - Removed unnecessary of_match_node check
> - Used dev_err_probe for error reporting
> - Added proper Kconfig dependencies (ARCH_AXIADO || COMPILE_TEST)
> - Fixed various coding style issues
> - Link to previous patches: https://lore.kernel.org/all/20251222-axiado-ax3000-add-emmc-host-driver-support-v1-0-5457d0ebcdb4@axiado.com/
>
So v2. Always version your patches correctly.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
2026-01-11 10:37 ` Krzysztof Kozlowski
@ 2026-01-12 8:34 ` Krzysztof Kozlowski
2026-01-12 10:27 ` Tzu-Hao Wei
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-12 8:34 UTC (permalink / raw)
To: Tzu-Hao Wei
Cc: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, openbmc
On 11/01/2026 11:37, Krzysztof Kozlowski wrote:
> On Fri, Jan 09, 2026 at 05:43:29PM +0800, Tzu-Hao Wei wrote:
>> From: SriNavmani A <srinavmani@axiado.com>
>>
>> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
>> HS200 eMMC host controller.
>>
>> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
>> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
>> ---
>
> You did not bother to test your code...
And this is not even v1, but v2 and you completely ignored that part.
So did you implement any previous feedback?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
2026-01-12 8:34 ` Krzysztof Kozlowski
@ 2026-01-12 10:27 ` Tzu-Hao Wei
0 siblings, 0 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-12 10:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, openbmc
On 1/12/2026 4:34 PM, Krzysztof Kozlowski wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
>> You did not bother to test your code...
>
> And this is not even v1, but v2 and you completely ignored that part.
>
> So did you implement any previous feedback?
>
> Best regards,
> Krzysztof
Sorry for the confusion.
All of your previous feedback was implemented. I missed one YAML change
when preparing the resend, which made it look like the feedback was
ignored.
My original intent was:
- resend the eMMC host series as v2 with the PHY driver removed, and
- submit the eMMC PHY as a separate v1 thread.
However, due to the mistake above, this was not communicated clearly and
the versioning caused confusion.
I understand this is frustrating. I will resend with correct versioning,
explicitly list the addressed feedback, and include clear testing details
to avoid any ambiguity.
Thanks for your patience.
Best regards,
TH
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
` (4 preceding siblings ...)
2026-01-12 8:32 ` [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Krzysztof Kozlowski
@ 2026-01-12 15:17 ` Rob Herring
2026-02-04 9:19 ` Tzu-Hao Wei
5 siblings, 1 reply; 16+ messages in thread
From: Rob Herring @ 2026-01-12 15:17 UTC (permalink / raw)
To: Tzu-Hao Wei
Cc: devicetree, Krzysztof Kozlowski, SriNavmani A, openbmc,
Neil Armstrong, Prasad Bolisetty, linux-kernel, Conor Dooley,
linux-phy, linux-arm-kernel, Vinod Koul
On Fri, 09 Jan 2026 17:43:28 +0800, Tzu-Hao Wei wrote:
> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
> HS200 eMMC controller.
>
> This series includes:
> 1. Add bindings for Axiado AX3000 eMMC PHY
> 2. Add Axiado AX3000 eMMC phy driver
> 3. Update MAINTAINERS for the new driver
> 4. Update Axiado AX3000 device tree
>
> Changes: (The previous version was mixed with Host driver, so I separate
> the PHY driver as a new thread)
> - Fix property order in required section to match properties section
> - Fixed example to use lowercase hex and proper node naming
> - Removed wrapper functions, use readl/writel directly
> - Replaced manual polling loops with read_poll_timeout macro
> - Used devm_platform_ioremap_resource instead of separate calls
> - Removed unnecessary of_match_node check
> - Used dev_err_probe for error reporting
> - Added proper Kconfig dependencies (ARCH_AXIADO || COMPILE_TEST)
> - Fixed various coding style issues
> - Link to previous patches: https://lore.kernel.org/all/20251222-axiado-ax3000-add-emmc-host-driver-support-v1-0-5457d0ebcdb4@axiado.com/
>
> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
> ---
> SriNavmani A (3):
> dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
> phy: axiado: add Axiado eMMC PHY driver
> arm64: dts: axiado: Add eMMC PHY node
>
> Tzu-Hao Wei (1):
> MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
>
> .../bindings/phy/axiado,ax3000-emmc-phy.yaml | 38 ++++
> MAINTAINERS | 10 +
> arch/arm64/boot/dts/axiado/ax3000.dtsi | 7 +
> drivers/phy/Kconfig | 1 +
> drivers/phy/Makefile | 1 +
> drivers/phy/axiado/Kconfig | 11 ++
> drivers/phy/axiado/Makefile | 1 +
> drivers/phy/axiado/phy-axiado-emmc.c | 220 +++++++++++++++++++++
> 8 files changed, 289 insertions(+)
> ---
> base-commit: f0b9d8eb98dfee8d00419aa07543bdc2c1a44fb1
> change-id: 20260108-axiado-ax3000-add-emmc-phy-driver-support-d61aead8f622
>
> Best regards,
> --
> Tzu-Hao Wei <twei@axiado.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Deps: looking for dependencies matching 4 patch-ids
Deps: Applying prerequisite patch: [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
Deps: Applying prerequisite patch: [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver
Deps: Applying prerequisite patch: [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
Deps: Applying prerequisite patch: [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node
Base: f10c325a345fef0a688a2bcdfab1540d1c924148 (use --merge-base to override)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/axiado/' for 20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-0-dd43459dbfea@axiado.com:
arch/arm64/boot/dts/axiado/ax3000-evk.dtb: /soc/phy@80801c00: failed to match any schema with compatible: ['axiado,ax3000-emmc-phy']
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
2026-01-11 10:40 ` Krzysztof Kozlowski
@ 2026-01-13 3:38 ` Tzu-Hao Wei
0 siblings, 0 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-13 3:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: SriNavmani A, Prasad Bolisetty, Vinod Koul, Neil Armstrong,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, openbmc
On 1/11/2026 6:40 PM, Krzysztof Kozlowski wrote:
>>
>> +AXIADO EMMC PHY DRIVER
>> +M: SriNavmani A <srinavmani@axiado.com>
>
> No activity:
> https://lore.kernel.org/all/?q=f%3Asrinavmani%40axiado.com
>
>> +M: Tzu-Hao Wei <twei@axiado.com>
>> +M: Prasad Bolisetty <pbolisetty@axiado.com>
>
> No reviews:
> https://lore.kernel.org/all/?q=f%3Apbolisetty%40axiado.com
>
> Are these maintainers going to actually maintain code? At least Prasad
> should provide proper review now.
>
I'll ask them to Ack/Review the patches.
>> +L: linux-phy@lists.infradead.org (moderated for non-subscribers)
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/phy/axiado,ax3000-emmc-phy.yaml
>
>> +F: drivers/phy/axiado/Kconfig
>> +F: drivers/phy/axiado/phy-axiado-emmc.c
>
> If you are a maintainer of Kconfig you imply you maintain everything, so
> simply entire directory...
>
Yes, we will maintain everything in drivers/phy/axiado/
Best regards,
TH
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC
2026-01-12 8:32 ` [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Krzysztof Kozlowski
@ 2026-01-13 6:16 ` Tzu-Hao Wei
0 siblings, 0 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-01-13 6:16 UTC (permalink / raw)
To: Krzysztof Kozlowski, SriNavmani A, Prasad Bolisetty, Vinod Koul,
Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel, openbmc
On 1/12/2026 4:32 PM, Krzysztof Kozlowski wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> On 09/01/2026 10:43, Tzu-Hao Wei wrote:
>> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
>> HS200 eMMC controller.
>>
>> This series includes:
>> 1. Add bindings for Axiado AX3000 eMMC PHY
>> 2. Add Axiado AX3000 eMMC phy driver
>> 3. Update MAINTAINERS for the new driver
>> 4. Update Axiado AX3000 device tree
>>
>> Changes: (The previous version was mixed with Host driver, so I separate
>> the PHY driver as a new thread)
>> - Fix property order in required section to match properties section
>> - Fixed example to use lowercase hex and proper node naming
>> - Removed wrapper functions, use readl/writel directly
>> - Replaced manual polling loops with read_poll_timeout macro
>> - Used devm_platform_ioremap_resource instead of separate calls
>> - Removed unnecessary of_match_node check
>> - Used dev_err_probe for error reporting
>> - Added proper Kconfig dependencies (ARCH_AXIADO || COMPILE_TEST)
>> - Fixed various coding style issues
>> - Link to previous patches: https://lore.kernel.org/all/20251222-axiado-ax3000-add-emmc-host-driver-support-v1-0-5457d0ebcdb4@axiado.com/
>>
>
> So v2. Always version your patches correctly.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Understood, thanks for clarifying.
Although the PHY patches were split into a separate thread from the
previous combined host+phy series, they are a continuation of the same
work and therefore should follow the existing versioning.
Just to confirm before resending: I will submit the next eMMC PHY series
as v2. Please let me know if this is not correct.
Best regards,
TH
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver
2026-01-09 9:43 ` [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver Tzu-Hao Wei
@ 2026-01-15 22:22 ` kernel test robot
0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2026-01-15 22:22 UTC (permalink / raw)
To: Tzu-Hao Wei, SriNavmani A, Prasad Bolisetty, Vinod Koul,
Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: oe-kbuild-all, linux-phy, devicetree, linux-arm-kernel,
linux-kernel, openbmc, Tzu-Hao Wei
Hi Tzu-Hao,
kernel test robot noticed the following build errors:
[auto build test ERROR on f0b9d8eb98dfee8d00419aa07543bdc2c1a44fb1]
url: https://github.com/intel-lab-lkp/linux/commits/Tzu-Hao-Wei/dt-bindings-phy-axiado-ax3000-emmc-phy-add-Axiado-eMMC-PHY/20260109-174938
base: f0b9d8eb98dfee8d00419aa07543bdc2c1a44fb1
patch link: https://lore.kernel.org/r/20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-2-dd43459dbfea%40axiado.com
patch subject: [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260116/202601160610.y8FbB5x1-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260116/202601160610.y8FbB5x1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601160610.y8FbB5x1-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/swab.h:5,
from include/uapi/linux/byteorder/big_endian.h:14,
from include/linux/byteorder/big_endian.h:5,
from arch/m68k/include/uapi/asm/byteorder.h:5,
from include/asm-generic/bitops/le.h:6,
from arch/m68k/include/asm/bitops.h:569,
from include/linux/bitops.h:67,
from include/linux/thread_info.h:27,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from arch/m68k/include/asm/processor.h:11,
from include/linux/sched.h:13,
from include/linux/delay.h:13,
from drivers/phy/axiado/phy-axiado-emmc.c:11:
drivers/phy/axiado/phy-axiado-emmc.c: In function 'axiado_emmc_phy_power_on':
>> drivers/phy/axiado/phy-axiado-emmc.c:69:34: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
69 | #define OTAP_SEL(x) (FIELD_PREP(OTAP_SEL_MASK, x) | OTAPDLY_EN)
| ^~~~~~~~~~
include/uapi/linux/swab.h:118:38: note: in definition of macro '__swab32'
118 | (__u32)(__builtin_constant_p(x) ? \
| ^
include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
88 | #define cpu_to_le32 __cpu_to_le32
| ^~~~~~~~~~~~~
arch/m68k/include/asm/io_mm.h:373:26: note: in expansion of macro 'out_le32'
373 | #define writel(val,addr) out_le32((addr),(val))
| ^~~~~~~~
drivers/phy/axiado/phy-axiado-emmc.c:147:9: note: in expansion of macro 'writel'
147 | writel(val | OTAP_SEL(OTAP_DLY), ax_phy->reg_base + PHY_CTRL_2);
| ^~~~~~
drivers/phy/axiado/phy-axiado-emmc.c:147:22: note: in expansion of macro 'OTAP_SEL'
147 | writel(val | OTAP_SEL(OTAP_DLY), ax_phy->reg_base + PHY_CTRL_2);
| ^~~~~~~~
vim +/FIELD_PREP +69 drivers/phy/axiado/phy-axiado-emmc.c
> 11 #include <linux/delay.h>
12 #include <linux/io.h>
13 #include <linux/iopoll.h>
14 #include <linux/module.h>
15 #include <linux/of.h>
16 #include <linux/phy/phy.h>
17 #include <linux/platform_device.h>
18
19 /* Arasan eMMC 5.1 - PHY configuration registers */
20 #define CAP_REG_IN_S1_LSB 0x00
21 #define CAP_REG_IN_S1_MSB 0x04
22 #define PHY_CTRL_1 0x38
23 #define PHY_CTRL_2 0x3C
24 #define PHY_CTRL_3 0x40
25 #define STATUS 0x50
26
27 #define DLL_ENBL BIT(26)
28 #define RTRIM_EN BIT(21)
29 #define PDB_ENBL BIT(23)
30 #define RETB_ENBL BIT(1)
31
32 #define REN_STRB BIT(27)
33 #define REN_CMD BIT(12)
34 #define REN_DAT0 BIT(13)
35 #define REN_DAT1 BIT(14)
36 #define REN_DAT2 BIT(15)
37 #define REN_DAT3 BIT(16)
38 #define REN_DAT4 BIT(17)
39 #define REN_DAT5 BIT(18)
40 #define REN_DAT6 BIT(19)
41 #define REN_DAT7 BIT(20)
42 #define REN_CMD_EN (REN_CMD | REN_DAT0 | REN_DAT1 | REN_DAT2 | \
43 REN_DAT3 | REN_DAT4 | REN_DAT5 | REN_DAT6 | REN_DAT7)
44
45 /* Pull-UP Enable on CMD Line */
46 #define PU_CMD BIT(3)
47 #define PU_DAT0 BIT(4)
48 #define PU_DAT1 BIT(5)
49 #define PU_DAT2 BIT(6)
50 #define PU_DAT3 BIT(7)
51 #define PU_DAT4 BIT(8)
52 #define PU_DAT5 BIT(9)
53 #define PU_DAT6 BIT(10)
54 #define PU_DAT7 BIT(11)
55 #define PU_CMD_EN (PU_CMD | PU_DAT0 | PU_DAT1 | PU_DAT2 | PU_DAT3 | \
56 PU_DAT4 | PU_DAT5 | PU_DAT6 | PU_DAT7)
57
58 /* Selection value for the optimum delay from 1-32 output tap lines */
59 #define OTAP_DLY 0x02
60 /* DLL charge pump current trim default [1000] */
61 #define DLL_TRM_ICP 0x08
62 /* Select the frequency range of DLL Operation */
63 #define FRQ_SEL 0x01
64
65 #define OTAP_SEL_MASK GENMASK(10, 7)
66 #define DLL_TRM_MASK GENMASK(25, 22)
67 #define DLL_FRQSEL_MASK GENMASK(27, 25)
68
> 69 #define OTAP_SEL(x) (FIELD_PREP(OTAP_SEL_MASK, x) | OTAPDLY_EN)
70 #define DLL_TRM(x) (FIELD_PREP(DLL_TRM_MASK, x) | DLL_ENBL)
71 #define DLL_FRQSEL(x) FIELD_PREP(DLL_FRQSEL_MASK, x)
72
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC
2026-01-12 15:17 ` Rob Herring
@ 2026-02-04 9:19 ` Tzu-Hao Wei
0 siblings, 0 replies; 16+ messages in thread
From: Tzu-Hao Wei @ 2026-02-04 9:19 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Krzysztof Kozlowski, SriNavmani A, openbmc,
Neil Armstrong, Prasad Bolisetty, linux-kernel, Conor Dooley,
linux-phy, linux-arm-kernel, Vinod Koul
On 1/12/2026 11:17 PM, Rob Herring wrote:
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Deps: looking for dependencies matching 4 patch-ids
> Deps: Applying prerequisite patch: [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
> Deps: Applying prerequisite patch: [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver
> Deps: Applying prerequisite patch: [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 eMMC PHY driver
> Deps: Applying prerequisite patch: [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node
> Base: f10c325a345fef0a688a2bcdfab1540d1c924148 (use --merge-base to override)
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/axiado/' for 20260109-axiado-ax3000-add-emmc-phy-driver-support-v1-0-dd43459dbfea@axiado.com:
>
> arch/arm64/boot/dts/axiado/ax3000-evk.dtb: /soc/phy@80801c00: failed to match any schema with compatible: ['axiado,ax3000-emmc-phy']
Thanks. It will be fixed in the next version.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2026-02-04 9:19 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY Tzu-Hao Wei
2026-01-11 10:37 ` Krzysztof Kozlowski
2026-01-12 8:34 ` Krzysztof Kozlowski
2026-01-12 10:27 ` Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver Tzu-Hao Wei
2026-01-15 22:22 ` kernel test robot
2026-01-09 9:43 ` [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 " Tzu-Hao Wei
2026-01-11 10:40 ` Krzysztof Kozlowski
2026-01-13 3:38 ` Tzu-Hao Wei
2026-01-12 6:02 ` Prasad Bolisetty
2026-01-09 9:43 ` [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node Tzu-Hao Wei
2026-01-12 8:32 ` [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Krzysztof Kozlowski
2026-01-13 6:16 ` Tzu-Hao Wei
2026-01-12 15:17 ` Rob Herring
2026-02-04 9:19 ` Tzu-Hao Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox