From: Yixun Lan <dlan@gentoo.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Alex Elder <elder@riscstar.com>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree
Date: Thu, 22 Jan 2026 18:11:22 +0800 [thread overview]
Message-ID: <20260122101122-GYA63789@gentoo.org> (raw)
In-Reply-To: <20260122-spacemit-p1-v1-0-309be27fbff9@riscstar.com>
Hi Guodong,
On 17:43 Thu 22 Jan , Guodong Xu wrote:
> This series fixes hardware voltage constraints and enables flexible power
> tree configurations for the SpacemiT P1 PMIC.
>
> Patch 1, n_voltages is corrected to match hardware register widths, as the
> previous values prevented regulators from reaching higher operational
> voltages (e.g., 3.3V on LDOs).
>
> Patch 2-4, hardcoded supply assumptions are replaced with explicit
> devicetree properties. PMIC supply connections are board-design decisions.
> Moving this to DT allows supporting varied topologies without driver
> modifications.
>
> Note: Patch 3 introduces a bisect breakage by transitioning to
> pin-specific supply names. Probe failures will occur on existing board
> (K1 Bananapi F3) until Patch 4 updates the corresponding DTS file.
This patch bring system-wide change that not only affect Bananapi F3..
Please also provide fix for other boards, I think you may not be able
to test all boards, but make sure the patches are available, so people
who interested can test, P.S I can help on milkv jupiter board
>
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
> Guodong Xu (4):
> regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators
> dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties
> regulator: spacemit-p1: Update supply names
> riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties
>
> .../devicetree/bindings/mfd/spacemit,p1.yaml | 58 +++++++++++++++++++++-
> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 12 ++++-
> drivers/regulator/spacemit-p1.c | 25 ++++++----
> 3 files changed, 80 insertions(+), 15 deletions(-)
> ---
> base-commit: c8a4a774a9b0d2c86593492625874e27e9cbc9a9
> change-id: 20260122-spacemit-p1-ae596efe885f
>
> Best regards,
> --
> Guodong Xu <guodong@riscstar.com>
>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-01-22 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 9:43 [PATCH 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree Guodong Xu
2026-01-22 9:43 ` [PATCH 1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators Guodong Xu
2026-01-22 9:43 ` [PATCH 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties Guodong Xu
2026-01-22 10:20 ` Rob Herring (Arm)
2026-01-22 12:23 ` Yixun Lan
2026-01-22 16:11 ` Rob Herring
2026-01-22 9:43 ` [PATCH 3/4] regulator: spacemit-p1: Update supply names Guodong Xu
2026-01-22 9:43 ` [PATCH 4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties Guodong Xu
2026-01-22 10:11 ` Yixun Lan [this message]
2026-01-22 11:27 ` [PATCH 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree Mark Brown
2026-01-22 12:12 ` Yixun Lan
2026-01-22 13:28 ` Mark Brown
2026-01-22 13:41 ` Yixun Lan
2026-01-22 14:55 ` Guodong Xu
2026-01-22 22:09 ` Yixun Lan
2026-01-23 8:23 ` Javier Martinez Canillas
2026-01-26 22:10 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122101122-GYA63789@gentoo.org \
--to=dlan@gentoo.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@riscstar.com \
--cc=guodong@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox