* [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch
@ 2026-01-22 12:58 Lukasz Majewski
2026-01-22 18:21 ` Conor Dooley
0 siblings, 1 reply; 4+ messages in thread
From: Lukasz Majewski @ 2026-01-22 12:58 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-clk, devicetree, linux-kernel, Lukasz Majewski
This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
macros definitions for L2 switch.
Those definitions describe clocks for MoreThanIP switch IP block;
the switch itself and the MAC address lookup table clocks.
Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
---
include/dt-bindings/clock/vf610-clock.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/clock/vf610-clock.h b/include/dt-bindings/clock/vf610-clock.h
index 373644e46747..b6f7b1745cc2 100644
--- a/include/dt-bindings/clock/vf610-clock.h
+++ b/include/dt-bindings/clock/vf610-clock.h
@@ -197,6 +197,11 @@
#define VF610_CLK_TCON1 188
#define VF610_CLK_CAAM 189
#define VF610_CLK_CRC 190
-#define VF610_CLK_END 191
+#define VF610_CLK_ESW 191
+#define VF610_CLK_ESW_MAC_TAB0 192
+#define VF610_CLK_ESW_MAC_TAB1 193
+#define VF610_CLK_ESW_MAC_TAB2 194
+#define VF610_CLK_ESW_MAC_TAB3 195
+#define VF610_CLK_END 196
#endif /* __DT_BINDINGS_CLOCK_VF610_H */
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch 2026-01-22 12:58 [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch Lukasz Majewski @ 2026-01-22 18:21 ` Conor Dooley 2026-01-22 19:26 ` Łukasz Majewski 0 siblings, 1 reply; 4+ messages in thread From: Conor Dooley @ 2026-01-22 18:21 UTC (permalink / raw) To: Lukasz Majewski Cc: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-clk, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1304 bytes --] On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote: > This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123} > macros definitions for L2 switch. > > Those definitions describe clocks for MoreThanIP switch IP block; > the switch itself and the MAC address lookup table clocks. > > Signed-off-by: Lukasz Majewski <lukma@nabladev.com> > --- > include/dt-bindings/clock/vf610-clock.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/vf610-clock.h b/include/dt-bindings/clock/vf610-clock.h > index 373644e46747..b6f7b1745cc2 100644 > --- a/include/dt-bindings/clock/vf610-clock.h > +++ b/include/dt-bindings/clock/vf610-clock.h > @@ -197,6 +197,11 @@ > #define VF610_CLK_TCON1 188 > #define VF610_CLK_CAAM 189 > #define VF610_CLK_CRC 190 > -#define VF610_CLK_END 191 If end is modifiable, it is removable. If you need the define for the driver, please move it there. pw-bot: changes-requested > +#define VF610_CLK_ESW 191 > +#define VF610_CLK_ESW_MAC_TAB0 192 > +#define VF610_CLK_ESW_MAC_TAB1 193 > +#define VF610_CLK_ESW_MAC_TAB2 194 > +#define VF610_CLK_ESW_MAC_TAB3 195 > +#define VF610_CLK_END 196 > > #endif /* __DT_BINDINGS_CLOCK_VF610_H */ > -- > 2.39.5 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch 2026-01-22 18:21 ` Conor Dooley @ 2026-01-22 19:26 ` Łukasz Majewski 2026-01-23 17:06 ` Conor Dooley 0 siblings, 1 reply; 4+ messages in thread From: Łukasz Majewski @ 2026-01-22 19:26 UTC (permalink / raw) To: Conor Dooley Cc: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-clk, devicetree, linux-kernel Hi Conor, > On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote: > > This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123} > > macros definitions for L2 switch. > > > > Those definitions describe clocks for MoreThanIP switch IP block; > > the switch itself and the MAC address lookup table clocks. > > > > Signed-off-by: Lukasz Majewski <lukma@nabladev.com> > > --- > > include/dt-bindings/clock/vf610-clock.h | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/vf610-clock.h > > b/include/dt-bindings/clock/vf610-clock.h index > > 373644e46747..b6f7b1745cc2 100644 --- > > a/include/dt-bindings/clock/vf610-clock.h +++ > > b/include/dt-bindings/clock/vf610-clock.h @@ -197,6 +197,11 @@ > > #define VF610_CLK_TCON1 188 > > #define VF610_CLK_CAAM 189 > > #define VF610_CLK_CRC 190 > > -#define VF610_CLK_END 191 > > If end is modifiable, it is removable. If you need the define for the > driver, please move it there. Could you be more specific regarding your comment? The VF610_CLK_END has now value 191. However, there are other clocks in this SoC - like CLK_ESW and CLK_MAC_TAB{x} - which were not taken into account earlier. What shall be done? Shall I remove the VF610_CLK_END entirely? Or move to the new "end" (as done with this patch)? > > pw-bot: changes-requested > > > +#define VF610_CLK_ESW 191 > > +#define VF610_CLK_ESW_MAC_TAB0 192 > > +#define VF610_CLK_ESW_MAC_TAB1 193 > > +#define VF610_CLK_ESW_MAC_TAB2 194 > > +#define VF610_CLK_ESW_MAC_TAB3 195 > > +#define VF610_CLK_END 196 > > > > #endif /* __DT_BINDINGS_CLOCK_VF610_H */ > > -- > > 2.39.5 > > -- Best regards, Lukasz Majewski -- Nabla Software Engineering GmbH HRB 40522 Augsburg Phone: +49 821 45592596 E-Mail: office@nabladev.com Managing Director : Stefano Babic ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch 2026-01-22 19:26 ` Łukasz Majewski @ 2026-01-23 17:06 ` Conor Dooley 0 siblings, 0 replies; 4+ messages in thread From: Conor Dooley @ 2026-01-23 17:06 UTC (permalink / raw) To: Łukasz Majewski Cc: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-clk, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1949 bytes --] On Thu, Jan 22, 2026 at 08:26:03PM +0100, Łukasz Majewski wrote: > Hi Conor, > > > On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote: > > > This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123} > > > macros definitions for L2 switch. > > > > > > Those definitions describe clocks for MoreThanIP switch IP block; > > > the switch itself and the MAC address lookup table clocks. > > > > > > Signed-off-by: Lukasz Majewski <lukma@nabladev.com> > > > --- > > > include/dt-bindings/clock/vf610-clock.h | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/dt-bindings/clock/vf610-clock.h > > > b/include/dt-bindings/clock/vf610-clock.h index > > > 373644e46747..b6f7b1745cc2 100644 --- > > > a/include/dt-bindings/clock/vf610-clock.h +++ > > > b/include/dt-bindings/clock/vf610-clock.h @@ -197,6 +197,11 @@ > > > #define VF610_CLK_TCON1 188 > > > #define VF610_CLK_CAAM 189 > > > #define VF610_CLK_CRC 190 > > > -#define VF610_CLK_END 191 > > > > If end is modifiable, it is removable. If you need the define for the > > driver, please move it there. > > Could you be more specific regarding your comment? Values in bindings are immutable, so changing a definition is an ABI break. If you can break the ABI for this definition, then you should just remove it instead, because it doesn't represent a clock and it is liable to change when you information comes to light (e.g. this patch). > The VF610_CLK_END has now value 191. > > However, there are other clocks in this SoC - like CLK_ESW and > CLK_MAC_TAB{x} - which were not taken into account earlier. > > What shall be done? > > Shall I remove the VF610_CLK_END entirely? > > Or move to the new "end" (as done with this patch)? If you need VF610_CLK_END for your driver, rather than just using (VF610_CLK_ESW_MAC_TAB + 1), please move the definition there. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-23 17:06 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-22 12:58 [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch Lukasz Majewski 2026-01-22 18:21 ` Conor Dooley 2026-01-22 19:26 ` Łukasz Majewski 2026-01-23 17:06 ` Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox