From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F6027A476 for ; Fri, 23 Jan 2026 13:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769174723; cv=none; b=kQEMzgFjw/QFjBWA1JbC+j3ljDoAcRHIpZPkmrwYRdmIVhIaCGtLXNN7vWp+QuDj4tTdaQHrJfXK+ocCxIdfbu9n2E3mxyfMQ+6btmOh6eCobTMPzwRxWiJx/d9uF34eFPPo10uejYXpvxI9qc6lWSN8YmKwUrzv8QFShdW+sPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769174723; c=relaxed/simple; bh=dl7NlkiIvE4aCaKk0Pre5K+Ti7kNdoTw5jT1Cl5ZZAE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R+rNmt5GlhtSxsHrIvFeF1QWhbND0pajQx4fYiLt4EF2oxZd9f2lIS02ngy1swWs3TMiw8jhuEtLf1WaWjE8GsYhk7+M36oulZ01N5Th3z66xsZ6II4J2ZlQRT0bOAvB2XmB4zsJZJBpBkhZ7u9P9LwqjNROgdcE3C8v0GpQ4DU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B5OSP2t8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XDNzuahY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B5OSP2t8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XDNzuahY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769174721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dl7NlkiIvE4aCaKk0Pre5K+Ti7kNdoTw5jT1Cl5ZZAE=; b=B5OSP2t86RRnFNzdmsmEzd12Xkc0c9MiH0FxIAgf7bSwNYjpN4QcCfyeBTyikbW+xIeZy2 E/Un8+EW8vmwzRiFolCskDKVJuhO0IBSIDn0eAJybfCAfl6pgtzx8PQgFZqJF9n7mLGXjp tRSy4vsjnWCApm+MjuPu0kwTEzjDBAA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-ipAJGwaNMlScx4YMm01lSw-1; Fri, 23 Jan 2026 08:25:19 -0500 X-MC-Unique: ipAJGwaNMlScx4YMm01lSw-1 X-Mimecast-MFC-AGG-ID: ipAJGwaNMlScx4YMm01lSw_1769174718 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47ee7346f8bso14675795e9.2 for ; Fri, 23 Jan 2026 05:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769174718; x=1769779518; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dl7NlkiIvE4aCaKk0Pre5K+Ti7kNdoTw5jT1Cl5ZZAE=; b=XDNzuahYpZY1+ffEsI1oHQAuNWyG+fSG5E2eetzeTcFaM/ziV/h6mh+hO+4S4YCSg5 v1xP8sZebdOa7ofQ0zKF1VPDK3RlQTItNlCDL+E5dzbcaingiGpUabwcEwb7I+sHP06O yShN7AfLlL+Sy6JJAHKZ4et71hOXtX7ot7Guee+9yCGztrLIoQsvTY9Fyiw47Dmv/IOX fxWrG+UHo+L2UALjv8ftNPVwYjsJEJ5TFK6ThbLtSiKtD2uYOP2WdP8KuUilue+PX+hu G9Lgd0rrUg1SUVBgeRHWrEa4YFsJJm1DJxRZVdjBqYoGdxkmU/AZyOfaEhO/rSMtkvMK gh8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769174718; x=1769779518; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dl7NlkiIvE4aCaKk0Pre5K+Ti7kNdoTw5jT1Cl5ZZAE=; b=BuPP/N6MMmbsdMRAbQ1zXRRkCmXldCC1VcMMdnITW8ZK4mXftNyOGqd2G5Z08s5l5O VICTCEOPm9EpVaQDkLALvkrQe4XXlQHp3jC4CTXCcMl1Uo1ui+KFgUu3tj0so/6KyU+k z2hTvqWxmDf5qFZZrRu80Q1fwGeryGwPPtNmKFK/rz78vQQ1iF9IDwfjtuzIrHSslNP7 hSeLmE1vGdzfr0I0Ck0b2Xe1FwrpNmNEA9tx0oVo/5Sp2R9Zwo9LKG0ZsC40H7HKyIsn vQOQHVcwuSkH5uCFk+kkTVIwxI90NMLbdJvcdHQz4sRw6+b5QJfQowyloyw/KY28AdVZ 15WA== X-Forwarded-Encrypted: i=1; AJvYcCXkk1Ra9zhuWGPgij243HEoAPKmWA91pPxQVHVu592fVG41yGLFDcCAg4CMAgOpmbmYNZgh5PEmH3Im@vger.kernel.org X-Gm-Message-State: AOJu0YyZ5Gprde0D1abPOSx1MGUnGmwK5LTogTe54OmNW+gXJFgDKgTm DsmrCk6Ki6OGAF4rUxqagAqYIr6VQ+IXgC+a8A3fI9PeU4LIbU3DLcQ3lcnLq3cR7hat0SmtXFM b7cw9hMpJgTvCm6PUJZezY7EqtnNcS38IxXxWYQJJIDM2oPHzaMB3+EYJSVGHu6E= X-Gm-Gg: AZuq6aJl6EOsPYJB/FEG+tMRVTJUgL/N9qyv6k+y9NAgFxSrHDicofwnTk6SbcDdLrI k2ty7QKjgsxfWc3D+JYZgWTxFwVTGXUXd0qYLBve3rXgi0EMqoKbGc0165V+Eon23UU/MK8LJxc 4aAS5qcZUFijq0MwOTmjefzE61aoOKK5eJYFHMsX0+T4KtErn31Ic5SgHH5e5jakU73txLN+P0B wa9lozTT6h1HrnLNkvSP+0EJ1Sprl62Byzvh+xetqNViaYH8xNaZr/54Pm5frwbOVgliyV3M4RS 5+0Xw+auzOJgSB60PsGNPkxlqyGt35VpF+Oj1sXG1wMPnmaP5eB+I/ybo+amow== X-Received: by 2002:a05:600c:c16b:b0:477:a978:3a7b with SMTP id 5b1f17b1804b1-4804c9b2113mr49821895e9.22.1769174718321; Fri, 23 Jan 2026 05:25:18 -0800 (PST) X-Received: by 2002:a05:600c:c16b:b0:477:a978:3a7b with SMTP id 5b1f17b1804b1-4804c9b2113mr49821235e9.22.1769174717712; Fri, 23 Jan 2026 05:25:17 -0800 (PST) Received: from localhost ([2a01:e0a:b25:f902::ff]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804dbaad79sm21251445e9.9.2026.01.23.05.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 05:25:17 -0800 (PST) Date: Fri, 23 Jan 2026 14:25:16 +0100 From: Maxime Ripard To: Thierry Reding Cc: David Airlie , Simona Vetter , Sumit Semwal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Gaignard , Brian Starkey , John Stultz , "T . J . Mercier" , Andrew Morton , David Hildenbrand , Mike Rapoport , Sumit Garg , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org Subject: Re: [PATCH v2 04/10] mm/cma: Allow dynamically creating CMA areas Message-ID: <20260123-active-witty-rabbit-0fc5b9@houat> References: <20260122161009.3865888-1-thierry.reding@kernel.org> <20260122161009.3865888-5-thierry.reding@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="equ2x5ui66msv4bz" Content-Disposition: inline In-Reply-To: <20260122161009.3865888-5-thierry.reding@kernel.org> --equ2x5ui66msv4bz Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 04/10] mm/cma: Allow dynamically creating CMA areas MIME-Version: 1.0 On Thu, Jan 22, 2026 at 05:10:03PM +0100, Thierry Reding wrote: > From: Thierry Reding >=20 > There is no technical reason why there should be a limited number of CMA > regions, so extract some code into helpers and use them to create extra > functions (cma_create() and cma_free()) that allow creating and freeing, > respectively, CMA regions dynamically at runtime. >=20 > The static array of CMA areas cannot be replaced by dynamically created > areas because for many of them, allocation must not fail and some cases > may need to initialize them before the slab allocator is even available. > To account for this, keep these "early" areas in a separate list and > track the dynamic areas in a separate list. >=20 > Signed-off-by: Thierry Reding AFAIU, this won't create a new cma heap when registering. This goes against the recent work we did to create one for every cma region. I guess, since you have a driver that would explicitly handle that region, we should create some kind of opt-out mechanism, but by default, we should still create such a heap. That being said, it's not clear to me why the heap driver uses CMA in the first place. Maxime --equ2x5ui66msv4bz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaXN2tQAKCRAnX84Zoj2+ dtsNAYD+XKsLdRQjkWGztlo6ccvGIarpCsAjHJYFv0zPbdpfdWvfyLFS1lY/kTQQ 0g9g6Z8Bf0j4St2GiD6RINFxEH7YvowARYnLD4kKLHV0CjY6XFcfRV2lK+cZmof9 IIFG/01OiA== =as/Q -----END PGP SIGNATURE----- --equ2x5ui66msv4bz--