Re: [PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]

On Sun, Jan 25, 2026 at 03:19:03PM +0200, Svyatoslav Ryhel wrote:
> Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> panel vendor and model are unknown hence generic compatible is used based
> on board name it is used with.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../display/panel/motorola,mot-panel.yaml     | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> new file mode 100644
> index 000000000000..2326a83bc405
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/motorola,mot-panel.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atrix 4G and Droid X2 DSI Display Panel
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@gmail.com>
> +
> +description:
> +  Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> +  panel vendor and model are unknown hence generic compatible is used.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: motorola,mot-panel

What's a "mot" panel? If that's short for motorola, wouldn't it be
better to conjure up something at least more specific to these
particular users? The commit message has some info, but I still dunno
where "mot" comes from.
Seems okay otherwise..

> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator for main power supply.
> +
> +  vddio-supply:
> +    description: Regulator for 1.8V IO power supply.
> +
> +  backlight: true
> +  reset-gpios: true
> +  port: true
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "motorola,mot-panel";
> +            reg = <0>;
> +
> +            reset-gpios = <&gpio 35 GPIO_ACTIVE_LOW>;
> +
> +            vdd-supply = <&vdd_5v0_panel>;
> +            vddio-supply = <&vdd_1v8_vio>;
> +
> +            backlight = <&backlight>;
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&dsi_out>;
> +                };
> +            };
> +        };
> +    };
> +...
> -- 
> 2.51.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]