* [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl @ 2026-01-27 10:55 Mohammad Rafi Shaik 2026-01-27 12:19 ` Rob Herring (Arm) 2026-01-27 14:17 ` Rob Herring 0 siblings, 2 replies; 6+ messages in thread From: Mohammad Rafi Shaik @ 2026-01-27 10:55 UTC (permalink / raw) To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM pin controller, fully compatible with previous SM8450 generation (same amount of pins and functions). Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> --- changes in [v3]: - Removed the duplicate driver code patch as suggested by Krzysztof. - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ changes in [v2]: - Fixed dt-binding errors reported by Krzysztof and Rob. - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. - Documented Monaco compatible as suggested by Konrad. - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ --- .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml index e7565592d..354629c38 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml @@ -15,7 +15,15 @@ description: properties: compatible: - const: qcom,sm8450-lpass-lpi-pinctrl + oneOf: + - const: qcom,sm8450-lpass-lpi-pinctrl + - items: + - enum: + - qcom,qcs8300-lpass-lpi-pinctrl + - qcom,sa8775p-lpass-lpi-pinctrl + - const: qcom,sm8450-lpass-lpi-pinctrl + minItems: 1 + maxItems: 2 reg: items: -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl 2026-01-27 10:55 [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl Mohammad Rafi Shaik @ 2026-01-27 12:19 ` Rob Herring (Arm) 2026-01-27 14:17 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring (Arm) @ 2026-01-27 12:19 UTC (permalink / raw) To: Mohammad Rafi Shaik Cc: devicetree, Bjorn Andersson, linux-gpio, Conor Dooley, Krzysztof Kozlowski, linux-kernel, linux-arm-msm, Linus Walleij, Srinivas Kandagatla On Tue, 27 Jan 2026 16:25:11 +0530, Mohammad Rafi Shaik wrote: > Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM > pin controller, fully compatible with previous SM8450 generation > (same amount of pins and functions). > > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> > --- > changes in [v3]: > - Removed the duplicate driver code patch as suggested by Krzysztof. > - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. > - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ > > changes in [v2]: > - Fixed dt-binding errors reported by Krzysztof and Rob. > - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. > - Documented Monaco compatible as suggested by Konrad. > - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ > --- > .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml: properties:compatible:oneOf:1: {'items': [{'enum': ['qcom,qcs8300-lpass-lpi-pinctrl', 'qcom,sa8775p-lpass-lpi-pinctrl']}, {'const': 'qcom,sm8450-lpass-lpi-pinctrl'}], 'minItems': 1, 'maxItems': 2} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml: properties:compatible:oneOf:1: {'items': [{'enum': ['qcom,qcs8300-lpass-lpi-pinctrl', 'qcom,sa8775p-lpass-lpi-pinctrl']}, {'const': 'qcom,sm8450-lpass-lpi-pinctrl'}], 'minItems': 1, 'maxItems': 2} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260127105511.3917491-1-mohammad.rafi.shaik@oss.qualcomm.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl 2026-01-27 10:55 [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl Mohammad Rafi Shaik 2026-01-27 12:19 ` Rob Herring (Arm) @ 2026-01-27 14:17 ` Rob Herring 2026-01-27 18:13 ` Mohammad Rafi Shaik 1 sibling, 1 reply; 6+ messages in thread From: Rob Herring @ 2026-01-27 14:17 UTC (permalink / raw) To: Mohammad Rafi Shaik Cc: Bjorn Andersson, Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, linux-arm-msm, linux-gpio, devicetree, linux-kernel On Tue, Jan 27, 2026 at 04:25:11PM +0530, Mohammad Rafi Shaik wrote: > Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM > pin controller, fully compatible with previous SM8450 generation > (same amount of pins and functions). > > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> > --- > changes in [v3]: > - Removed the duplicate driver code patch as suggested by Krzysztof. > - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. > - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ > > changes in [v2]: > - Fixed dt-binding errors reported by Krzysztof and Rob. > - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. > - Documented Monaco compatible as suggested by Konrad. > - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ > --- > .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml > index e7565592d..354629c38 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml > @@ -15,7 +15,15 @@ description: > > properties: > compatible: > - const: qcom,sm8450-lpass-lpi-pinctrl > + oneOf: > + - const: qcom,sm8450-lpass-lpi-pinctrl > + - items: > + - enum: > + - qcom,qcs8300-lpass-lpi-pinctrl > + - qcom,sa8775p-lpass-lpi-pinctrl > + - const: qcom,sm8450-lpass-lpi-pinctrl > + minItems: 1 > + maxItems: 2 No. You are either backwards compatible with sm8450 or you aren't. The h/w is fixed. Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl 2026-01-27 14:17 ` Rob Herring @ 2026-01-27 18:13 ` Mohammad Rafi Shaik 2026-01-27 18:27 ` Rob Herring 0 siblings, 1 reply; 6+ messages in thread From: Mohammad Rafi Shaik @ 2026-01-27 18:13 UTC (permalink / raw) To: Rob Herring Cc: Bjorn Andersson, Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, linux-arm-msm, linux-gpio, devicetree, linux-kernel On 1/27/2026 7:47 PM, Rob Herring wrote: > On Tue, Jan 27, 2026 at 04:25:11PM +0530, Mohammad Rafi Shaik wrote: >> Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM >> pin controller, fully compatible with previous SM8450 generation >> (same amount of pins and functions). >> >> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> >> --- >> changes in [v3]: >> - Removed the duplicate driver code patch as suggested by Krzysztof. >> - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. >> - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ >> >> changes in [v2]: >> - Fixed dt-binding errors reported by Krzysztof and Rob. >> - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. >> - Documented Monaco compatible as suggested by Konrad. >> - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ >> --- >> .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >> index e7565592d..354629c38 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >> @@ -15,7 +15,15 @@ description: >> >> properties: >> compatible: >> - const: qcom,sm8450-lpass-lpi-pinctrl >> + oneOf: >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + - items: >> + - enum: >> + - qcom,qcs8300-lpass-lpi-pinctrl >> + - qcom,sa8775p-lpass-lpi-pinctrl >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + minItems: 1 >> + maxItems: 2 > > No. You are either backwards compatible with sm8450 or you aren't. The > h/w is fixed. > ACK, Agree, Need backward compatibility with sm8450 for both sa8775p and qcs8300 as they must fall back to the sm8450, so initially used enum to pick between the sa8775p and qcs8300 compatibles. I see enum isn’t appropriate here since fixed h/w. will use the const instead of enum like below. properties: compatible: - const: qcom,sm8450-lpass-lpi-pinctrl + oneOf: + - const: qcom,sm8450-lpass-lpi-pinctrl + - items: + - const: qcom,sa8775p-lpass-lpi-pinctrl + - const: qcom,sm8450-lpass-lpi-pinctrl + + - items: + - const: qcom,qcs8300-lpass-lpi-pinctrl + - const: qcom,sm8450-lpass-lpi-pinctrl Thanks & Regards, Rafi > Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl 2026-01-27 18:13 ` Mohammad Rafi Shaik @ 2026-01-27 18:27 ` Rob Herring 2026-01-29 10:33 ` Mohammad Rafi Shaik 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2026-01-27 18:27 UTC (permalink / raw) To: Mohammad Rafi Shaik Cc: Bjorn Andersson, Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, linux-arm-msm, linux-gpio, devicetree, linux-kernel On Tue, Jan 27, 2026 at 12:13 PM Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> wrote: > > > > On 1/27/2026 7:47 PM, Rob Herring wrote: > > On Tue, Jan 27, 2026 at 04:25:11PM +0530, Mohammad Rafi Shaik wrote: > >> Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM > >> pin controller, fully compatible with previous SM8450 generation > >> (same amount of pins and functions). > >> > >> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> > >> --- > >> changes in [v3]: > >> - Removed the duplicate driver code patch as suggested by Krzysztof. > >> - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. > >> - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ > >> > >> changes in [v2]: > >> - Fixed dt-binding errors reported by Krzysztof and Rob. > >> - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. > >> - Documented Monaco compatible as suggested by Konrad. > >> - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ > >> --- > >> .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- > >> 1 file changed, 9 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml > >> index e7565592d..354629c38 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml > >> @@ -15,7 +15,15 @@ description: > >> > >> properties: > >> compatible: > >> - const: qcom,sm8450-lpass-lpi-pinctrl > >> + oneOf: > >> + - const: qcom,sm8450-lpass-lpi-pinctrl > >> + - items: > >> + - enum: > >> + - qcom,qcs8300-lpass-lpi-pinctrl > >> + - qcom,sa8775p-lpass-lpi-pinctrl > >> + - const: qcom,sm8450-lpass-lpi-pinctrl > >> + minItems: 1 > >> + maxItems: 2 > > > > No. You are either backwards compatible with sm8450 or you aren't. The > > h/w is fixed. > > > > ACK, > > Agree, > > Need backward compatibility with sm8450 for both sa8775p and qcs8300 as > they must fall back to the sm8450, so initially used enum to pick > between the sa8775p and qcs8300 compatibles. I see enum isn’t > appropriate here since fixed h/w. > > will use the const instead of enum like below. > > properties: > compatible: > - const: qcom,sm8450-lpass-lpi-pinctrl > + oneOf: > + - const: qcom,sm8450-lpass-lpi-pinctrl > + - items: > + - const: qcom,sa8775p-lpass-lpi-pinctrl > + - const: qcom,sm8450-lpass-lpi-pinctrl > + > + - items: > + - const: qcom,qcs8300-lpass-lpi-pinctrl > + - const: qcom,sm8450-lpass-lpi-pinctrl Sigh, no. The 2 entries can be combined like you had. Just drop minItems and maxItems from what you had. And test your binding before sending it. Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl 2026-01-27 18:27 ` Rob Herring @ 2026-01-29 10:33 ` Mohammad Rafi Shaik 0 siblings, 0 replies; 6+ messages in thread From: Mohammad Rafi Shaik @ 2026-01-29 10:33 UTC (permalink / raw) To: Rob Herring Cc: Bjorn Andersson, Linus Walleij, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, linux-arm-msm, linux-gpio, devicetree, linux-kernel On 1/27/2026 11:57 PM, Rob Herring wrote: > On Tue, Jan 27, 2026 at 12:13 PM Mohammad Rafi Shaik > <mohammad.rafi.shaik@oss.qualcomm.com> wrote: >> >> >> >> On 1/27/2026 7:47 PM, Rob Herring wrote: >>> On Tue, Jan 27, 2026 at 04:25:11PM +0530, Mohammad Rafi Shaik wrote: >>>> Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM >>>> pin controller, fully compatible with previous SM8450 generation >>>> (same amount of pins and functions). >>>> >>>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> >>>> --- >>>> changes in [v3]: >>>> - Removed the duplicate driver code patch as suggested by Krzysztof. >>>> - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. >>>> - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ >>>> >>>> changes in [v2]: >>>> - Fixed dt-binding errors reported by Krzysztof and Rob. >>>> - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. >>>> - Documented Monaco compatible as suggested by Konrad. >>>> - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ >>>> --- >>>> .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- >>>> 1 file changed, 9 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >>>> index e7565592d..354629c38 100644 >>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >>>> @@ -15,7 +15,15 @@ description: >>>> >>>> properties: >>>> compatible: >>>> - const: qcom,sm8450-lpass-lpi-pinctrl >>>> + oneOf: >>>> + - const: qcom,sm8450-lpass-lpi-pinctrl >>>> + - items: >>>> + - enum: >>>> + - qcom,qcs8300-lpass-lpi-pinctrl >>>> + - qcom,sa8775p-lpass-lpi-pinctrl >>>> + - const: qcom,sm8450-lpass-lpi-pinctrl >>>> + minItems: 1 >>>> + maxItems: 2 >>> >>> No. You are either backwards compatible with sm8450 or you aren't. The >>> h/w is fixed. >>> >> >> ACK, >> >> Agree, >> >> Need backward compatibility with sm8450 for both sa8775p and qcs8300 as >> they must fall back to the sm8450, so initially used enum to pick >> between the sa8775p and qcs8300 compatibles. I see enum isn’t >> appropriate here since fixed h/w. >> >> will use the const instead of enum like below. >> >> properties: >> compatible: >> - const: qcom,sm8450-lpass-lpi-pinctrl >> + oneOf: >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + - items: >> + - const: qcom,sa8775p-lpass-lpi-pinctrl >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + >> + - items: >> + - const: qcom,qcs8300-lpass-lpi-pinctrl >> + - const: qcom,sm8450-lpass-lpi-pinctrl > > Sigh, no. The 2 entries can be combined like you had. Just drop > minItems and maxItems from what you had. > > And test your binding before sending it. > Sure, I’ll take care of it going forward Thanks & Regarding, Rafi. > Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-29 10:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-27 10:55 [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl Mohammad Rafi Shaik 2026-01-27 12:19 ` Rob Herring (Arm) 2026-01-27 14:17 ` Rob Herring 2026-01-27 18:13 ` Mohammad Rafi Shaik 2026-01-27 18:27 ` Rob Herring 2026-01-29 10:33 ` Mohammad Rafi Shaik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox