From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0545F34A3A5;
	Thu, 29 Jan 2026 17:49:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1769708984; cv=none; b=uM8PbhtuUW8Mc5bNMdImI4vZgdwGwwSRumirhUuJlRU5JFdvTlzkQnsHENWd0Z2Ru/tDXAOlYzTovXWFNnjW26DshXR3pnOt8ybUrdT4xjWBF5XULU8mmb5jSYCV6wo1IeBiujKAGej6EWF1KqKH/Uym+3DCL9OItCBPFOxdEeE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1769708984; c=relaxed/simple;
	bh=gEHvadmzl4LEDFhKtaFmMTseScHIiexCv2jMG2q2OBA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=MgQbYEyFqqiJbqRCWC3p8b8hSj8zxOvzVgpI62EMlCo6pzHtJhpU94Te9JVne30u5owCMap33xpWvSr05Rg0NN6i17/FVJglRWkzAcKCHhEHZHciv0ppMPuX3SsjHHueYL7gCfTjME4yXrlqGJRFuWdnY/64q1zN+yLP2UsllG4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KZdSWXS7; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KZdSWXS7"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60BD3C4CEF7;
	Thu, 29 Jan 2026 17:49:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1769708983;
	bh=gEHvadmzl4LEDFhKtaFmMTseScHIiexCv2jMG2q2OBA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=KZdSWXS79SpaW+Gx+Je1m1wWbFwi1Ifrw3myZZMUv0w4uZ/KNDO0+HStzBlUv8oUB
	 Lg5us3Bnyd3curqQlOdE57irw++J9A/xAjACuEkAtX37oEkoCqlL7KLRaVdEeTF9E8
	 09ESqfTtShYPqL1OPt4VD7uXjl3ElXPg9Zo84wT8xKvXPeJ2L6oY9O49qOxAdH7uMp
	 EnlXSpVGQIGmhh4sEj0kHiMxS82jPDCcKeFPkh5U+OJ0xRBlgSkjv7xHDfjkzlDkVE
	 xIZELpAAHN1jEWSASTnUINVrMekJh7x9KAJfgapEA0wkPVmsdqRpsnUyMujhoiIkeh
	 RbZud8PwK+zEQ==
Date: Thu, 29 Jan 2026 11:49:42 -0600
From: Rob Herring <robh@kernel.org>
To: Saikiran <bjsaikiran@gmail.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, andersson@kernel.org,
	konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: regulator: qcom,rpmh: Allow
 regulator-off-on-delay-us
Message-ID: <20260129174829.GA1324020-robh@kernel.org>
References: <20260127190211.14312-1-bjsaikiran@gmail.com>
 <20260127190211.14312-2-bjsaikiran@gmail.com>
Precedence: bulk
X-Mailing-List: devicetree@vger.kernel.org
List-Id: <devicetree.vger.kernel.org>
List-Subscribe: <mailto:devicetree+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:devicetree+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260127190211.14312-2-bjsaikiran@gmail.com>

On Wed, Jan 28, 2026 at 12:32:10AM +0530, Saikiran wrote:
> Add the standard 'regulator-off-on-delay-us' property to the list of
> allowed properties for RPMh regulators.

You almost fooled me, but 'regulator-off-on-delay-us' is not a standard 
property.

> 
> This property is required for platforms where specific rails (like camera
> LDOs) rely on passive discharge and need a mandatory off-time constraint
> enforced by the regulator core.

Does enforcing some off time on all your regulators cause some negative 
impact on the ones that don't need it? If turning them back on is 
performance critical maybe don't turn them off in the first place.

> 
> Signed-off-by: Saikiran <bjsaikiran@gmail.com>
> ---
>  .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml    | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> index 58bb0ad5dda4..b02311263191 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> @@ -131,6 +131,8 @@ properties:
>      $ref: regulator.yaml#
>      unevaluatedProperties: false
>      description: BOB regulator node.
> +    properties:
> +      regulator-off-on-delay-us: true
>      dependencies:
>        regulator-allow-set-load: [ regulator-allowed-modes ]
>  
> @@ -140,6 +142,8 @@ patternProperties:
>      $ref: regulator.yaml#
>      unevaluatedProperties: false
>      description: smps/ldo regulator nodes(s).
> +    properties:
> +      regulator-off-on-delay-us: true
>      dependencies:
>        regulator-allow-set-load: [ regulator-allowed-modes ]
>  
> -- 
> 2.51.0
>