Re: [PATCH v2 1/8] thermal: Add Remote Proc cooling driver

[kernel test robot <lkp@intel.com>]

Hi Gaurav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20260126]
[also build test WARNING on v6.19-rc7]
[cannot apply to robh/for-next rafael-pm/thermal remoteproc/rproc-next linus/master v6.19-rc7 v6.19-rc6 v6.19-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gaurav-Kohli/thermal-Add-Remote-Proc-cooling-driver/20260128-000753
base:   next-20260126
patch link:    https://lore.kernel.org/r/20260127155722.2797783-2-gaurav.kohli%40oss.qualcomm.com
patch subject: [PATCH v2 1/8] thermal: Add Remote Proc cooling driver
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20260130/202601301354.3ERTn2SC-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260130/202601301354.3ERTn2SC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601301354.3ERTn2SC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/thermal/remoteproc_cooling.c:87:1: warning: no previous prototype for 'remoteproc_cooling_register' [-Wmissing-prototypes]
      87 | remoteproc_cooling_register(struct device_node *np,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/remoteproc_cooling.c:131:6: warning: no previous prototype for 'remoteproc_cooling_unregister' [-Wmissing-prototypes]
     131 | void remoteproc_cooling_unregister(struct remoteproc_cdev *rproc_cdev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/remoteproc_cooling_register +87 drivers/thermal/remoteproc_cooling.c

    85	
    86	struct remoteproc_cdev *
  > 87	remoteproc_cooling_register(struct device_node *np,
    88				    const char *name, const struct remoteproc_cooling_ops *ops,
    89				     void *devdata)
    90	{
    91		struct remoteproc_cdev *rproc_cdev;
    92		struct thermal_cooling_device *cdev;
    93		int ret;
    94	
    95		if (!name || !ops)
    96			return ERR_PTR(-EINVAL);
    97	
    98		rproc_cdev = kzalloc(sizeof(*rproc_cdev), GFP_KERNEL);
    99		if (!rproc_cdev)
   100			return ERR_PTR(-ENOMEM);
   101	
   102		rproc_cdev->ops = ops;
   103		rproc_cdev->devdata = devdata;
   104		mutex_init(&rproc_cdev->lock);
   105	
   106		char *rproc_name __free(kfree) =
   107			kasprintf(GFP_KERNEL, REMOTEPROC_PREFIX "%s", name);
   108		/* Register with thermal framework */
   109		if (np)
   110			cdev = thermal_of_cooling_device_register(np, rproc_name, rproc_cdev,
   111								  &remoteproc_cooling_ops);
   112		else
   113			cdev = thermal_cooling_device_register(rproc_name, rproc_cdev,
   114							       &remoteproc_cooling_ops);
   115	
   116		if (IS_ERR(cdev)) {
   117			ret = PTR_ERR(cdev);
   118			goto free_rproc_cdev;
   119		}
   120	
   121		rproc_cdev->cdev = cdev;
   122	
   123		return rproc_cdev;
   124	
   125	free_rproc_cdev:
   126		kfree(rproc_cdev);
   127		return ERR_PTR(ret);
   128	}
   129	EXPORT_SYMBOL_GPL(remoteproc_cooling_register);
   130	
 > 131	void remoteproc_cooling_unregister(struct remoteproc_cdev *rproc_cdev)
   132	{
   133		if (!rproc_cdev)
   134			return;
   135	
   136		thermal_cooling_device_unregister(rproc_cdev->cdev);
   137		mutex_destroy(&rproc_cdev->lock);
   138		kfree(rproc_cdev);
   139	}
   140	EXPORT_SYMBOL_GPL(remoteproc_cooling_unregister);
   141	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki