Re: [PATCH v2 4/8] thermal: qcom: add qmi-cooling driver

[kernel test robot <lkp@intel.com>]

Hi Gaurav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20260126]
[also build test WARNING on v6.19-rc7]
[cannot apply to robh/for-next rafael-pm/thermal remoteproc/rproc-next linus/master v6.19-rc7 v6.19-rc6 v6.19-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gaurav-Kohli/thermal-Add-Remote-Proc-cooling-driver/20260128-000753
base:   next-20260126
patch link:    https://lore.kernel.org/r/20260127155722.2797783-5-gaurav.kohli%40oss.qualcomm.com
patch subject: [PATCH v2 4/8] thermal: qcom: add qmi-cooling driver
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20260130/202601301640.GVrYk2iB-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260130/202601301640.GVrYk2iB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601301640.GVrYk2iB-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/soc/qcom/qmi-cooling.c: In function 'qmi_tmd_alloc_cdevs':
>> drivers/soc/qcom/qmi-cooling.c:377:29: warning: unused variable 'subnode' [-Wunused-variable]
     377 |         struct device_node *subnode;
         |                             ^~~~~~~
   In file included from drivers/soc/qcom/qmi-cooling.c:24:
   drivers/soc/qcom/qmi-cooling.h: At top level:
>> drivers/soc/qcom/qmi-cooling.h:402:35: warning: 'tmd_mitigation_level_report_ind_msg_v01_ei' defined but not used [-Wunused-const-variable=]
     402 | static const struct qmi_elem_info tmd_mitigation_level_report_ind_msg_v01_ei[] = {
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qmi-cooling.h:377:9: warning: 'tmd_deregister_notification_mitigation_level_resp_msg_v01_ei' defined but not used [-Wunused-const-variable=]
     377 |         tmd_deregister_notification_mitigation_level_resp_msg_v01_ei[] = {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qmi-cooling.h:352:9: warning: 'tmd_deregister_notification_mitigation_level_req_msg_v01_ei' defined but not used [-Wunused-const-variable=]
     352 |         tmd_deregister_notification_mitigation_level_req_msg_v01_ei[] = {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qmi-cooling.h:327:9: warning: 'tmd_register_notification_mitigation_level_resp_msg_v01_ei' defined but not used [-Wunused-const-variable=]
     327 |         tmd_register_notification_mitigation_level_resp_msg_v01_ei[] = {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qmi-cooling.h:302:9: warning: 'tmd_register_notification_mitigation_level_req_msg_v01_ei' defined but not used [-Wunused-const-variable=]
     302 |         tmd_register_notification_mitigation_level_req_msg_v01_ei[] = {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qmi-cooling.h:243:35: warning: 'tmd_get_mitigation_level_resp_msg_ei' defined but not used [-Wunused-const-variable=]
     243 | static const struct qmi_elem_info tmd_get_mitigation_level_resp_msg_ei[] = {
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qmi-cooling.h:216:35: warning: 'tmd_get_mitigation_level_req_msg_v01_ei' defined but not used [-Wunused-const-variable=]
     216 | static const struct qmi_elem_info tmd_get_mitigation_level_req_msg_v01_ei[] = {
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
>> Warning: drivers/soc/qcom/qmi-cooling.c:72 struct member 'node' not described in 'qmi_tmd'
>> Warning: drivers/soc/qcom/qmi-cooling.c:82 expecting prototype for struct qmi_instance_id. Prototype was for struct qmi_instance_data instead
--
>> Warning: drivers/soc/qcom/qmi-cooling.c:72 struct member 'node' not described in 'qmi_tmd'


vim +/subnode +377 drivers/soc/qcom/qmi-cooling.c

   371	
   372	/* Parse the controls and allocate a qmi_tmd for each of them */
   373	static int qmi_tmd_alloc_cdevs(struct qmi_tmd_client *client)
   374	{
   375		struct device *dev = client->dev;
   376		struct device_node *node = dev->of_node;
 > 377		struct device_node *subnode;
   378		struct qmi_tmd *tmd;
   379		int ret;
   380	
   381		for_each_available_child_of_node_scoped(node, subnode) {
   382			const char *name;
   383	
   384			tmd = devm_kzalloc(dev, sizeof(*tmd), GFP_KERNEL);
   385			if (!tmd)
   386				return dev_err_probe(client->dev, -ENOMEM,
   387						     "Couldn't allocate tmd\n");
   388	
   389			tmd->type = devm_kasprintf(client->dev, GFP_KERNEL, "%s",
   390						   subnode->name);
   391			if (!tmd->type)
   392				return dev_err_probe(dev, -ENOMEM,
   393						     "Couldn't allocate cooling device name\n");
   394	
   395			if (of_property_read_string(subnode, "label", &name))
   396				return dev_err_probe(client->dev, -EINVAL,
   397						     "Failed to parse dev name for %s\n",
   398						     subnode->name);
   399	
   400			ret = strscpy(tmd->qmi_name, name,
   401				      QMI_TMD_MITIGATION_DEV_ID_LENGTH_MAX_V01 + 1);
   402			if (ret == -E2BIG)
   403				return dev_err_probe(dev, -EINVAL, "TMD label %s is too long\n",
   404						     name);
   405	
   406			tmd->client = client;
   407			tmd->np = subnode;
   408			tmd->cur_state = 0;
   409			list_add(&tmd->node, &client->cdev_list);
   410		}
   411	
   412		if (list_empty(&client->cdev_list))
   413			return dev_err_probe(client->dev, -EINVAL,
   414					     "No cooling devices specified for client %s (%#x)\n",
   415					     client->name, client->id);
   416	
   417		return 0;
   418	}
   419	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki