public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Mithil Bavishi <bavishimithil@gmail.com>
To: andreas@kemnade.info
Cc: aaro.koskinen@iki.fi, airlied@gmail.com, bavishimithil@gmail.com,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, jernej.skrabec@gmail.com,
	jonas@kwiboo.se, khilman@baylibre.com, krzk+dt@kernel.org,
	laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, neil.armstrong@linaro.org, rfoss@kernel.org,
	robh@kernel.org, rogerq@kernel.org, simona@ffwll.ch,
	thierry.reding@gmail.com, tony@atomide.com, tzimmermann@suse.de
Subject: Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series
Date: Wed,  4 Feb 2026 02:48:31 -0500	[thread overview]
Message-ID: <20260204074831.300311-1-bavishimithil@gmail.com> (raw)
In-Reply-To: <20260202090408.4c3757cb@kemnade.info>

> We had the discussion. This should be done via pinctrl irq if possible instead of
> specifying WAKEUP_EN here, You had some trouble to understand how it can be done,
> and we agreed to add the wakeup functionality as a follow-up concentrating just
> on that detail and for now just remove WAKEUP_EN.

I think I may have understood what is to be done.
For example we have 
pinctrl-single,pins = <
	OMAP4_IOPAD(0x0bc, WAKEUP_EN | PIN_INPUT | MUX_MODE3)
>;

for wlan_host_wake, so the change needed to be done is from
interrupt-parent = <&gpio3>;
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "host-wake";
pinctrl-names = "default";
pinctrl-0 = <&wlan_host_wake>;

to

interrupts-extended = <&gpio3 17 IRQ_TYPE_LEVEL_HIGH>, 
			<&omap4_pmx_core 0x0bc>;
interrupt-names = "host-wake", "wakeup";

and remove the pinctrl?
Similarly for all in the omap4_pmx_core domain (wifi, bt, i2c as the
drivers support it)
No chnages for &omap4_pmx_wkup domain

  parent reply	other threads:[~2026-02-04  7:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29  5:47 [PATCH v5 0/8] Initial support for Samsung Galaxy Tab 2 series Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 1/8] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 2/8] dt-bindings: vendor-prefixes: Add Doestek Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 3/8] dt-bindings: display: bridge: lvds-codec: add doestek,dtc34lm85am Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 4/8] dt-bindings: display: panel-lvds: Add compatibles for Samsung LTN070NL01 and LTN101AL03 panels Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series Mithil Bavishi
2026-02-02  8:04   ` Andreas Kemnade
2026-02-04  0:09     ` Mithil Bavishi
2026-02-04  7:48     ` Mithil Bavishi [this message]
2026-02-04  9:07       ` Andreas Kemnade
2026-01-29  5:47 ` [PATCH v5 6/8] dt-bindings: omap: Add Samsung Galaxy Tab 2 7.0 and 10.1 Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 7/8] ARM: dts: ti: omap: samsung-espresso7: Add initial support for Galaxy Tab 2 7.0 Mithil Bavishi
2026-01-29  5:47 ` [PATCH v5 8/8] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1 Mithil Bavishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204074831.300311-1-bavishimithil@gmail.com \
    --to=bavishimithil@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=airlied@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox