From: Nathan Chancellor <nathan@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Icenowy Zheng <uwu@icenowy.me>, Nicolas Schier <nsc@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Mingcong Bai <jeffbai@aosc.io>,
WangYuli <wangyuli@uniontech.com>,
Inochi Amaoto <inochiama@gmail.com>,
James Le Cuirot <chewi@gentoo.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Rong Zhang <i@rong.moe>, Saravana Kannan <saravanak@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] kbuild: install-extmod-build: do not exclude scripts/dtc/libfdt/
Date: Wed, 4 Feb 2026 11:13:56 -0700 [thread overview]
Message-ID: <20260204181356.GA2132823@ax162> (raw)
In-Reply-To: <CAL_JsqJdS77S8VD-smpBi_mSZ6s3C66mvh5OCzQNhWMTyvjp-w@mail.gmail.com>
On Wed, Feb 04, 2026 at 07:31:57AM -0600, Rob Herring wrote:
> On Wed, Feb 4, 2026 at 2:45 AM Nathan Chancellor <nathan@kernel.org> wrote:
> > Ah, thanks for that information. Moving the libfdt.h bits out of
> > bootinfo.h does not seem like it would be too difficult but I am less
> > sure about asm/machine.h. Alternatively, maybe this could be avoided by
> > separating out what you would need from bootinfo.h into its own header
> > but I did not look too hard.
>
> There shouldn't be that many locations using libfdt functions. Add the
> header where it is used. IWYU
>
> > As for a solution within install-extmod-build, maybe the libfdt headers
> > could be included so that inadvertent inclusions of libfdt.h do not
> > break the build but the link fails if the module actually tries to use
> > any libfdt functions?
>
> You do this and then we get to keep the work-around forever as no one
> will care. MIPS is a mess that needs to be cleaned up.
Yeah, that is a valid perspective, I won't push that further. Thanks for
chiming in.
Cheers,
Nathan
next prev parent reply other threads:[~2026-02-04 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260201130259.2906768-1-zhengxingda@iscas.ac.cn>
2026-02-04 2:16 ` [PATCH] kbuild: install-extmod-build: do not exclude scripts/dtc/libfdt/ Nathan Chancellor
2026-02-04 2:56 ` Rob Herring
2026-02-04 3:26 ` Icenowy Zheng
2026-02-04 3:27 ` Icenowy Zheng
2026-02-04 8:45 ` Nathan Chancellor
2026-02-04 8:46 ` Nathan Chancellor
2026-02-04 13:31 ` Rob Herring
2026-02-04 18:13 ` Nathan Chancellor [this message]
2026-02-05 8:22 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204181356.GA2132823@ax162 \
--to=nathan@kernel.org \
--cc=abelvesa@kernel.org \
--cc=chewi@gentoo.org \
--cc=devicetree@vger.kernel.org \
--cc=i@rong.moe \
--cc=inochiama@gmail.com \
--cc=jeffbai@aosc.io \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nsc@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=uwu@icenowy.me \
--cc=wangyuli@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox