From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C3427A465; Wed, 4 Feb 2026 18:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770228843; cv=none; b=ejzYG7lkySlgQT7XxG1YhqPD2VByuakuj8rAR0o2BeWB34IeVL/LHlrilokuDyKFa6v5oyQbmtgrWsXbH/ZJEn5iynm4a1KlqP29E5VhU40dVGjGbrID8LosqOBYhQv7SGVZ9SxmQEWpy4E72DRdFgl+cr4roT5NwGOIAoheO4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770228843; c=relaxed/simple; bh=OJAn/nk18U9lt++VS0HtzdboxZ3Dns6CqLdxWvpKzb4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zc9rp2HIIzBa5RQ2kcehW1RxifeRZ5/xOhrjS5lYqTM1F/r4uyEEMbxeIyW4gS6QIKPDGPCIAgQmhPdWH6hhrYOvfjv0aaBfEevQ7KqQbqRp2hlvnzHQu94nopPmR3uPdgC0O8I0u/vykZt6d0XwfyWjVM20BdeK1VzKCYGbAIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CVT9/HVE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CVT9/HVE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7BC5C4CEF7; Wed, 4 Feb 2026 18:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770228842; bh=OJAn/nk18U9lt++VS0HtzdboxZ3Dns6CqLdxWvpKzb4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CVT9/HVExBrZUevY2tvXU4LY1HfBuAmdORSGIBlCSpcZP6Y8BzJx5ol0yrGmzIY1u OYA1vOpbmSlxcD/P6zGDrkX9JUCR7FuEjeM5CvYkF2hb4kdyvsEGIgkUqok+oF11hM 8t6mZq8msr6A8zvMcowoBt926PsAfTdWz22H8P5TuYZqbi3WY7qj/vEVDLL5T6+NBn WDpAv1W3u9XStIOxzDmr5tqGbEAc4Dn9dSRNkwloRU6F5xc5pHaqFvk0Uab1ysrS+9 eivzZdY/UqdKfPeIZYs3Fr3rrm8aTytwS8QKLuHejCsUN2fWWUwnKaaiwvuW53sdgs CPvIas4RnRy6Q== Date: Wed, 4 Feb 2026 11:13:56 -0700 From: Nathan Chancellor To: Rob Herring Cc: Icenowy Zheng , Nicolas Schier , Masahiro Yamada , Abel Vesa , Mingcong Bai , WangYuli , Inochi Amaoto , James Le Cuirot , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Rong Zhang , Saravana Kannan , devicetree@vger.kernel.org Subject: Re: [PATCH] kbuild: install-extmod-build: do not exclude scripts/dtc/libfdt/ Message-ID: <20260204181356.GA2132823@ax162> References: <20260201130259.2906768-1-zhengxingda@iscas.ac.cn> <20260204021603.GA2646832@ax162> <20260204084517.GA3900164@ax162> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 04, 2026 at 07:31:57AM -0600, Rob Herring wrote: > On Wed, Feb 4, 2026 at 2:45 AM Nathan Chancellor wrote: > > Ah, thanks for that information. Moving the libfdt.h bits out of > > bootinfo.h does not seem like it would be too difficult but I am less > > sure about asm/machine.h. Alternatively, maybe this could be avoided by > > separating out what you would need from bootinfo.h into its own header > > but I did not look too hard. > > There shouldn't be that many locations using libfdt functions. Add the > header where it is used. IWYU > > > As for a solution within install-extmod-build, maybe the libfdt headers > > could be included so that inadvertent inclusions of libfdt.h do not > > break the build but the link fails if the module actually tries to use > > any libfdt functions? > > You do this and then we get to keep the work-around forever as no one > will care. MIPS is a mess that needs to be cleaned up. Yeah, that is a valid perspective, I won't push that further. Thanks for chiming in. Cheers, Nathan