Devicetree
 help / color / mirror / Atom feed
From: Jun Yan <jerrysteve1101@gmail.com>
To: conor@kernel.org
Cc: devicetree@vger.kernel.org, hns@goldelico.com,
	jerrysteve1101@gmail.com, jic23@kernel.org, linusw@kernel.org,
	linux-iio@vger.kernel.org, stephan@gerhold.net
Subject: Re: [PATCH v3 2/3] dt-bindings: iio: magnetometer: bosch,bmc150_magn: add bmx055 magnetometer binding
Date: Thu,  5 Feb 2026 22:31:16 +0800	[thread overview]
Message-ID: <20260205143116.521460-1-jerrysteve1101@gmail.com> (raw)
In-Reply-To: <20260204-venus-dweller-20e2c228acc4@spud>

Hello,
> On Tue, Feb 03, 2026 at 10:39:42PM +0800, Jun Yan wrote:
> > Add the device-tree binding for the bosch BMX055 IMU (magnetometer
> > part), which is compatible with bmc150_magn.
> >=20
> > Datasheet: https://cdn.sparkfun.com/assets/b/9/1/f/4/bst-bmx055-ds000_dat=
> asheet.pdf
> > Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> > ---
> >  .../iio/magnetometer/bosch,bmc150_magn.yaml        | 14 +++++++++-----
> >  1 file changed, 9 insertions(+), 5 deletions(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/bosch,bmc=
> 150_magn.yaml b/Documentation/devicetree/bindings/iio/magnetometer/bosch,bm=
> c150_magn.yaml
> > index a3838ab0c524..09d1dc861d4f 100644
> > --- a/Documentation/devicetree/bindings/iio/magnetometer/bosch,bmc150_mag=
> n.yaml
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/bosch,bmc150_mag=
> n.yaml
> > @@ -21,11 +21,15 @@ properties:
> >      description:
> >        Note the bmm150_magn is a deprecated compatible as this part conta=
> ins only
> >        a magnetometer.
> > -    enum:
> > -      - bosch,bmc150_magn
> > -      - bosch,bmc156_magn
> > -      - bosch,bmm150
> > -      - bosch,bmm150_magn
> > +    oneOf:
> > +      - enum:
> > +          - bosch,bmc150_magn
> > +          - bosch,bmc156_magn
> > +          - bosch,bmm150
> > +          - bosch,bmm150_magn
> > +      - items:
> 
> > +          - const: bosch,bmx055_magn
> 
> s/_/-/ here please, we don't permit _s in new compatibles.
Got it, will change _ to - for the new compatibles.

Best regards,
Jun Yan
> pw-bot: changes-requested
> 
> > +          - const: bosch,bmc150_magn
> > =20
> >    reg:
> >      maxItems: 1
> > --=20
> > 2.52.0
> >=20
> >=20

  reply	other threads:[~2026-02-05 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 14:39 [PATCH v3 0/3] iio: add support for Bosch BMX055 IMU Jun Yan
2026-02-03 14:39 ` [PATCH v3 1/3] dt-bindings: iio: accel: bosch,bma255: add bmx055 accel binding Jun Yan
2026-02-04 17:57   ` Conor Dooley
2026-02-06 12:47   ` Linus Walleij
2026-02-03 14:39 ` [PATCH v3 2/3] dt-bindings: iio: magnetometer: bosch,bmc150_magn: add bmx055 magnetometer binding Jun Yan
2026-02-04 17:58   ` Conor Dooley
2026-02-05 14:31     ` Jun Yan [this message]
2026-02-03 14:39 ` [PATCH v3 3/3] dt-bindings: iio: gyroscope: bosch,bmg160: add bmx055 gyroscope binding Jun Yan
2026-02-04 17:58   ` Conor Dooley
2026-02-03 23:36 ` [PATCH v3 0/3] iio: add support for Bosch BMX055 IMU Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260205143116.521460-1-jerrysteve1101@gmail.com \
    --to=jerrysteve1101@gmail.com \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=jic23@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox