From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: rodrigo.alencar@analog.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v3 3/9] iio: amplifiers: ad8366: use devm_mutex_init() and drop mutex_init()
Date: Thu, 5 Feb 2026 20:32:55 +0000 [thread overview]
Message-ID: <20260205203255.4bee225e@jic23-huawei> (raw)
In-Reply-To: <aYKmoIe4sXNcMEYa@smile.fi.intel.com>
On Wed, 4 Feb 2026 03:53:36 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Feb 03, 2026 at 11:24:09AM +0000, Rodrigo Alencar via B4 Relay wrote:
>
> > Adopt proper mutex lifecycle with devm_mutex_init(),
> > replacing mutex_init().
>
> ...
>
> It's better to add here
>
> struct device *dev = &spi->dev;
>
> and (re-)use it in all followup patches. This will make the code easier
> to read.
Just to be clear. Please add a patch before this making use of
what Andy suggests in existing code. Then it will be available
to use in this patch as well.
Thanks,
Jonathan
>
> > + ret = devm_mutex_init(&spi->dev, &st->lock);
> > + if (ret)
> > + return ret;
>
next prev parent reply other threads:[~2026-02-05 20:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 11:24 [PATCH v3 0/9] iio: amplifiers: ad8366: driver update and dt support Rodrigo Alencar via B4 Relay
2026-02-03 11:24 ` [PATCH v3 1/9] MAINTAINERS: Add missing maintainer entry for AD8366 driver Rodrigo Alencar via B4 Relay
2026-02-03 11:24 ` [PATCH v3 2/9] dt-bindings: iio: amplifiers: Add AD8366 support Rodrigo Alencar via B4 Relay
2026-02-04 17:59 ` Conor Dooley
2026-02-03 11:24 ` [PATCH v3 3/9] iio: amplifiers: ad8366: use devm_mutex_init() and drop mutex_init() Rodrigo Alencar via B4 Relay
2026-02-04 1:53 ` Andy Shevchenko
2026-02-05 20:32 ` Jonathan Cameron [this message]
2026-02-03 11:24 ` [PATCH v3 4/9] iio: amplifiers: ad8366: drop reset_gpio from private struct Rodrigo Alencar via B4 Relay
2026-02-04 1:55 ` Andy Shevchenko
2026-02-05 18:12 ` Rodrigo Alencar
2026-02-06 7:32 ` Andy Shevchenko
2026-02-03 11:24 ` [PATCH v3 5/9] iio: amplifiers: ad8366: refactor device resource management Rodrigo Alencar via B4 Relay
2026-02-03 11:24 ` [PATCH v3 6/9] iio: amplifiers: ad8366: sort header includes Rodrigo Alencar via B4 Relay
2026-02-04 1:58 ` Andy Shevchenko
2026-02-03 11:24 ` [PATCH v3 7/9] iio: amplifiers: ad8366: add device tree support Rodrigo Alencar via B4 Relay
2026-02-04 2:07 ` Andy Shevchenko
2026-02-03 11:24 ` [PATCH v3 8/9] iio: amplifiers: ad8366: consume enable gpio Rodrigo Alencar via B4 Relay
2026-02-04 2:22 ` Andy Shevchenko
2026-02-03 11:24 ` [PATCH v3 9/9] iio: amplifiers: ad8366: Update device support Rodrigo Alencar via B4 Relay
2026-02-04 2:23 ` Andy Shevchenko
2026-02-05 20:37 ` [PATCH v3 0/9] iio: amplifiers: ad8366: driver update and dt support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205203255.4bee225e@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox