From: Conor Dooley <conor@kernel.org>
To: linux-riscv@lists.infradead.org, Conor Dooley <conor@kernel.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Felix Gu <ustc.gu@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cache: ax45mp: Fix device node reference leak in ax45mp_cache_init()
Date: Fri, 6 Feb 2026 20:28:45 +0000 [thread overview]
Message-ID: <20260206-shaping-scorpion-63604d9e4949@spud> (raw)
In-Reply-To: <20260131-ax45mp-v1-1-a566905c5c8a@gmail.com>
From: Conor Dooley <conor.dooley@microchip.com>
On Sat, 31 Jan 2026 01:49:09 +0800, Felix Gu wrote:
> In ax45mp_cache_init(), of_find_matching_node() returns a device node
> with an incremented reference count that must be released with
> of_node_put(). The current code fails to call of_node_put() which
> causes a reference leak.
>
> Use the __free(device_node) attribute to ensure automatic cleanup when
> the variable goes out of scope.
>
> [...]
Applied to riscv-soc-fixes, thanks!
[1/1] cache: ax45mp: Fix device node reference leak in ax45mp_cache_init()
https://git.kernel.org/conor/c/0528a348b04b
Thanks,
Conor.
parent reply other threads:[~2026-02-06 20:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260131-ax45mp-v1-1-a566905c5c8a@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206-shaping-scorpion-63604d9e4949@spud \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox