From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085
Date: Sat, 7 Feb 2026 15:10:28 +0000 [thread overview]
Message-ID: <20260207151028.1c4e110b@jic23-huawei> (raw)
In-Reply-To: <20260207-hypnotic-passionate-crocodile-e5be30@quoll>
On Sat, 7 Feb 2026 11:52:57 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Fri, Feb 06, 2026 at 03:08:22PM +0200, Antoniu Miclaus wrote:
> > Add device tree binding support for the AD4085 16-bit SAR ADC.
> > Add adi,ad4085 to the compatible enum.
> >
> > A fallback compatible string to adi,ad4080 is not appropriate as the
> > AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring
> > different driver configuration.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
>
> Squash the patches. You just added one line, but commit msg is 5 lines.
> Exactly copied from previous commit.
Squashing the driver changes as well into a single patch with all 3
new devices added seems sensible alongside squashing the DT.
The changes are all very similar across the 3 patches.
Jonathan
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2026-02-07 15:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 13:08 [PATCH 0/6] iio: adc: ad4080: add support for AD4082, AD4085 and AD4088 Antoniu Miclaus
2026-02-06 13:08 ` [PATCH 1/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4082 Antoniu Miclaus
2026-02-06 13:08 ` [PATCH 2/6] iio: adc: ad4080: " Antoniu Miclaus
2026-02-06 13:56 ` Andy Shevchenko
2026-02-06 13:57 ` Andy Shevchenko
2026-02-08 9:37 ` Nuno Sá
2026-02-06 13:08 ` [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085 Antoniu Miclaus
2026-02-07 10:52 ` Krzysztof Kozlowski
2026-02-07 15:10 ` Jonathan Cameron [this message]
2026-02-16 9:23 ` Miclaus, Antoniu
2026-02-16 10:09 ` Krzysztof Kozlowski
2026-02-06 13:08 ` [PATCH 4/6] iio: adc: ad4080: " Antoniu Miclaus
2026-02-08 9:36 ` Nuno Sá
2026-02-06 13:08 ` [PATCH 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088 Antoniu Miclaus
2026-02-07 10:53 ` Krzysztof Kozlowski
2026-02-06 13:08 ` [PATCH 6/6] iio: adc: ad4080: " Antoniu Miclaus
2026-02-08 9:36 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260207151028.1c4e110b@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox