public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: David Gibson <david@gibson.dropbear.id.au>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Ayush Singh <ayush@beagleboard.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree-spec@vger.kernel.org,
	Hui Pu <hui.pu@gehealthcare.com>,
	Ian Ray <ian.ray@gehealthcare.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>
Subject: [RFC PATCH 07/15] libfdt: fdt_check_full: Handle FDT_NOP when FDT_END is expected
Date: Tue, 10 Feb 2026 18:33:35 +0100	[thread overview]
Message-ID: <20260210173349.636766-8-herve.codina@bootlin.com> (raw)
In-Reply-To: <20260210173349.636766-1-herve.codina@bootlin.com>

fdt_check_full() makes the assumption that a FDT_END tag is present
immediately after the FDT_END_NODE tag related to the root node.

This assumption is not correct. Indeed, FDT_NOP tags can be present
between this FDT_END_NODE tag and the FDT_END tag.

Handle those possible FDT_NOP tags.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 libfdt/fdt_check.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libfdt/fdt_check.c b/libfdt/fdt_check.c
index a21ebbc..cca0523 100644
--- a/libfdt/fdt_check.c
+++ b/libfdt/fdt_check.c
@@ -43,7 +43,7 @@ int fdt_check_full(const void *fdt, size_t bufsize)
 			return nextoffset;
 
 		/* If we see two root nodes, something is wrong */
-		if (expect_end && tag != FDT_END)
+		if (expect_end && tag != FDT_END && tag != FDT_NOP)
 			return -FDT_ERR_BADSTRUCTURE;
 
 		switch (tag) {
-- 
2.52.0


  parent reply	other threads:[~2026-02-10 17:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 17:33 [RFC PATCH 00/15] Add support for structured tags and v18 dtb version Herve Codina
2026-02-10 17:33 ` [RFC PATCH 01/15] dtc: Use a consistent type for basenamelen Herve Codina
2026-02-13  6:14   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 02/15] fdtdump: Remove dtb version check Herve Codina
2026-02-14  2:12   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 03/15] fdtdump: Return an error code on wrong tag value Herve Codina
2026-02-23  5:38   ` David Gibson
2026-02-23  8:39     ` Herve Codina
2026-02-24  5:57       ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 04/15] libfdt: fdt_rw: Introduce fdt_downgrade_version() Herve Codina
2026-02-24  6:09   ` David Gibson
2026-02-10 17:33 ` [RFC PATCH 05/15] libfdt: Introduce fdt_first_node() Herve Codina
2026-02-10 17:33 ` [RFC PATCH 06/15] libfdt: Don't assume that a FDT_BEGIN_NODE tag is available at offset 0 Herve Codina
2026-02-10 17:33 ` Herve Codina [this message]
2026-03-04 10:08   ` [RFC PATCH 07/15] libfdt: fdt_check_full: Handle FDT_NOP when FDT_END is expected David Gibson
2026-02-10 17:33 ` [RFC PATCH 08/15] tests: asm: Introduce treehdr_vers macro Herve Codina
2026-02-10 17:33 ` [RFC PATCH 09/15] Introduce structured tag value definition Herve Codina
2026-02-10 17:33 ` [RFC PATCH 10/15] fdtdump: Handle unknown tags Herve Codina
2026-02-10 17:33 ` [RFC PATCH 11/15] flattree: " Herve Codina
2026-02-10 17:33 ` [RFC PATCH 12/15] libfdt: Handle unknown tags in fdt_get_next() Herve Codina
2026-02-10 17:33 ` [RFC PATCH 13/15] libfdt: Introduce fdt_ptr_offset_ Herve Codina
2026-02-10 17:33 ` [RFC PATCH 14/15] libfdt: Handle unknown tags on dtb modifications Herve Codina
2026-02-10 17:33 ` [RFC PATCH 15/15] Introduce v18 dtb version Herve Codina
2026-03-12  7:54 ` [RFC PATCH 00/15] Add support for structured tags and " Herve Codina
2026-03-12 10:21   ` David Gibson
2026-03-16 16:16     ` Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210173349.636766-8-herve.codina@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=ayush@beagleboard.org \
    --cc=conor+dt@kernel.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree-compiler@vger.kernel.org \
    --cc=devicetree-spec@vger.kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=hui.pu@gehealthcare.com \
    --cc=ian.ray@gehealthcare.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox