From: Conor Dooley <conor@kernel.org>
To: Riccardo Mereu <r.mereu.kernel@arduino.cc>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alexey.klimov@linaro.org,
srinivas.kandagatla@oss.qualcomm.com, m.facchin@arduino.cc,
akucheri@qti.qualcomm.com, ndechesn@quicinc.com,
Riccardo Mereu <r.mereu@arduino.cc>
Subject: Re: [PATCH V2] arm64: dts: qcom: arduino-imola: fix faulty spidev node
Date: Thu, 12 Feb 2026 17:55:39 +0000 [thread overview]
Message-ID: <20260212-retired-eldercare-14f91dfaf995@spud> (raw)
In-Reply-To: <20260212152329.134065-1-r.mereu.kernel@arduino.cc>
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
On Thu, Feb 12, 2026 at 04:23:29PM +0100, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
>
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
>
> Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---
> arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> index 197ab6eb1666..796c1f7ff17c 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> @@ -328,18 +328,10 @@ &spi5 {
> spidev@0 {
Of you're modifying this node, you should fix the nodename too. "spidev"
isn't a type of device. It should probably either be "mcu@" or whatever
the mcu is used for.
> reg = <0>;
> compatible = "arduino,unoq-mcu";
> - pinctrl-0 = <&spidev_cs>;
> - pinctrl-names = "default";
> };
> };
>
> &tlmm {
> - spidev_cs: spidev-cs-state {
> - pins = "gpio17";
> - function = "gpio";
> - drive-strength = <16>;
> - };
> -
> jmisc_gpio18: jmisc-gpio18-state {
> pins = "gpio18";
> function = "gpio";
> --
> 2.53.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-02-12 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 15:23 [PATCH V2] arm64: dts: qcom: arduino-imola: fix faulty spidev node Riccardo Mereu
2026-02-12 15:26 ` Konrad Dybcio
2026-02-12 17:55 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212-retired-eldercare-14f91dfaf995@spud \
--to=conor@kernel.org \
--cc=akucheri@qti.qualcomm.com \
--cc=alexey.klimov@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.facchin@arduino.cc \
--cc=ndechesn@quicinc.com \
--cc=r.mereu.kernel@arduino.cc \
--cc=r.mereu@arduino.cc \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox