From: Yixun Lan <dlan@gentoo.org>
To: Yao Zi <me@ziyao.cc>
Cc: Yixun Lan <dlan@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ze Huang <huang.ze@linux.dev>,
Junzhong Pan <panjunzhong@linux.spacemit.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] phy: k1-usb: k3: add USB2 PHY support
Date: Thu, 12 Feb 2026 22:35:30 +0800 [thread overview]
Message-ID: <20260212143530-GYB114046@gentoo.org> (raw)
In-Reply-To: <aY253_fOkoQKbi8g@pie>
Hi Yao,
On 11:30 Thu 12 Feb , Yao Zi wrote:
> On Thu, Feb 12, 2026 at 09:38:56AM +0800, Yixun Lan wrote:
> > Add USB2 PHY support for SpacemiT K3 SoC.
> >
> > Register layout of handling USB disconnect operation has been changed,
> > So introducing a platform data to distinguish the different SoCs.
>
> Would it be clearer and simpler if you define separate phy_ops for
> k1 and k3, and point of_device_id.data directly to the corresponding
> phy_ops? Then there's no need to introduce either spacemit_usb2phy_data
> structure, or spacemit_usb2phy_disconnect wrapper.
>
Yes, I agree, thanks for the suggestion
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-02-12 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 1:38 [PATCH 0/3] phy: spacemit: Add USB2 PHY support for K3 SoC Yixun Lan
2026-02-12 1:38 ` [PATCH 1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support Yixun Lan
2026-02-12 12:03 ` Krzysztof Kozlowski
2026-02-12 1:38 ` [PATCH 2/3] phy: k1-usb: add disconnect function support Yixun Lan
2026-02-12 11:24 ` Yao Zi
2026-02-12 14:43 ` Yixun Lan
2026-02-12 1:38 ` [PATCH 3/3] phy: k1-usb: k3: add USB2 PHY support Yixun Lan
2026-02-12 11:30 ` Yao Zi
2026-02-12 14:35 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212143530-GYB114046@gentoo.org \
--to=dlan@gentoo.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=huang.ze@linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@ziyao.cc \
--cc=neil.armstrong@linaro.org \
--cc=panjunzhong@linux.spacemit.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox