* [PATCH v2] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation
@ 2026-02-14 6:34 hehuan1
2026-02-14 9:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: hehuan1 @ 2026-02-14 6:34 UTC (permalink / raw)
To: ulf.hansson, robh, krzk+dt, conor+dt, jszhang, linux-mmc,
devicetree, linux-kernel
Cc: ningyu, linmin, pinkesh.vaghela, xuxiang, Huan He, Pritesh Patel
From: Huan He <hehuan1@eswincomputing.com>
The binding defines tuple-style reset-names items for some
compatibles, which implicitly enforces a fixed array length
via JSON Schema.
Defining global maxItems for resets and reset-names causes these
constraints to be intersected via allOf, resulting in an effective
minItems equal to the global maxItems. This leads to dtbs_check
failures reporting reset arrays as too short, even when the DTS
provides the correct number of entries.
Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
Signed-off-by: Huan He <hehuan1@eswincomputing.com>
---
Changes in v2:
- Keep the global maxItems constraints and add minItems: 4 for both
resets and reset-names properties
- Update commit message
- Link to v1: https://lore.kernel.org/all/20260211094736.88-1-hehuan1@eswincomputing.com/
---
Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
index 7e7c55dc2440..f268f3b6f153 100644
--- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
@@ -50,9 +50,11 @@ properties:
maxItems: 1
resets:
+ minItems: 4
maxItems: 5
reset-names:
+ minItems: 4
maxItems: 5
rockchip,txclk-tapnum:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation
2026-02-14 6:34 [PATCH v2] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation hehuan1
@ 2026-02-14 9:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-14 9:05 UTC (permalink / raw)
To: hehuan1
Cc: ulf.hansson, robh, krzk+dt, conor+dt, jszhang, linux-mmc,
devicetree, linux-kernel, ningyu, linmin, pinkesh.vaghela,
xuxiang, Pritesh Patel
On Sat, Feb 14, 2026 at 02:34:50PM +0800, hehuan1@eswincomputing.com wrote:
> From: Huan He <hehuan1@eswincomputing.com>
>
> The binding defines tuple-style reset-names items for some
> compatibles, which implicitly enforces a fixed array length
> via JSON Schema.
>
> Defining global maxItems for resets and reset-names causes these
> constraints to be intersected via allOf, resulting in an effective
> minItems equal to the global maxItems. This leads to dtbs_check
> failures reporting reset arrays as too short, even when the DTS
> provides the correct number of entries.
>
> Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
> Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>
>
> ---
> Changes in v2:
> - Keep the global maxItems constraints and add minItems: 4 for both
> resets and reset-names properties
> - Update commit message
>
> - Link to v1: https://lore.kernel.org/all/20260211094736.88-1-hehuan1@eswincomputing.com/
> ---
> Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 7e7c55dc2440..f268f3b6f153 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -50,9 +50,11 @@ properties:
> maxItems: 1
>
> resets:
> + minItems: 4
> maxItems: 5
>
> reset-names:
> + minItems: 4
> maxItems: 5
You miss to update now minItems: 5 in one of the "if:" cases. Otherwise
please explain why that device(s) should have now 4 or 5 resets.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-14 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-14 6:34 [PATCH v2] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation hehuan1
2026-02-14 9:05 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox