From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59FC920C461; Sat, 14 Feb 2026 17:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771091002; cv=none; b=M8KMWpObW0QlMoiF3Jx6AsS/fv8Lyf5U9wqJRAsyAHF3Vwy+7eRqE7OD1Kt0XocWoZezbT5I73BPL8CCqh+jB4z51KAbvdGLjcWSUshRvJBIO4HuTOFGhZOklN9WMtYDxYCyTna17QwM+fJBWF+WJU6X9QyeNxLbOrdxLLzbQxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771091002; c=relaxed/simple; bh=LrraUdxh+9Xmfu3AnFcCt3uJHTANTmtR1eAiz2CEjsk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AqphDGXeGbFt5xyKw5qVFxFexPrlO4HpxW4uEgqcLcJxaip754yCs2R+SdbV8I8a6fjOw8z7HYgTd64Y4TgdVYLrDvc705sEX/rm7PWCZFzY/1WwrJtpwnkFHAY1IuVrw/bsCn5djxrwIwBS+ADY8fMWWPF+E+BDUsePcTcPL44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=svOyzcXA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="svOyzcXA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6267C16AAE; Sat, 14 Feb 2026 17:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771091001; bh=LrraUdxh+9Xmfu3AnFcCt3uJHTANTmtR1eAiz2CEjsk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=svOyzcXAoLsp1T7xT1in+7BqyXFiHTDk+fyye8rFxv/ASej5tyxZRgRiWkhXA/w3I b03KTnF/iJU5whjpCXDY7d3dFoYuKeguY1T8TAvQfO55TNUNy1ezLUDlQP6A0zN8z1 lqId3U0I2Hn9O4E384jUXy4qKvJiFlo6l4pedAEjUee8YocXYXUXh0aRWZCVVAUZSU oXsJyp3Zag16zigzwXf6Bm8lyM4nG9xkLr4/am6vvM+x68GR2N+ll9ixfvFFAJGuyU OrYGk7w3uRlddyekae0sDzgl1J2BJImEXyZyuaIn6HgL9ePVw2vNN/EhX//BkpLyl3 EO8AIFojuDwyg== Date: Sat, 14 Feb 2026 17:43:12 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Yasin Lee , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , yasin.lee.x@outlook.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/4] iio: proximity: hx9023s: Protect against division by zero in set_samp_freq Message-ID: <20260214174312.7f6e299f@jic23-huawei> In-Reply-To: References: <20260213-upstream-20260219-v3-0-df9371d29f5c@gmail.com> <20260213-upstream-20260219-v3-2-df9371d29f5c@gmail.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 13 Feb 2026 18:39:16 +0200 Andy Shevchenko wrote: > On Fri, Feb 13, 2026 at 11:14:44PM +0800, Yasin Lee wrote: > > Avoid division by zero when sampling frequency is unspecified. > > In case of agreement this is the desired behaviour you can add > Reviewed-by: Andy Shevchenko It seems sensible to me as avoids undefined behaviour + is unlikely to make any functional difference as I assume that whatever we got from the undef never in practice matched a valid input. So applied patches 1 and 2 to my fixes-togreg branch. I'm not pushing that out just now though as I want rc1 to rebase it on first. Thanks, Jonathan >