From: Jonathan Cameron <jic23@kernel.org>
To: Yasin Lee <yasin.lee.x@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
yasin.lee.x@outlook.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v3 4/4] iio: proximity: hx9023s: support firmware-name property
Date: Sat, 14 Feb 2026 17:44:46 +0000 [thread overview]
Message-ID: <20260214174446.1d850785@jic23-huawei> (raw)
In-Reply-To: <20260213-upstream-20260219-v3-4-df9371d29f5c@gmail.com>
On Fri, 13 Feb 2026 23:14:46 +0800
Yasin Lee <yasin.lee.x@gmail.com> wrote:
> Add an optional firmware-name property to specify the firmware file.
> If not provided, the driver falls back to the default firmware name.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Yasin Lee <yasin.lee.x@gmail.com>
Applied 3-4 to the testing branch of iio.git. I'll be rebasing once rc1
once it's available.
Thanks,
Jonathan
> ---
> drivers/iio/proximity/hx9023s.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c
> index 17e00ee2b6f8..9efaa5b6b5bd 100644
> --- a/drivers/iio/proximity/hx9023s.c
> +++ b/drivers/iio/proximity/hx9023s.c
> @@ -1088,6 +1088,7 @@ static int hx9023s_probe(struct i2c_client *client)
> struct device *dev = &client->dev;
> struct iio_dev *indio_dev;
> struct hx9023s_data *data;
> + const char *fw_name;
> int ret;
>
> indio_dev = devm_iio_device_alloc(dev, sizeof(*data));
> @@ -1125,7 +1126,9 @@ static int hx9023s_probe(struct i2c_client *client)
> if (ret)
> return dev_err_probe(dev, ret, "channel config failed\n");
>
> - ret = request_firmware_nowait(THIS_MODULE, true, "hx9023s.bin", dev,
> + fw_name = "hx9023s.bin";
> + device_property_read_string(dev, "firmware-name", &fw_name);
> + ret = request_firmware_nowait(THIS_MODULE, true, fw_name, dev,
> GFP_KERNEL, data, hx9023s_cfg_update);
> if (ret)
> return dev_err_probe(dev, ret, "reg config failed\n");
>
prev parent reply other threads:[~2026-02-14 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:14 [PATCH v3 0/4] iio: proximity: hx9023s: firmware property, safety fixes Yasin Lee
2026-02-13 15:14 ` [PATCH v3 1/4] iio: proximity: hx9023s: fix assignment order for __counted_by Yasin Lee
2026-02-14 16:18 ` Yasin Lee
2026-02-13 15:14 ` [PATCH v3 2/4] iio: proximity: hx9023s: Protect against division by zero in set_samp_freq Yasin Lee
2026-02-13 16:39 ` Andy Shevchenko
2026-02-14 17:43 ` Jonathan Cameron
2026-02-15 4:06 ` Yasin Lee
2026-02-13 15:14 ` [PATCH v3 3/4] dt-bindings: iio: proximity: hx9023s: support firmware-name property Yasin Lee
2026-02-14 8:38 ` Krzysztof Kozlowski
2026-02-13 15:14 ` [PATCH v3 4/4] " Yasin Lee
2026-02-14 17:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260214174446.1d850785@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=yasin.lee.x@gmail.com \
--cc=yasin.lee.x@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox