Re: [PATCH v3 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2552 bytes --]

On Tue, Feb 17, 2026 at 04:29:59PM +0200, Svyatoslav Ryhel wrote:
> вт, 17 лют. 2026 р. о 16:03 Conor Dooley <conor@kernel.org> пише:
> > On Tue, Feb 17, 2026 at 01:34:01PM +0200, Svyatoslav Ryhel wrote:
> > > 17 лютого 2026 р. 13:32:26 GMT+02:00, Krzysztof Kozlowski <krzk@kernel.org> пише:

> > > >> properties:
> > > >>   compatible:
> > > >>       - items:
> > > >>           - enum:
> > > >>               - asus,p1801-t-ec-pad
> > > >>               - asus,sl101-ec-dock
> > > >>               - asus,tf101-ec-dock
> > > >>               - asus,tf101g-ec-dock
> > > >>               - asus,tf201-ec-dock
> > > >>               - asus,tf201-ec-pad
> > > >>               - asus,tf300t-ec-dock
> > > >>               - asus,tf300t-ec-pad
> > > >>               - asus,tf300tg-ec-dock
> > > >>               - asus,tf300tg-ec-pad
> > > >>               - asus,tf300tl-ec-dock
> > > >>               - asus,tf300tl-ec-pad
> > > >>               - asus,tf700t-ec-dock
> > > >>               - asus,tf700t-ec-pad
> > > >>               - asus,tf600t-ec-pad
> > > >>               - asus,tf701t-ec-pad
> > > >>           - const: asus,transformer-ec
> > > >>
> > > >> And them schema name will match the genetic compatible.
> > > >
> > > >Then what does the generic compatible express?
> > > >
> > >
> > > Then enum it is
> >
> >
> > Why would you do that, instead of what I posted earlier in the thread?
> > If you send a flat enum with all devices listed, I'm gonna just be there
> > telling you to consolidate into one device-specific fallback compatible
> > per programming model.
> 
> There is no one device-specific fallback compatible! Schema describes
> HARDWARE not drivers no? I will not use random device compatible from
> the list as a fallback compatible for a different random unrelated
> device, that is plain wrong.

Which is why I am not mentioning drivers at all, and instead talking about
programming models. Fallback compatibles represent similarities in
programming model, even if the laptop that these devices are contained
in are different, so whatever device compatible you pick might be random
(but going chronologically is usually my recommendation) but it won't be
unrelated.

> Discuss this with Krzysztof and come up with something meaningful please.

If you don't consider my reviews to be meaningful, you're welcome to
carry a Nacked-by: Conor Dooley <conor.dooley@microchip.com> with a link
to this discussion instead.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]