[PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Ronald Claveau]

Add PLL for the clock controller of the Amlogic T7 SoC family.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/dt-bindings/clock/amlogic,t7-pll-clkc.h b/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
index e2481f2f1163..690421009eab 100644
--- a/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
+++ b/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
@@ -53,4 +53,20 @@
 #define CLKID_MCLK_1_PRE	9
 #define CLKID_MCLK_1		10
 
+/* ANALOG */
+#define CLKID_FPLL_DCO		0
+#define CLKID_FPLL			1
+#define CLKID_FDIV2_DIV		2
+#define CLKID_FDIV2			3
+#define CLKID_FDIV2P5_DIV	4
+#define CLKID_FDIV2P5		5
+#define CLKID_FDIV3_DIV		6
+#define CLKID_FDIV3			7
+#define CLKID_FDIV4_DIV		8
+#define CLKID_FDIV4			9
+#define CLKID_FDIV5_DIV		10
+#define CLKID_FDIV5			11
+#define CLKID_FDIV7_DIV		12
+#define CLKID_FDIV7			13
+
 #endif /* __T7_PLL_CLKC_H */
-- 
2.49.0

Re: [PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Krzysztof Kozlowski]

On 18/02/2026 11:17, Ronald Claveau wrote:
> Add PLL for the clock controller of the Amlogic T7 SoC family.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---

This is not a separate patch, but belongs to the one adding this
binding/compatible.

Best regards,
Krzysztof

[PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Ronald Claveau]

Add PLL for the clock controller of the Amlogic T7 SoC family.

Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
 include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/dt-bindings/clock/amlogic,t7-pll-clkc.h b/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
index e2481f2f1163..690421009eab 100644
--- a/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
+++ b/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
@@ -53,4 +53,20 @@
 #define CLKID_MCLK_1_PRE	9
 #define CLKID_MCLK_1		10
 
+/* ANALOG */
+#define CLKID_FPLL_DCO		0
+#define CLKID_FPLL			1
+#define CLKID_FDIV2_DIV		2
+#define CLKID_FDIV2			3
+#define CLKID_FDIV2P5_DIV	4
+#define CLKID_FDIV2P5		5
+#define CLKID_FDIV3_DIV		6
+#define CLKID_FDIV3			7
+#define CLKID_FDIV4_DIV		8
+#define CLKID_FDIV4			9
+#define CLKID_FDIV5_DIV		10
+#define CLKID_FDIV5			11
+#define CLKID_FDIV7_DIV		12
+#define CLKID_FDIV7			13
+
 #endif /* __T7_PLL_CLKC_H */
-- 
2.49.0

Re: [PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Jerome Brunet]

On mer. 18 févr. 2026 at 11:56, Ronald Claveau <linux-kernel-dev@aliel.fr> wrote:

> Add PLL for the clock controller of the Amlogic T7 SoC family.

Usually bindings changes should comes before the driver changes in a
series.

This is especially important here because you are using the IDs in the
driver. With order used here, bisect is broken.

>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
>  include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/include/dt-bindings/clock/amlogic,t7-pll-clkc.h b/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
> index e2481f2f1163..690421009eab 100644
> --- a/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
> +++ b/include/dt-bindings/clock/amlogic,t7-pll-clkc.h
> @@ -53,4 +53,20 @@
>  #define CLKID_MCLK_1_PRE	9
>  #define CLKID_MCLK_1		10
>  
> +/* ANALOG */
No idea what you mean with this ...

> +#define CLKID_FPLL_DCO		0
> +#define CLKID_FPLL			1
> +#define CLKID_FDIV2_DIV		2
> +#define CLKID_FDIV2			3
> +#define CLKID_FDIV2P5_DIV	4
> +#define CLKID_FDIV2P5		5
> +#define CLKID_FDIV3_DIV		6
> +#define CLKID_FDIV3			7
> +#define CLKID_FDIV4_DIV		8
> +#define CLKID_FDIV4			9
> +#define CLKID_FDIV5_DIV		10
> +#define CLKID_FDIV5			11
> +#define CLKID_FDIV7_DIV		12
> +#define CLKID_FDIV7			13
> +
>  #endif /* __T7_PLL_CLKC_H */

-- 
Jerome

Re: [PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Krzysztof Kozlowski]

On 18/02/2026 11:56, Ronald Claveau wrote:
> Add PLL for the clock controller of the Amlogic T7 SoC family.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
>  include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)

So you ignored my comments?

And that's v2, not v1. You sent v1 and GOT the comments.

Best regards,
Krzysztof

Re: [PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Jerome Brunet]

On mer. 18 févr. 2026 at 20:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 18/02/2026 11:56, Ronald Claveau wrote:
>> Add PLL for the clock controller of the Amlogic T7 SoC family.
>> 
>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
>> ---
>>  include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>
> So you ignored my comments?
>
> And that's v2, not v1. You sent v1 and GOT the comments.

I think this was still v1 and if you look at timestamps, Patch 1 was sent
before your first reply, then there is lot of time between the different
patches - probably done manually  ... at patch 6 (the one you've
commented fist) was sent twice.

I think there is no malice here, just first time contribution with a few
mistakes ;)

>
> Best regards,
> Krzysztof
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Jerome

Re: [PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Krzysztof Kozlowski]

On 18/02/2026 20:28, Jerome Brunet wrote:
> On mer. 18 févr. 2026 at 20:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> On 18/02/2026 11:56, Ronald Claveau wrote:
>>> Add PLL for the clock controller of the Amlogic T7 SoC family.
>>>
>>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
>>> ---
>>>  include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>
>> So you ignored my comments?
>>
>> And that's v2, not v1. You sent v1 and GOT the comments.
> 
> I think this was still v1 and if you look at timestamps, Patch 1 was sent

No

> before your first reply, then there is lot of time between the different
> patches - probably done manually  ... at patch 6 (the one you've
> commented fist) was sent twice.

1. v1:
https://lore.kernel.org/all/20260218101728.35497-1-linux-kernel-dev@aliel.fr/
Wed, 18 Feb 2026 11:17:26 +0100

2. My reply 5 minutes later:
https://lore.kernel.org/all/a848fa43-6a46-4fd6-86a4-96aaf82e2a02@kernel.org/
Wed, 18 Feb 2026 11:21:13 +0100	

3. This patch send half an hour later:
https://lore.kernel.org/all/20260218105611.36216-1-linux-kernel-dev@aliel.fr/
Wed, 18 Feb 2026 *11:56:09* +0100	

after I already provided feedback about wrong threading.


Best regards,
Krzysztof

Re: [PATCH 2/7] dt-bindings: clk: meson: Add Amlogic T7 fix pll support

[Krzysztof Kozlowski]

On 18/02/2026 20:37, Krzysztof Kozlowski wrote:
> On 18/02/2026 20:28, Jerome Brunet wrote:
>> On mer. 18 févr. 2026 at 20:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>>> On 18/02/2026 11:56, Ronald Claveau wrote:
>>>> Add PLL for the clock controller of the Amlogic T7 SoC family.
>>>>
>>>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
>>>> ---
>>>>  include/dt-bindings/clock/amlogic,t7-pll-clkc.h | 16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>
>>> So you ignored my comments?
>>>
>>> And that's v2, not v1. You sent v1 and GOT the comments.
>>
>> I think this was still v1 and if you look at timestamps, Patch 1 was sent
> 
> No
> 
>> before your first reply, then there is lot of time between the different
>> patches - probably done manually  ... at patch 6 (the one you've
>> commented fist) was sent twice.
> 
> 1. v1:
> https://lore.kernel.org/all/20260218101728.35497-1-linux-kernel-dev@aliel.fr/
> Wed, 18 Feb 2026 11:17:26 +0100
> 
> 2. My reply 5 minutes later:
> https://lore.kernel.org/all/a848fa43-6a46-4fd6-86a4-96aaf82e2a02@kernel.org/
> Wed, 18 Feb 2026 11:21:13 +0100	
> 
> 3. This patch send half an hour later:
> https://lore.kernel.org/all/20260218105611.36216-1-linux-kernel-dev@aliel.fr/
> Wed, 18 Feb 2026 *11:56:09* +0100	

Ah, and I forgot to mention - author replied to me in private at:
Wed, 18 Feb 2026 11:28:23 +0100

So BEFORE this was sent, thus he already received my first reply to v1
and this had to be conscious sending of next version, thus v2.

> 
> after I already provided feedback about wrong threading.
> 
> 
> Best regards,
> Krzysztof


Best regards,
Krzysztof