Re: [PATCH 2/3] Input: add support for Goodix GTX8 Touchscreen ICs

[kernel test robot <lkp@intel.com>]

Hi Aelin,

kernel test robot noticed the following build errors:

[auto build test ERROR on fe9e3edb6a215515d1148d32a5c445c5bdd7916f]

url:    https://github.com/intel-lab-lkp/linux/commits/Aelin-Reidel/dt-bindings-input-document-Goodix-GTX8-Touchscreen-ICs/20260218-075424
base:   fe9e3edb6a215515d1148d32a5c445c5bdd7916f
patch link:    https://lore.kernel.org/r/20260218-gtx8-v1-2-0d575b3dedc5%40mainlining.org
patch subject: [PATCH 2/3] Input: add support for Goodix GTX8 Touchscreen ICs
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260218/202602181848.DK5Wc0iI-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260218/202602181848.DK5Wc0iI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602181848.DK5Wc0iI-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/input/touchscreen/goodix_gtx8.c: In function 'goodix_gtx8_report_state':
>> drivers/input/touchscreen/goodix_gtx8.c:110:37: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
     110 |                         finger_id = FIELD_GET(
         |                                     ^~~~~~~~~
   In file included from include/linux/kernel.h:35,
                    from include/linux/random.h:7,
                    from include/linux/nodemask.h:94,
                    from include/linux/numa.h:6,
                    from include/linux/cpumask.h:15,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:63,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/slab.h:17,
                    from include/linux/resource_ext.h:11,
                    from include/linux/acpi.h:14,
                    from include/linux/i2c.h:13,
                    from drivers/input/touchscreen/goodix_gtx8.c:16:
   drivers/input/touchscreen/goodix_gtx8.c: At top level:
>> drivers/input/touchscreen/goodix_gtx8.c:555:37: error: 'goodix_gtx8_pm_ops' undeclared here (not in a function); did you mean 'goodix_gtx8_probe'?
     555 |                 .pm = pm_sleep_ptr(&goodix_gtx8_pm_ops),
         |                                     ^~~~~~~~~~~~~~~~~~
   include/linux/util_macros.h:136:44: note: in definition of macro 'PTR_IF'
     136 | #define PTR_IF(cond, ptr)       ((cond) ? (ptr) : NULL)
         |                                            ^~~
   drivers/input/touchscreen/goodix_gtx8.c:555:23: note: in expansion of macro 'pm_sleep_ptr'
     555 |                 .pm = pm_sleep_ptr(&goodix_gtx8_pm_ops),
         |                       ^~~~~~~~~~~~


vim +/FIELD_GET +110 drivers/input/touchscreen/goodix_gtx8.c

    87	
    88	static void goodix_gtx8_report_state(struct goodix_gtx8_core *cd, u8 touch_num,
    89					     union goodix_gtx8_touch *touch_data)
    90	{
    91		union goodix_gtx8_touch *t;
    92		int i;
    93		u8 finger_id;
    94	
    95		for (i = 0; i < touch_num; i++) {
    96			t = &touch_data[i];
    97	
    98			if (cd->ic_data->ic_type == IC_TYPE_NORMANDY) {
    99				input_mt_slot(cd->input_dev, t->normandy.finger_id);
   100				input_mt_report_slot_state(cd->input_dev,
   101							   MT_TOOL_FINGER, true);
   102	
   103				touchscreen_report_pos(cd->input_dev, &cd->props,
   104						       __le16_to_cpu(t->normandy.x),
   105						       __le16_to_cpu(t->normandy.y),
   106						       true);
   107				input_report_abs(cd->input_dev, ABS_MT_TOUCH_MAJOR,
   108						 t->normandy.w);
   109			} else {
 > 110				finger_id = FIELD_GET(
   111					GOODIX_GTX8_FINGER_ID_MASK_YELLOWSTONE,
   112					t->yellowstone.finger_id);
   113				input_mt_slot(cd->input_dev, finger_id);
   114				input_mt_report_slot_state(cd->input_dev,
   115							   MT_TOOL_FINGER, true);
   116	
   117				touchscreen_report_pos(cd->input_dev, &cd->props,
   118						       __be16_to_cpu(t->yellowstone.x),
   119						       __be16_to_cpu(t->yellowstone.y),
   120						       true);
   121				input_report_abs(cd->input_dev, ABS_MT_TOUCH_MAJOR,
   122						 t->yellowstone.w);
   123			}
   124		}
   125	
   126		input_mt_sync_frame(cd->input_dev);
   127		input_sync(cd->input_dev);
   128	}
   129	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki