From: Yuanshen Cao <alex.caoys@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yuanshen Cao <alex.caoys@gmail.com>
Subject: [PATCH v3 2/2] usb: typec: tcpm: Add vid and chip info for Etek ET7304
Date: Fri, 20 Feb 2026 06:22:41 +0000 [thread overview]
Message-ID: <20260220-et7304-v3-2-ede2d9634957@gmail.com> (raw)
In-Reply-To: <20260220-et7304-v3-0-ede2d9634957@gmail.com>
Move VID field to chip info to accommodate different VIDs.
Add chip info for Etek Micro ET7304. ET7304 is functionally
identical to the Richtek RT1715, with the only difference
being the VID.
Signed-off-by: Yuanshen Cao <alex.caoys@gmail.com>
---
drivers/usb/typec/tcpm/tcpci_rt1711h.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
index 88c50b984e8a..37cf55ad74f8 100644
--- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
+++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
@@ -19,9 +19,11 @@
#include <linux/regulator/consumer.h>
#define RT1711H_VID 0x29CF
+#define ET7304_VID 0x6DCF
#define RT1711H_PID 0x1711
#define RT1711H_DID 0x2171
#define RT1715_DID 0x2173
+#define ET7304_DID 0x2173
#define RT1711H_PHYCTRL1 0x80
#define RT1711H_PHYCTRL2 0x81
@@ -55,6 +57,7 @@
struct rt1711h_chip_info {
u32 rxdz_sel;
+ u16 vid;
u16 did;
bool enable_pd30_extended_message;
};
@@ -308,7 +311,7 @@ static int rt1711h_check_revision(struct i2c_client *i2c, struct rt1711h_chip *c
ret = i2c_smbus_read_word_data(i2c, TCPC_VENDOR_ID);
if (ret < 0)
return ret;
- if (ret != RT1711H_VID) {
+ if (ret != chip->info->vid) {
dev_err(&i2c->dev, "vid is not correct, 0x%04x\n", ret);
return -ENODEV;
}
@@ -405,17 +408,27 @@ static void rt1711h_remove(struct i2c_client *client)
tcpci_unregister_port(chip->tcpci);
}
+static const struct rt1711h_chip_info et7304 = {
+ .rxdz_sel = RT1711H_BMCIO_RXDZSEL,
+ .vid = ET7304_VID,
+ .did = ET7304_DID,
+ .enable_pd30_extended_message = true,
+};
+
static const struct rt1711h_chip_info rt1711h = {
+ .vid = RT1711H_VID,
.did = RT1711H_DID,
};
static const struct rt1711h_chip_info rt1715 = {
.rxdz_sel = RT1711H_BMCIO_RXDZSEL,
+ .vid = RT1711H_VID,
.did = RT1715_DID,
.enable_pd30_extended_message = true,
};
static const struct i2c_device_id rt1711h_id[] = {
+ { "et7304", (kernel_ulong_t)&et7304 },
{ "rt1711h", (kernel_ulong_t)&rt1711h },
{ "rt1715", (kernel_ulong_t)&rt1715 },
{}
@@ -423,6 +436,7 @@ static const struct i2c_device_id rt1711h_id[] = {
MODULE_DEVICE_TABLE(i2c, rt1711h_id);
static const struct of_device_id rt1711h_of_match[] = {
+ { .compatible = "etekmicro,et7304", .data = &et7304 },
{ .compatible = "richtek,rt1711h", .data = &rt1711h },
{ .compatible = "richtek,rt1715", .data = &rt1715 },
{}
--
2.53.0
next prev parent reply other threads:[~2026-02-20 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 6:22 [PATCH v3 0/2] Add support for Etek ET7304 Controller Yuanshen Cao
2026-02-20 6:22 ` [PATCH v3 1/2] dt-bindings: usb: document the Etek ET7304 USB Type-C Port Controller Yuanshen Cao
2026-02-20 7:17 ` Krzysztof Kozlowski
2026-02-20 6:22 ` Yuanshen Cao [this message]
2026-02-23 15:09 ` [PATCH v3 2/2] usb: typec: tcpm: Add vid and chip info for Etek ET7304 Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220-et7304-v3-2-ede2d9634957@gmail.com \
--to=alex.caoys@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox