From: Krzysztof Kozlowski <krzk@kernel.org>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: alexandre.belloni@bootlin.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: rtc: isl12026: convert to YAML schema
Date: Fri, 20 Feb 2026 08:48:55 +0100 [thread overview]
Message-ID: <20260220-vigorous-holistic-platypus-6ebebd@quoll> (raw)
In-Reply-To: <20260219055115.195302-1-piyushpatle228@gmail.com>
On Thu, Feb 19, 2026 at 11:21:15AM +0530, Piyush Patle wrote:
> diff --git a/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml b/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml
> new file mode 100644
> index 000000000000..a6822605fd72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/isil,isl12026.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/isil,isl12026.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intersil ISL12026 I2C RTC/EEPROM
> +
> +maintainers:
> + - Piyush Patle <piyushpatle228@gmail.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The ISL12026 is a combination RTC and EEPROM device connected via I2C.
> + The RTC and control registers respond at address 0x6f, while the EEPROM
> + array responds at address 0x57. The "reg" property refers to the RTC
> + portion of the device.
> +
> +select:
> + properties:
> + compatible:
> + const: isil,isl12026
> + required:
> + - compatible
Why do you have this select? Look at existing bindings - NONE have that.
Just in case if that was not obvious: don't send us AI microslop.
> +
> +allOf:
> + - $ref: rtc.yaml#
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-20 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 5:51 [PATCH v2] dt-bindings: rtc: isl12026: convert to YAML schema Piyush Patle
2026-02-20 7:48 ` Krzysztof Kozlowski [this message]
2026-02-20 8:47 ` [PATCH v3] " Piyush Patle
2026-02-21 10:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220-vigorous-holistic-platypus-6ebebd@quoll \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox