[PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups

[PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups

[Frieder Schrempf]

From: Frieder Schrempf <frieder.schrempf@kontron.de>

This contains three fixes and one cosmetic change for
the Kontron i.MX8MP OSM devices.

Changes for v2:
* Add Frank's R-b tags (thanks)
* Enhance commit message of patch 2

Annette Kobou (1):
  arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC

Frieder Schrempf (3):
  arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL
    devices
  arm64: dts: imx8mp-kontron: Drop vmmc-supply to fix SD card on SMARC
    eval carrier
  arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

 .../boot/dts/freescale/imx8mp-kontron-dl.dtso | 26 ++++++++++++++++---
 .../dts/freescale/imx8mp-kontron-osm-s.dtsi   |  6 +++++
 .../imx8mp-kontron-smarc-eval-carrier.dts     |  1 -
 3 files changed, 29 insertions(+), 4 deletions(-)

-- 
2.52.0

[PATCH v2 1/4] arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL devices

[Frieder Schrempf]

From: Frieder Schrempf <frieder.schrempf@kontron.de>

The reset signal needs a pullup, but there is no hardware pullup.
As a workaround, enable the internal pullup to fix the touchscreen.

As this deviates from the default generic GPIO settings in the OSM
devicetree, add a new node for the touch pinctrl and redefine the
generic gpio1 pinctrl.

Fixes: 946ab10e3f40f ("arm64: dts: Add support for Kontron OSM-S i.MX8MP SoM and BL carrier board")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 .../boot/dts/freescale/imx8mp-kontron-dl.dtso | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso b/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
index a3cba41d2b531..7131e9a499ae1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
@@ -77,6 +77,8 @@ &i2c1 {
 	touchscreen@5d {
 		compatible = "goodix,gt928";
 		reg = <0x5d>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_touch>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <6 8>;
 		irq-gpios = <&gpio1 6 0>;
@@ -98,6 +100,16 @@ &lvds_bridge {
 	status = "okay";
 };
 
+/* redefine to remove touch controller GPIOs */
+&pinctrl_gpio1 {
+	fsl,pins = <
+		MX8MP_IOMUXC_GPIO1_IO00__GPIO1_IO00		0x19 /* GPIO_A_0 */
+		MX8MP_IOMUXC_GPIO1_IO01__GPIO1_IO01		0x19 /* GPIO_A_1 */
+		MX8MP_IOMUXC_GPIO1_IO05__GPIO1_IO05		0x19 /* GPIO_A_2 */
+		MX8MP_IOMUXC_GPIO1_IO08__GPIO1_IO08		0x19 /* GPIO_A_5 */
+	>;
+};
+
 &pwm1 {
 	status = "okay";
 };
@@ -108,4 +120,11 @@ pinctrl_panel_stby: panelstbygrp {
 			MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28		0x19
 		>;
 	};
+
+	pinctrl_touch: touchgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_GPIO1_IO06__GPIO1_IO06		0x19
+			MX8MP_IOMUXC_GPIO1_IO07__GPIO1_IO07		0x150
+		>;
+	};
 };
-- 
2.52.0

[PATCH v2 2/4] arm64: dts: imx8mp-kontron: Drop vmmc-supply to fix SD card on SMARC eval carrier

[Frieder Schrempf]

From: Frieder Schrempf <frieder.schrempf@kontron.de>

The SMARC evaluation carrier provides an SD card power switch that
complies with the OSM standard definition. The OSM base devicetree
already describes this correctly.

Stop overriding the vmmc-supply in the board devicetree and rely on
the definition from the OSM base DTS instead to fix the power supply
configuration for the SD card.

Fixes: 6fe1ced5ccab7 ("arm64: dts: Add support for Kontron i.MX8MP SMARC module and eval carrier")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 .../boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts     | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts b/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
index 2173a36ff6917..74d620dd06b7b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-smarc-eval-carrier.dts
@@ -249,6 +249,5 @@ &usb3_phy1 {
 };
 
 &usdhc2 {
-	vmmc-supply = <&reg_vdd_3v3>;
 	status = "okay";
 };
-- 
2.52.0

[PATCH v2 3/4] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC

[Frieder Schrempf]

From: Annette Kobou <annette.kobou@kontron.de>

The PMIC provides a level-shifter for the I2C lines to the RTC.
As the level shifter needs to be enabled before the RTC can be
accessed, we need to make sure that the PMIC driver is probed
first.

As the PMIC also provides the supply voltage for the RTC through
the 3.3V regulator, we can simply express this in the DT to
create the required dependency.

This fixes sporadic boot hangs that occurred when the RTC was
accessed before the level-shifter was enabled.

Fixes: 946ab10e3f40f ("arm64: dts: Add support for Kontron OSM-S i.MX8MP SoM and BL carrier board")
Signed-off-by: Annette Kobou <annette.kobou@kontron.de>
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi
index b97bfeb1c30f8..bc1a261bb000e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi
@@ -330,6 +330,12 @@ rv3028: rtc@52 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_rtc>;
 		interrupts-extended = <&gpio3 24 IRQ_TYPE_LEVEL_LOW>;
+		/*
+		 * While specifying the vdd-supply is normally not strictly necessary,
+		 * here it also makes sure that the PMIC driver enables the level-
+		 * shifter for the RTC before the RTC is probed.
+		 */
+		vdd-supply = <&reg_vdd_3v3>;
 	};
 };
 
-- 
2.52.0

[PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

[Frieder Schrempf]

From: Frieder Schrempf <frieder.schrempf@kontron.de>

To make the code more readable, use the macros for the GPIO and IRQ
settings.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso b/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
index 7131e9a499ae1..41a2bb74f1565 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
@@ -7,6 +7,7 @@
 /plugin/;
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 #include "imx8mp-pinfunc.h"
 
 &{/} {
@@ -80,11 +81,11 @@ touchscreen@5d {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_touch>;
 		interrupt-parent = <&gpio1>;
-		interrupts = <6 8>;
-		irq-gpios = <&gpio1 6 0>;
+		interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
+		irq-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
 		AVDD28-supply = <&reg_vcc_panel>;
 		VDDIO-supply = <&reg_vcc_panel>;
-		reset-gpios = <&gpio1 7 0>;
+		reset-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
 	};
 };
 
-- 
2.52.0

Re: [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

[Daniel Baluta]

On 2/20/26 12:36, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> To make the code more readable, use the macros for the GPIO and IRQ
> settings.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>


Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags

in the commit message above.

With that you can add my:

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

Re: [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

[Fabio Estevam]

On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>
> On 2/20/26 12:36, Frieder Schrempf wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >
> > To make the code more readable, use the macros for the GPIO and IRQ
> > settings.
> >
> > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
>
> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>
> in the commit message above.

Is this suggestion valid?

Shouldn't the tags appear in chronological order?

Re: [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

[Daniel Baluta]

On 2/20/26 13:57, Fabio Estevam wrote:
> On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>> On 2/20/26 12:36, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> To make the code more readable, use the macros for the GPIO and IRQ
>>> settings.
>>>
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>
>> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>>
>> in the commit message above.
> Is this suggestion valid?
>
> Shouldn't the tags appear in chronological order?

Tools like b4 indeed are taking the tags in chronological order.
But I always considered that when sending next version you pick all the tags

and then add your Signed-off-by last.

E.g https://www.spinics.net/lists/kernel/msg5995225.html

Re: [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree

[Frieder Schrempf]

On 20.02.26 13:27, Daniel Baluta wrote:
> On 2/20/26 13:57, Fabio Estevam wrote:
>> On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>>> On 2/20/26 12:36, Frieder Schrempf wrote:
>>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>>
>>>> To make the code more readable, use the macros for the GPIO and IRQ
>>>> settings.
>>>>
>>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>>
>>> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>>>
>>> in the commit message above.
>> Is this suggestion valid?
>>
>> Shouldn't the tags appear in chronological order?
> 
> Tools like b4 indeed are taking the tags in chronological order.
> But I always considered that when sending next version you pick all the tags
> 
> and then add your Signed-off-by last.
> 
> E.g https://www.spinics.net/lists/kernel/msg5995225.html

I've always been adding the collected tags below my S-o-b tag. And I've
never heard any complaints from the i.MX subsystem maintainers, so I
assume it is ok like that and there is no need to change anything.

As far as I know most other subsystems also don't have strict rules for
the tag order.

Re: [PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups

[Frank Li]

On Fri, 20 Feb 2026 11:36:15 +0100, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> This contains three fixes and one cosmetic change for
> the Kontron i.MX8MP OSM devices.
> 
> Changes for v2:
> * Add Frank's R-b tags (thanks)
> * Enhance commit message of patch 2
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL devices
      commit: ed35f6162eb43e5dc232b91e903e6a76ee5f5601
[2/4] arm64: dts: imx8mp-kontron: Drop vmmc-supply to fix SD card on SMARC eval carrier
      commit: 02ef82e09f96a0f5c996cdd4d62e66cb80df9f0f
[3/4] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC
      commit: 0ab1f5f3652424de16b464488c3d3db3d88b1bd5
[4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree
      commit: f7bbf27af999ed3f6568f0266e112eded96f225b

Best regards,
-- 
Frank Li <Frank.Li@nxp.com>

Re: [PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups

[Frank Li]

On Fri, Mar 06, 2026 at 11:02:30AM -0500, Frank Li wrote:
>
> On Fri, 20 Feb 2026 11:36:15 +0100, Frieder Schrempf wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >
> > This contains three fixes and one cosmetic change for
> > the Kontron i.MX8MP OSM devices.
> >
> > Changes for v2:
> > * Add Frank's R-b tags (thanks)
> > * Enhance commit message of patch 2
> >
> > [...]
>
> Applied, thanks!
>
> [1/4] arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL devices
>       commit: ed35f6162eb43e5dc232b91e903e6a76ee5f5601
> [2/4] arm64: dts: imx8mp-kontron: Drop vmmc-supply to fix SD card on SMARC eval carrier
>       commit: 02ef82e09f96a0f5c996cdd4d62e66cb80df9f0f
> [3/4] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC
>       commit: 0ab1f5f3652424de16b464488c3d3db3d88b1bd5

Sorry, I have to drop this one because it cause dtb_check warning.
'vdd-supply' is not allowed.

Although this small changes, please change binding firstly to allow
vdd-supply, at lease binding change need get ACK from dt team firstly.

Please make sure not new warning.

Frank

> [4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree
>       commit: f7bbf27af999ed3f6568f0266e112eded96f225b
>
> Best regards,
> --
> Frank Li <Frank.Li@nxp.com>

Re: [PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups

[Frieder Schrempf]

On 06.03.26 18:42, Frank Li wrote:
> On Fri, Mar 06, 2026 at 11:02:30AM -0500, Frank Li wrote:
>>
>> On Fri, 20 Feb 2026 11:36:15 +0100, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> This contains three fixes and one cosmetic change for
>>> the Kontron i.MX8MP OSM devices.
>>>
>>> Changes for v2:
>>> * Add Frank's R-b tags (thanks)
>>> * Enhance commit message of patch 2
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/4] arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL devices
>>       commit: ed35f6162eb43e5dc232b91e903e6a76ee5f5601
>> [2/4] arm64: dts: imx8mp-kontron: Drop vmmc-supply to fix SD card on SMARC eval carrier
>>       commit: 02ef82e09f96a0f5c996cdd4d62e66cb80df9f0f
>> [3/4] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC
>>       commit: 0ab1f5f3652424de16b464488c3d3db3d88b1bd5
> 
> Sorry, I have to drop this one because it cause dtb_check warning.
> 'vdd-supply' is not allowed.
> 
> Although this small changes, please change binding firstly to allow
> vdd-supply, at lease binding change need get ACK from dt team firstly.
> 
> Please make sure not new warning.

Sorry, I forgot to check the bindings. I sent a v3 which includes a
binding patch.