From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F08DA2D7DEF; Fri, 20 Feb 2026 20:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771620942; cv=none; b=HY9SLnn9xYRbWAtrYOiwqjgZEkye9GrW5kgNjHXXoN/0ACvc3LCe0LlkAuxtofNS4M/EAWnOqwPEO9V6WvcRqlBvA08ziVbD2+RqfKMpDenxBbKQK/jsLmruvVqFZLAtNGVwJbn3mS9g4xExMinNxXuJa3RhwPSeyME5TYrxbcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771620942; c=relaxed/simple; bh=rUju9g9rOqA57K/Fvn2HUkcrXR3jIxCXDnsAM0lx0XQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Rtb6PmgyMLVmH7QL1hkI/xZXIGY0OlCvuNKWKL+XTfKkviqHWXze+b99HspvKA1w2aexatc9hfJcZJr+qcea5cD8QAlwZX7e+37P9bvzT5Iwxq9s2C83UKRmDYZRgXh7olIQ8AWnpLQ55Y0DI84eXnWkP92x0OEyrAf+J2UxwWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=HMdWe2u5; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="HMdWe2u5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Cc:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=9rpUoCqo3mEA9xoFIi0ocMFimUkqOuNPRk/YvetvC/g=; b=HMdWe2u5gGLO79qb2FWIH+mvkk p4kWfQS/znZvlXUuXPG9iF/CIRgfk8R4oaOKnBn8GtFS65Kk1sSQvQvVIhuPMutQVb1S+/1vfr+cS J1eXKt4k2S/jHBgfYZYkGKsFd57Jqz/OAI+ehm8Th0ESEu072x6sSdYLdgjj6ohC6xHOrNQDuWstr 8pwEoKnzFUwH4g0cSC0ZQf4ab36A3OyRyw9KhzLdMZittNqmFXKaO0SCzo24nCdchXMJ1Z5XhQUnT 9oN4o03CsqB9NBWweCS16XmxSYj0nYE1ZItFDuqzvV8XjlHxTP9RoRGBoFgi6Dk4POQCmPYV0VmH+ mIGZFvhw==; Date: Fri, 20 Feb 2026 21:55:13 +0100 From: Andreas Kemnade To: Mithil Bavishi Cc: aaro.koskinen@iki.fi, airlied@gmail.com, conor+dt@kernel.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, khilman@baylibre.com, krzk+dt@kernel.org, laurent.pinchart@ideasonboard.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, neil.armstrong@linaro.org, prabhakar.mahadev-lad.rj@bp.renesas.com, jesszhan0024@gmail.com, rfoss@kernel.org, robh@kernel.org, rogerq@kernel.org, simona@ffwll.ch, thierry.reding@gmail.com, tony@atomide.com, tzimmermann@suse.de, andrzej.hajda@intel.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series Message-ID: <20260220215513.7b85056f@kemnade.info> In-Reply-To: <20260219210408.5451-6-bavishimithil@gmail.com> References: <20260219210408.5451-1-bavishimithil@gmail.com> <20260219210408.5451-6-bavishimithil@gmail.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 19 Feb 2026 16:04:04 -0500 Mithil Bavishi wrote: > Create common device tree for Samsung Espresso series devices > > Let's create a common tree for all the variants first, later we can > device specific trees based on their screen sizes > Imperative mood. > Signed-off-by: Mithil Bavishi > --- [...] > +&omap4_pmx_wkup { > + gpio_keys: gpio-keys-pins { > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x046, WAKEUP_EN | PIN_INPUT | MUX_MODE3) > + /* sim_cd.gpio_wk3 - EXT_WAKEUP */ > + OMAP4_IOPAD(0x056, WAKEUP_EN | PIN_INPUT | MUX_MODE3) > + /* fref_clk3_req.gpio_wk30 - VOL_UP */ > + OMAP4_IOPAD(0x05C, WAKEUP_EN | PIN_INPUT | MUX_MODE3) > + /* fref_clk4_out.gpio_wk8 - VOL_DN */ > + >; > + }; > + > + prox_irq: prox-irq-pins { > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x042, WAKEUP_EN | PIN_INPUT_PULLUP | MUX_MODE3) > + /* sim_clk.gpio_wk1 - PS_VOUT */ > + >; > + }; According to https://www.ti.com/lit/ug/swpu231ap/swpu231ap.pdf Table 3-327 the gpio1 cntroller is always active. So here the WAKEUP_EN is not needed at all (so also no additional irq required). Regards, Andreas