From: Hao Yu <haoyufine@gmail.com>
To: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: jcdra1@gmail.com, akhilesh@ee.iitb.ac.in,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Hao Yu <haoyufine@gmail.com>
Subject: [PATCH 2/2] hwmon: (aht10) Fix initialization commands and add DT support
Date: Sun, 22 Feb 2026 18:58:31 +0800 [thread overview]
Message-ID: <20260222105831.7360-3-haoyufine@gmail.com> (raw)
In-Reply-To: <20260222105831.7360-1-haoyufine@gmail.com>
Correct AHT20 initialization command sequence and
change DHT20 command format to 0bxxxxx notation.
Tested on rk3566_lckfb board with aht20 sensor connected at i2c-2 port.
Signed-off-by: Hao Yu <haoyufine@gmail.com>
---
drivers/hwmon/aht10.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/aht10.c b/drivers/hwmon/aht10.c
index 007befdba977..c18332cc48ba 100644
--- a/drivers/hwmon/aht10.c
+++ b/drivers/hwmon/aht10.c
@@ -37,7 +37,9 @@
#define AHT10_CMD_MEAS 0b10101100
#define AHT10_CMD_RST 0b10111010
-#define DHT20_CMD_INIT 0x71
+#define AHT20_CMD_INIT 0b10111110
+
+#define DHT20_CMD_INIT 0b01110001
/*
* Flags in the answer byte/command
@@ -60,6 +62,15 @@ static const struct i2c_device_id aht10_id[] = {
};
MODULE_DEVICE_TABLE(i2c, aht10_id);
+static const struct of_device_id aht10_of_match[] = {
+ { .compatible = "aosong,aht10", .data = (void *)aht10 },
+ { .compatible = "aosong,aht20", .data = (void *)aht20 },
+ { .compatible = "aosong,dht20", .data = (void *)dht20 },
+ {}
+};
+
+MODULE_DEVICE_TABLE(of, aht10_of_match);
+
/**
* struct aht10_data - All the data required to operate an AHT10/AHT20 chip
* @client: the i2c client associated with the AHT10/AHT20
@@ -341,7 +352,7 @@ static int aht10_probe(struct i2c_client *client)
data->meas_size = AHT20_MEAS_SIZE;
data->crc8 = true;
crc8_populate_msb(crc8_table, AHT20_CRC8_POLY);
- data->init_cmd = AHT10_CMD_INIT;
+ data->init_cmd = AHT20_CMD_INIT;
break;
case dht20:
data->meas_size = AHT20_MEAS_SIZE;
@@ -375,6 +386,7 @@ static int aht10_probe(struct i2c_client *client)
static struct i2c_driver aht10_driver = {
.driver = {
.name = "aht10",
+ .of_match_table = aht10_of_match,
},
.probe = aht10_probe,
.id_table = aht10_id,
--
2.34.1
next prev parent reply other threads:[~2026-02-22 10:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-22 10:58 [PATCH 0/2] Add AHT20 sensor bindings and fix driver initialization Hao Yu
2026-02-22 10:58 ` [PATCH 1/2] dt-bindings: hwmon: add aosong,aht10 family Hao Yu
2026-02-22 10:58 ` Hao Yu [this message]
2026-02-22 15:44 ` [PATCH 2/2] hwmon: (aht10) Fix initialization commands and add DT support Guenter Roeck
2026-02-22 15:46 ` Guenter Roeck
2026-02-23 17:38 ` [PATCH v3 0/2] hwmon: aht10: add Device Tree support Hao Yu
2026-02-23 17:38 ` [PATCH v3 1/2] dt-bindings: hwmon: add Aosong AHT10/AHT20/DHT20 to trivial devices Hao Yu
2026-02-23 17:46 ` Krzysztof Kozlowski
2026-02-24 15:33 ` Guenter Roeck
2026-02-23 17:38 ` [PATCH v3 2/2] hwmon: (aht10) add device tree ID matching Hao Yu
2026-02-24 15:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260222105831.7360-3-haoyufine@gmail.com \
--to=haoyufine@gmail.com \
--cc=akhilesh@ee.iitb.ac.in \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jcdra1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox