From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7AE83385B1; Mon, 23 Feb 2026 17:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771869427; cv=none; b=qOLhEyndaMZlHFNIDL8MMwPafO/34amKccpp05M3lhOvZlWV7AeMB+Xee/jNYF0PoNcjar6fviWJO8O4WCYBN/lw7X7S62yxe3OBH4QLF0CxMQC+QQtiXnZOEbyE3Gq9z388DbU38XXPHCY/5q9My32Ir/CKyUid8NE92el+ueY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771869427; c=relaxed/simple; bh=+R/gbJyXgtSztRTnBWeP96Fbtuk1N3v+xu5HT/+Iap4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GRl4VenY5EEuEghHPS9d8J2Q2Uk6ukTzntj0k4L6PRNquwg5OoAeRAIyQuRIE3seUnDdW6BcGTPtX3AsX2qI393NbqOjbVrCskqz9LBg/uj4Oti7dGBYpNFKzObSrTFQEI1ZpMOKoSt+nfYea8Wk9UpebyWLToHVi9GVFvxTN20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DzPWFZOb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DzPWFZOb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7924BC116C6; Mon, 23 Feb 2026 17:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771869427; bh=+R/gbJyXgtSztRTnBWeP96Fbtuk1N3v+xu5HT/+Iap4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DzPWFZObuuqMb8GufRKvOokRq/Umw/TlX4sFPOs4kGXE4ntWMezIAVT2FGRvP8JsC NjpxOMAtzBXsUhqHzvY1jMwWEdrlX6IeJOaeTnIYm20JbT6Em0ROLTLByLBXeYvG0g gKPZTk0S8KMoDRMC35Z/BGPeNGJvD4VqGJiRFmg+8hp0eEU5daXf7r0S6DUY8+kBO4 xNf6NkmmFd1U1uyv2H6AgQBZQWsijfV11exWp97i2kaBU9aNWuFcRg96zbJXsu0gsi 7m6obYaTFJ44uCWUO5fvYyXp8M9lONPUwamR/cm+wOL4994gH/6CpodPA1VbuNDmrb B/t/FkpwcwhIA== Date: Mon, 23 Feb 2026 11:57:06 -0600 From: Rob Herring To: Hugo Villeneuve Cc: hvilleneuve@dimonoff.com, dmitry.torokhov@gmail.com, krzk+dt@kernel.org, conor+dt@kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: input: add GPIO charlieplex keypad Message-ID: <20260223175706.GA4168417-robh@kernel.org> References: <20260213171431.2228814-1-hugo@hugovil.com> <20260213171431.2228814-2-hugo@hugovil.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260213171431.2228814-2-hugo@hugovil.com> On Fri, Feb 13, 2026 at 12:14:25PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > Add DT bindings for GPIO charlieplex keypad. > > Signed-off-by: Hugo Villeneuve > --- > .../input/gpio-charlieplex-keypad.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/gpio-charlieplex-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/gpio-charlieplex-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-charlieplex-keypad.yaml > new file mode 100644 > index 0000000000000..1672491a75a85 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/gpio-charlieplex-keypad.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/input/gpio-charlieplex-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO charlieplex keypad > + > +maintainers: > + - Hugo Villeneuve > + > +description: > + The charlieplex keypad supports N^2)-N different key combinations (where N is > + the number of lines). Key presses and releases are detected by configuring > + only one line as output at a time, and reading other line states. This process > + is repeated for each line. > + This mechanism doesn't allow to detect simultaneous key presses. > + > +allOf: > + - $ref: input.yaml# > + - $ref: /schemas/input/matrix-keymap.yaml# > + > +properties: > + compatible: > + const: gpio-charlieplex-keypad > + > + autorepeat: true > + > + line-scan-delay-us: > + description: > + Delay, measured in microseconds, that is needed > + before we can scan keypad after activating one line. > + default: 0 Isn't this the same as "col-scan-delay-us" in gpio-matrix-keypad.yaml? If so, move it to matrix-keymap.yaml to re-use it here. If not, there's a bunch of other scan delay properties just from grepping "delay" in the input bindings. Surely we can define something common. Rob